SourceDirectories#static shouldn't depend on GenerateBuildConfig task [328852035]

Fixed

Bug

Status Update

No update yet.

Description

se...@team.bumble.com

created issue #1

Mar 9, 2024 07:21PM

SourceDirectories.Flat#static which was introduced in AGP 8.4, depends on GenerateBuildConfig task which is unexpected and looks like a bug since the sources are supposed to be static unlike SourceDirectories.Flat#all which includes generated sources.
A consequence of this is that static Variant source directories cannot be resolved during the configuration phase using the new Variant API when BuildConfig generation is enabled.

Resolving SourceDirectories.Flat#static during the configuration phase results in the following error:

Querying the mapped value of property(org.gradle.api.file.Directory, property(org.gradle.api.file.Directory, property(org.gradle.api.file.Directory, map(org.gradle.api.file.Directory flatmap(provider(task 'generateDebugBuildConfig', class com.android.build.gradle.tasks.GenerateBuildConfig)) check-type())))) before task ':app:generateDebugBuildConfig' has completed is not supported

AGP version: 8.4.0-alpha13
Repro project: https://github.com/technoir42/static-variant-sources-bug-repro Relates to b/266681484

Comments

ya...@google.com <ya...@google.com> Mar 11, 2024 08:33PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Mar 15, 2024 11:07PM

Reassigned to je...@google.com.

je...@google.com <je...@google.com> #2Mar 19, 2024 09:49PM

Hello, I have tried to reproduce the issue with the provided test case (thanks for that !) and it passed successfully for me... Am I missing something ?

 ~/bugs/b328852035/static-variant-sources-bug-repro   develop  ./gradlew -Pandroid.enableBuildConfigAsBytecode=true :app:myTaskDebug
Downloading https://services.gradle.org/distributions/gradle-8.6-bin.zip
............10%.............20%............30%.............40%.............50%............60%.............70%.............80%............90%.............100%
Starting a Gradle Daemon, 1 incompatible and 1 stopped Daemons could not be reused, use --status for details

> Configure project :app
WARNING: The option setting 'android.enableBuildConfigAsBytecode=true' is experimental.
The current default is 'false'.

> Task :app:myTaskDebug
Hello, world

BUILD SUCCESSFUL in 35s
1 actionable task: 1 executed
 ~/bugs/b328852035/static-variant-sources-bug-repro   develop 

se...@team.bumble.com <se...@team.bumble.com> #3Mar 19, 2024 09:57PM

#2 thanks for looking into this. android.enableBuildConfigAsBytecode=true is a workaround I provided just in case if it would give any hints at the culprit.
The build should pass without any flags when running ./gradlew :app:myTaskDebug, if SourceDirectories.Flat#static didn't depend on BuildConfig generation task.

je...@google.com <je...@google.com> #4Mar 19, 2024 10:12PM

ah yes sorry, did not read carefully, I can repro now. thanks

je...@google.com <je...@google.com> #5Mar 20, 2024 05:05AM

Accepted by je...@google.com.

Change-Id: I06ce8f50c359dadc03b5c7f58c590df29de4b51a

je...@google.com <je...@google.com> #6Mar 21, 2024 04:21PM

Marked as fixed.

Should be available in AGP 8.4 RC-1

an...@google.com <an...@google.com> #7Mar 22, 2024 04:25PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Koala | 2023.3.2 Canary 2
Android Gradle Plugin 8.5.0-alpha02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

md...@gmail.com <md...@gmail.com> #8Mar 25, 2024 09:20AM

Bank si ho

je...@google.com <je...@google.com> #9Mar 26, 2024 04:02PM

merged in 8-4 RC branch.

an...@google.com <an...@google.com> #10Mar 27, 2024 09:53PM

The fixes for this issue are now also available in:

Android Studio Jellyfish | 2023.3.1 Beta 2
Android Gradle Plugin 8.4.0-beta02