Fixed
Status Update
No update yet.
Comments
cc...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
en...@meta.com
cc...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
en...@meta.com
Ah right, I'm blocked on using 1.2.3 in a specific use case due to https://issuetracker.google.com/issues/329145808 . I have a local workaround to use 1.2.3 but didn't use it for today's repro. Let me try to repro with 1.2.3 today
en...@meta.com
Okay, looks like I'm unable to repro this on 1.2.3 anymore. I'm getting an entirely different error consistently with 1.2.3 which is "java.util.NoSuchElementException: Collection contains no element matching the predicate." I'll create a separate issue for this if one doesn't exist already.
Feel free to close this issue out. Thanks for all your help!
Feel free to close this issue out. Thanks for all your help!
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit d55b483632c5662ae95d19479ebbc14f8b23b0ff
Author: Chris Craik <ccraik@google.com>
Date: Mon Apr 01 11:27:57 2024
Add logs / error messages to all startup detection failures
Test: StartupTimingQueryTest
Bug: 329145809
Bug: 305733267
Relnote: "Added log.w / exception labels to all startup detection
failures. This does not change current behavior (so some errors throw,
and others silently fail to detect the startup), just makes it more
understandable. Generally the ones that Log.w() and fail to report
startup metrics are those where non-frame events are missing,
exceptions are thrown when startup is detected except for frame timing
information (from UI/RT slices)."
Likely will want to revisit this in the future to make detection
failure conditions more consistent, this change just makes errors more
comprehensible without needing to dig into the trace.
Change-Id: Id240f7698dfb977457362a137f0070e73dc2495c
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/StartupTimingQuery.kt
https://android-review.googlesource.com/3021184
Branch: androidx-main
commit d55b483632c5662ae95d19479ebbc14f8b23b0ff
Author: Chris Craik <ccraik@google.com>
Date: Mon Apr 01 11:27:57 2024
Add logs / error messages to all startup detection failures
Test: StartupTimingQueryTest
Bug: 329145809
Bug: 305733267
Relnote: "Added log.w / exception labels to all startup detection
failures. This does not change current behavior (so some errors throw,
and others silently fail to detect the startup), just makes it more
understandable. Generally the ones that Log.w() and fail to report
startup metrics are those where non-frame events are missing,
exceptions are thrown when startup is detected except for frame timing
information (from UI/RT slices)."
Likely will want to revisit this in the future to make detection
failure conditions more consistent, this change just makes errors more
comprehensible without needing to dig into the trace.
Change-Id: Id240f7698dfb977457362a137f0070e73dc2495c
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/StartupTimingQuery.kt
cc...@google.com
Above CL should make problems like these a lot easier to diagnose (both missing metric, and collection contains no element matching predicate).
cc...@google.com
Actual missing content issue was tracked/fixed in
Treating this bug as about the discoverability/logging side, so closing this as fixed.
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-macro:1.3.0-alpha03
Description
Component used: Version used: Benchmark Macro v.1.2.3 Devices/Android versions reproduced on: Android emulator (API 30)
I am often seeing the error: "Skipping results from iter $iteration, it didn't capture all metrics" from emulator runs of cold start tests. I currently have my test set to 10 iterations and get any where from 2-9 metrics in the output json file although I see 10 successful startups in the UI and. in the Benchmark logs.
If this is a bug in the library, we would appreciate if you could attach: