Status Update
Comments
sg...@google.com <sg...@google.com>
ve...@gmail.com <ve...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Fix ActivityNavigator not encoding with NavType
Expand for full commit details
Fix ActivityNavigator not encoding with NavType
When navigating with dynamic arugments, ActivityNavigator should first try to encode the argument value with the associated NavType. If NavType is not present (XML file has dataPattern but not arguments added) then we should fallback to existing behavior of just encoding the arg value with toString().
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 383616432
Relnote: "When navigating to activity with dataPattern, ActivityNavigator will now try to encode the arg value with the argument's NavType."
Change-Id: I163763c46090ae9b4c8ee75d52142986e507c0c3
Files:
- M
navigation/navigation-runtime/src/androidTest/java/androidx/navigation/ActivityNavigatorTest.kt
- M
navigation/navigation-runtime/src/main/java/androidx/navigation/ActivityNavigator.kt
Hash: ad1ddb7df46854191c753e309e72216fae9309de
Date: Mon Jan 06 15:51:40 2025
ma...@google.com <ma...@google.com> #3
Fixed internally and available in navigation 2.9.0-alpha05
uj...@gmail.com <uj...@gmail.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-runtime:2.9.0-alpha05
androidx.navigation:navigation-runtime:2.8.6
on...@aol.com <on...@aol.com> #5
I've created a PR for this, can you please take a look? Thanks in advance.
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
Author: Ondřej Kycelt <
Link:
Expose sheetGesturesEnabled in ModalBottomSheetLayout
Expand for full commit details
Expose sheetGesturesEnabled in ModalBottomSheetLayout
Test: ./gradlew compose:material:material-navigation:cC
Bug: 329543529
Relnote: Expose `sheetGesturesEnabled` in `ModalBottomSheetLayout`
Change-Id: I3f032d9016b1730b1a90392209f7c07fa6617343
Files:
- M
compose/material/material-navigation/api/current.txt
- M
compose/material/material-navigation/api/restricted_current.txt
- M
compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheet.kt
Hash: ce608883ec1c53a771e59afcc8c09d429a11009d
Date: Fri Dec 13 11:43:10 2024
on...@aol.com <on...@aol.com> #7
Thanks for the quick review. May I ask if this will be also released in 1.7 or just 1.8?
Description
Previously created Pull Request for the same