MlKitAnalyzer accuracy significantly decreased on version 1.3.0 [330091012]

Fixed

Bug

Status Update

No update yet.

Description

ne...@miracl.com

created issue #1

Mar 18, 2024 01:32PM

CAMERAX VERSION: 1.3.0

DESCRIPTION:

We are using MLKitAnalyzer with CameraController to scan QR codes. When upgrading from version 1.2.3 to 1.3.0 and above, we've noticed that the camera must be positioned very close to the QR code in order to successfully scan it. Previously, QR codes were scannable from a greater distance away from the camera.

ADDITIONAL INFORMATION:

It appears that the issue may be related to the resolution and the new ResolutionSelector API. Manually setting the ResolutionStrategy via setImageAnalysisResolutionSelector added in version 1.4.0-alpha4 improves the accuracy.

EXAMPLE CONFIGURATION:

val previewView: PreviewView = findViewById(R.id.viewFinder)
val cameraController = LifecycleCameraController(baseContext)

val options = BarcodeScannerOptions.Builder()
    .setBarcodeFormats(Barcode.FORMAT_QR_CODE)
    .build()
val barcodeScanner = BarcodeScanning.getClient(options)

cameraController.setImageAnalysisAnalyzer(
    ContextCompat.getMainExecutor(this),
    MlKitAnalyzer(
        listOf(barcodeScanner),
        COORDINATE_SYSTEM_VIEW_REFERENCED,
        ContextCompat.getMainExecutor(this)
    ) { result: MlKitAnalyzer.Result? ->
        result?.getValue(barcodeScanner)?.firstOrNull()?.rawValue?.let { qrCode ->
            cameraController.unbind()
            Toast.makeText(
                this,
                qrCode,
                Toast.LENGTH_LONG
            ).show()
        }
    }
)

cameraController.cameraSelector = CameraSelector.DEFAULT_BACK_CAMERA
cameraController.bindToLifecycle(this)
previewView.controller = cameraController

Comments

wu...@google.com <wu...@google.com> Mar 19, 2024 01:46AM

Reassigned to xi...@google.com.

xi...@google.com <xi...@google.com> Mar 19, 2024 03:19PM

Accepted by xi...@google.com.

xi...@google.com <xi...@google.com> #2Mar 19, 2024 05:47PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ch...@google.com <ch...@google.com> #3Mar 20, 2024 06:31AM

Accepted by ch...@google.com.

Thanks for reporting this issue. After checking, the issue is caused by that the Analyzer's default target resolution is not correctly merged to the final ResolutionSelector instance.

When using ResolutionSelector with ResolutionStrategy directly, the set ResolutionSelector will directly be used no matter the analyzer has default target resolution or not.

I will fix this issue.

ne...@miracl.com <ne...@miracl.com> #4Mar 22, 2024 07:22AM

Thanks for your swift response and for identifying the issue. Looking forward to the fix.

ap...@google.com <ap...@google.com> #5Mar 26, 2024 03:53AM

Project: platform/frameworks/support
Branch: androidx-main

commit 1c3f4cb30dc07227c1d3d0dc1d3804b5c4447e15
Author: CharcoalChen <charcoalchen@google.com>
Date: Fri Mar 22 10:45:47 2024

Fix ImageAnalysis analyzer default target resolution merge issue

ImageAnalysis analyzer default target resolution was not correctly merged into ResolutionSelector.

Relnote: "Fixed ImageAnalysis' resolution selection issue related to the analyzer default target resolution setting: target resolution was incorrectly kept as 640x480 even if applications has set a different analyzer default resolution setting. If applications encounter this issue (1.3.0 ~ 1.3.2) and can't upgrade to use the newer version releases which contain the solution, directly setting a ResolutionSelector with the preferred resolution and a matching AspectRatioStrategy to the ImageAnalysis UseCase can workaround this issue."

Bug: 330091012
Test: ImageAnalysisTest
Change-Id: I81f72a850dcedb664e5b661247991ee4851bdfc6

M camera/camera-core/src/main/java/androidx/camera/core/ImageAnalysis.java
M camera/camera-core/src/main/java/androidx/camera/core/UseCase.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageAnalysisTest.java

https://android-review.googlesource.com/3008297

ch...@google.com <ch...@google.com> #6Mar 26, 2024 05:46AM

Marked as fixed.

aosp/3008297 has been merged for this issue. The fix will be included in the next 1.4.0 release.

na...@google.com <na...@google.com> #7Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-core:1.3.3
androidx.camera:camera-core:1.4.0-alpha05

av...@gmail.com <av...@gmail.com> #8Oct 31, 2024 09:32PM

Direct_Deposit_Form_ES_copia.pdf

av...@gmail.com <av...@gmail.com> #9Oct 31, 2024 09:33PM

Porque no me yega AMI villera