Composables animate in from top left corner of screen when using a `NavHost` [330111602]

Fixed

Bug

Status Update

No update yet.

Description

go...@gmail.com

created issue #1

Mar 18, 2024 01:29PM

Component used: Navigation Version used: 2.7.7 Devices/Android versions reproduced on: Android 14 Pixel 3A Emulator & Android 14 Pixel 6 Pro

When using a NavHost to navigate between pages, the new composable is animated in from the top left. This can be seen in my own project compiler in release mode ( shown in the video 2024-03-18 20-38-28.mkv), but also in a sample project I made to test this bug.

In the attached sample project, it seems to become much less common after the page is switched a few times, but resetting the emulator makes it come back. The video 2024-03-18 21-11-39.mkv shows the same problem occurring in the sample project with a NavigationBar, and 2024-03-18 21-21-51.mkv, where a NavigationBar is not present.

2024-03-18 21-21-51.mkv

2 MB

Download

2024-03-18 21-11-39.mkv

1.8 MB

Download

2024-03-18 20-38-28.mkv

640 KB

Download

sample.tar.gz

48 MB

Download

Comments

il...@google.com <il...@google.com> #2Mar 18, 2024 06:27PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

go...@gmail.com <go...@gmail.com> #3Mar 19, 2024 02:35AM

That seems to solve the problem of the new composable sliding, but now it jumps from the center of the screen to its intended position, with and without animations enabled.

Video attached shows this.

2024-03-19 10-33-25.mkv

538 KB

Download

jb...@google.com <jb...@google.com> #4Mar 19, 2024 05:50PM

Hmm, I see that you have a lot of Alignment.Center adjustments in your content. What happens if you instead use Alignment.TopStart, passing that into the NavHost contentAlignment parameter as well.

go...@gmail.com <go...@gmail.com> #5Mar 20, 2024 04:20AM

Oh that does seem to work, why is is that using the NavHost to align the pages works better?

jb...@google.com <jb...@google.com> Mar 25, 2024 04:41PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #6Mar 26, 2024 08:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3a7a8942158d2dfbe5b77c25eb7861dcdea9ed95
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Mar 25 19:23:20 2024

Change the default contentAlignment to TopStart

Moving the NavHost default contentAlignment to `Alignment.TopStart` in
order to match the defaults of AnimatedContent. We previously used
`Alignment.Center` to match the previous used `CrossFade` API, but it
would cause unexpected position transitions when using specific
component such as column, row, etc.

RelNote: "`NavHost` now used `Alignment.TopStart` as the default
contentAlignment argument. This puts it in line with the default for
`AnimatedContent` and fixes some instances of an unexpected scale from
center transition."
Test: tested in sample app
Bug: 330111602

Change-Id: I09e7260d31cb571039629acd83b58eaf000a2493

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt

https://android-review.googlesource.com/3011915

jb...@google.com <jb...@google.com> #7Mar 26, 2024 08:04PM

Marked as fixed.

This has been fixed internally and will be available in the Navigation 2.8.0-alpha06 release.

Issue 330111602

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Mar 18, 2024 06:27PM

go...@gmail.com <go...@gmail.com> #3Mar 19, 2024 02:35AM

jb...@google.com <jb...@google.com> #4Mar 19, 2024 05:50PM

go...@gmail.com <go...@gmail.com> #5Mar 20, 2024 04:20AM

jb...@google.com <jb...@google.com> Mar 25, 2024 04:41PM

ap...@google.com <ap...@google.com> #6Mar 26, 2024 08:01PM

jb...@google.com <jb...@google.com> #7Mar 26, 2024 08:04PM

Add comment

Issue metadata