Fixed
Status Update
No update yet.
Comments
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
go...@gmail.com
jb...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
go...@gmail.com
Oh that does seem to work, why is is that using the NavHost to align the pages works better?
jb...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 3a7a8942158d2dfbe5b77c25eb7861dcdea9ed95
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Mar 25 19:23:20 2024
Change the default contentAlignment to TopStart
Moving the NavHost default contentAlignment to `Alignment.TopStart` in
order to match the defaults of AnimatedContent. We previously used
`Alignment.Center` to match the previous used `CrossFade` API, but it
would cause unexpected position transitions when using specific
component such as column, row, etc.
RelNote: "`NavHost` now used `Alignment.TopStart` as the default
contentAlignment argument. This puts it in line with the default for
`AnimatedContent` and fixes some instances of an unexpected scale from
center transition."
Test: tested in sample app
Bug: 330111602
Change-Id: I09e7260d31cb571039629acd83b58eaf000a2493
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt
https://android-review.googlesource.com/3011915
Branch: androidx-main
commit 3a7a8942158d2dfbe5b77c25eb7861dcdea9ed95
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Mar 25 19:23:20 2024
Change the default contentAlignment to TopStart
Moving the NavHost default contentAlignment to `Alignment.TopStart` in
order to match the defaults of AnimatedContent. We previously used
`Alignment.Center` to match the previous used `CrossFade` API, but it
would cause unexpected position transitions when using specific
component such as column, row, etc.
RelNote: "`NavHost` now used `Alignment.TopStart` as the default
contentAlignment argument. This puts it in line with the default for
`AnimatedContent` and fixes some instances of an unexpected scale from
center transition."
Test: tested in sample app
Bug: 330111602
Change-Id: I09e7260d31cb571039629acd83b58eaf000a2493
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt
jb...@google.com
This has been fixed internally and will be available in the Navigation 2.8.0-alpha06 release.
Description
Component used: Navigation Version used: 2.7.7 Devices/Android versions reproduced on: Android 14 Pixel 3A Emulator & Android 14 Pixel 6 Pro
When using a
NavHostto navigate between pages, the new composable is animated in from the top left. This can be seen in my own project compiler in release mode ( shown in the video2024-03-18 20-38-28.mkv), but also in a sample project I made to test this bug.In the attached sample project, it seems to become much less common after the page is switched a few times, but resetting the emulator makes it come back. The video
2024-03-18 21-11-39.mkvshows the same problem occurring in the sample project with aNavigationBar, and2024-03-18 21-21-51.mkv, where aNavigationBaris not present.