IssueTracker

CAMERAX VERSION 1.4.0-alpha04

CAMERA APPLICATION NAME AND VERSION: 12.0.01.85

ANDROID OS BUILD NUMBER: Android 12 (SP1A.210812.016.G970FXXSGHWC1)

DEVICE NAME: Samsung Galaxy S10e

DESCRIPTION:

When flipping the Camera (back (0) -> front (1)) while recording, I get an IllegalArgumentException causing the Camera to fail to start:

java.lang.IllegalArgumentException: The provider's size(720x1280) must match the parent(1080x1920)
	at androidx.core.util.Preconditions.checkArgument(Preconditions.java:52)
	at androidx.camera.core.processing.SurfaceEdge$SettableSurface.setProvider(SurfaceEdge.java:648)
	at androidx.camera.core.processing.SurfaceEdge.setProvider(SurfaceEdge.java:234)
	at androidx.camera.core.streamsharing.VirtualCameraAdapter.forceSetProvider(VirtualCameraAdapter.java:402)
	at androidx.camera.core.streamsharing.VirtualCameraAdapter.onUseCaseActive(VirtualCameraAdapter.java:287)
	at androidx.camera.core.streamsharing.VirtualCamera.onUseCaseActive(VirtualCamera.java:81)
	at androidx.camera.core.UseCase.notifyState(UseCase.java:599)
	at androidx.camera.core.UseCase.notifyActive(UseCase.java:546)
	at androidx.camera.video.VideoCapture.onStateAttached(VideoCapture.java:410)
	at androidx.camera.core.streamsharing.VirtualCameraAdapter.notifyStateAttached(VirtualCameraAdapter.java:192)
	at androidx.camera.core.streamsharing.StreamSharing.onStateAttached(StreamSharing.java:208)
	at androidx.camera.camera2.internal.Camera2CameraImpl.notifyStateAttachedAndCameraControlReady(Camera2CameraImpl.java:915)
	at androidx.camera.camera2.internal.Camera2CameraImpl.attachUseCases(Camera2CameraImpl.java:803)
	at androidx.camera.core.internal.CameraUseCaseAdapter.attachUseCases(CameraUseCaseAdapter.java:611)
	at androidx.camera.lifecycle.LifecycleCamera.onStart(LifecycleCamera.java:84)
	at androidx.camera.lifecycle.LifecycleCamera.unsuspend(LifecycleCamera.java:158)
	at androidx.camera.lifecycle.LifecycleCameraRepository.unsuspendUseCases(LifecycleCameraRepository.java:501)
	at androidx.camera.lifecycle.LifecycleCameraRepository.setActive(LifecycleCameraRepository.java:411)
	at androidx.camera.lifecycle.LifecycleCameraRepository.bindToLifecycleCamera(LifecycleCameraRepository.java:319)
	at androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle(ProcessCameraProvider.java:609)
	at androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle(ProcessCameraProvider.java:386)
	at com.mrousavy.camera.core.CameraSession.configureCamera(CameraSession.kt:408)
	at com.mrousavy.camera.core.CameraSession.configure(CameraSession.kt:159)
	at com.mrousavy.camera.CameraView$update$1.invokeSuspend(CameraView.kt:155)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:226)
	at android.os.Looper.loop(Looper.java:313)
	at android.app.ActivityThread.main(ActivityThread.java:8751)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)

LIST ANY EXPERIMENTAL FEATURES: @ExperimentalPersistentRecording

STEPS TO REPRODUCE:

1. Create session with some resolution
2. Start recording
3. Flip camera device
4. (when flipping device/binding to a new camera, make sure to keep the same Recorder instance)
5. see error

OBSERVED RESULTS: I get the error that the sizes don't match

EXPECTED RESULTS: I expect the video output to automatically scale to the current recording size to keep it going (e.g. with OpenGL)

REPRODUCIBILITY: 100

ADDITIONAL INFORMATION: Code is available on GitHub: https://github.com/mrousavy/react-native-vision-camera/tree/v4 (package/example is the example app)

Steps to run:

0. Make sure you have yarn, node and watchman installed (see reactnative.dev quickstart)
1. Clone the react-native-vision-camera repo from GitHub, open Terminal and navigate into the repo folder
2. Run:

   cd package
   yarn
   cd example
   yarn
   

3. Open package/example/android in Android Studio
4. Run

CODE FRAGMENTS (this will help us troubleshoot your issues): https://github.com/mrousavy/react-native-vision-camera/blob/89aef7210dc1032d842685f6ab76863710edc0f4/package/android/src/main/java/com/mrousavy/camera/core/CameraSession.kt#L269-L322