Fixed
Status Update
Comments
sg...@google.com <sg...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 94c9c1be861c2cc6640411680244cde9c4e2372e
Author: Shalom Gibly <sgibly@google.com>
Date: Wed Mar 13 17:10:06 2024
Adds size customization to top app bars
- Added parameters to allow changing the fixed and expanded heights for
all types of top app bars.
- Deprecated (with Hidden) the previous experimental functions and
created new ones that take those params.
- Removed an older deprecated SmallTopAppBar functions
- Fix a performance issue where the single-line top app bars were
recomposing too much when scrolling content.
- Applied a heightIn with a max value to the app bar to better support
showing of DropDown menus from the app bar.
- Fix an accessibility issue with the Medium app bar that was cutting
some of the displayed title when using large font and display.
Fixes: 316594552
Fixes: 323403446
Fixes: 300953236
Fixes: 286296147
Fixes: 330410290
Bug: 308540676
Test: Added tests to AppBarTest.kt
Relnote: "Top app bar APIs now support custom heights for both fixed
and collapsible sections.
Fixed an issue that caused single-line top app bars to recompose too
many times when scrolling content.
Resolved an issue where MediumTopAppBar truncated titles on devices
with large font/display settings."
Change-Id: Ib8b0ce45ed461e7d5110e1473a90ab48c268caa6
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/AppBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
https://android-review.googlesource.com/3000717
Branch: androidx-main
commit 94c9c1be861c2cc6640411680244cde9c4e2372e
Author: Shalom Gibly <sgibly@google.com>
Date: Wed Mar 13 17:10:06 2024
Adds size customization to top app bars
- Added parameters to allow changing the fixed and expanded heights for
all types of top app bars.
- Deprecated (with Hidden) the previous experimental functions and
created new ones that take those params.
- Removed an older deprecated SmallTopAppBar functions
- Fix a performance issue where the single-line top app bars were
recomposing too much when scrolling content.
- Applied a heightIn with a max value to the app bar to better support
showing of DropDown menus from the app bar.
- Fix an accessibility issue with the Medium app bar that was cutting
some of the displayed title when using large font and display.
Fixes: 316594552
Fixes: 323403446
Fixes: 300953236
Fixes: 286296147
Fixes: 330410290
Bug: 308540676
Test: Added tests to AppBarTest.kt
Relnote: "Top app bar APIs now support custom heights for both fixed
and collapsible sections.
Fixed an issue that caused single-line top app bars to recompose too
many times when scrolling content.
Resolved an issue where MediumTopAppBar truncated titles on devices
with large font/display settings."
Change-Id: Ib8b0ce45ed461e7d5110e1473a90ab48c268caa6
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/AppBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
Description
The single-row top app bars recompose too many times when scrolling content behind them.
A little research led to this line as the culprit.