Status Update
No update yet.
Comments
ap...@google.com
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ap...@google.com
da...@google.com
pr...@google.com
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ds...@gmail.com
ju...@gmail.com
Hi, this still seems to be a problem in 2.7.0-alpha11. However, I do not use @RawQuery in my code. I have a custom class that makes use of @Embedded an @Relation which seems to use this under the hood since I receive this honestly meaningless error message The @Database class must be annotated with @ConstructedBy since the source is targeting non-Android platforms..
I only found out about this being related to the missing implementation of @RawQuery on other platforms than Android by running a search with parts of it in quotation marks as the only reference I could find was a single commit in a Git-Repository:
This is a breaking problem for me at the moment since it prevents me from building APKs. Running the app on an emulator works just fine. This issue is marked as fixed and the fix got merged but as I said earlier, it seems to still be there. Is there anything that need to be changed in the code? If the fix isn't rolled out in a new room-Version, when will the time be? Thanks in advance!
da...@google.com
re @RawQuery APIs, can you please file a new bug?
If you are having issue with Room's KMP setup see the following comment for things to checkout:
Description
The current API for
@RawQueryis to write a DAO function that receives aSupportSQLiteQueryand return some POJO / Entity. There is no SQLite KMP API likeSupportSQLiteQueryand its builder.