Status Update
Comments
ap...@google.com <ap...@google.com> #2
Related ticket:
ap...@google.com <ap...@google.com> #3
Branch: androidx-master-dev
commit c0fd11cab1b083d043dfd54c8431c4068aeef09a
Author: Matvei Malkov <malkov@google.com>
Date: Wed Nov 04 17:35:35 2020
Add Modifier.focusable
This CL adds Modifier.focusable, which is intended to be a primary way to add focusability to the app (without clicks or with custom clicks), since it contains proper a11y and InteractionState support
Change-Id: I41eb9d67669e19f8a7c20804c836a8c6dc0b5526
RelNote: "Modifier.focusable has need added in foundation. Use this to add focusable behavior to a component, with correct semantics and accessibility."
Bug: 152525426
Bug: 162865824
Bug: 163423216
Test: added
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/HighLevelGesturesDemo.kt
A compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/FocusableSample.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ScrollableSamples.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ZoomableSample.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/FocusableTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Interaction.kt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Assertions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt
da...@google.com <da...@google.com>
pr...@google.com <pr...@google.com> #4
focusable and hoverable have been added.
Filed separate bugs for 2d scroll (
ds...@gmail.com <ds...@gmail.com> #5
ju...@gmail.com <ju...@gmail.com> #7
Hi, this still seems to be a problem in 2.7.0-alpha11. However, I do not use @RawQuery in my code. I have a custom class that makes use of @Embedded an @Relation which seems to use this under the hood since I receive this honestly meaningless error message The @Database class must be annotated with @ConstructedBy since the source is targeting non-Android platforms.
.
I only found out about this being related to the missing implementation of @RawQuery on other platforms than Android by running a search with parts of it in quotation marks as the only reference I could find was a single commit in a Git-Repository:
This is a breaking problem for me at the moment since it prevents me from building APKs. Running the app on an emulator works just fine. This issue is marked as fixed and the fix got merged but as I said earlier, it seems to still be there. Is there anything that need to be changed in the code? If the fix isn't rolled out in a new room-Version, when will the time be? Thanks in advance!
da...@google.com <da...@google.com> #8
re @RawQuery
APIs, can you please file a new bug?
If you are having issue with Room's KMP setup see the following comment for things to checkout:
Description
The current API for
@RawQuery
is to write a DAO function that receives aSupportSQLiteQuery
and return some POJO / Entity. There is no SQLite KMP API likeSupportSQLiteQuery
and its builder.