Status Update
No update yet.
Comments
an...@google.com
lo...@gmail.com
Hello,
While you're at it, I discovered that re-runs of (soon renamed?) buildLayer does NOT update the layer when running on API 28 (where the GraphicsLayer is backed by GraphicsViewLayer).
It just keeps what was drawn the first time, forever 😬
Is that a quick fix you already see how to address, or do you want to open and link a separate issue? I can also open the issue if you need to.
nj...@google.com
That seems like a duplicate of
lo...@gmail.com
It's not exactly the same, but maybe the solution I suggested in this issue would also work for that bug?
Anyway, I reported it here:
ap...@google.com
Branch: androidx-main
commit 6bb3dd89bf83fc4d6f2825effb2f0fc613c94774
Author: Nader Jawad <njawad@google.com>
Date: Wed Mar 27 18:43:56 2024
Update GraphicsLayer API based on Compose Design
Review feedback
Relnote: "Rename GraphicsLayer#buildLayer to
record to mirror the begin/endRecording methods of
Displaylist backed APIs like RenderNode and Picture.
Updated rememberGraphicsLayer to leverage rememberObserver."
Bug: 288494724
Fixes: 330758155
Test: re-ran compose tests
Change-Id: I312c1120358d04fccfe8a646001a883017fb0fb3
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/samples/src/main/java/androidx/compose/ui/graphics/samples/GraphicsLayerSamples.kt
M compose/ui/ui-graphics/src/androidInstrumentedTest/kotlin/androidx/compose/ui/graphics/layer/AndroidGraphicsLayerTest.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidGraphicsContext.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/AndroidGraphicsLayer.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayerV23.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayerV29.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsViewLayer.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/LayerSnapshot.android.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/DrawScope.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayer.kt
M compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayer.desktop.kt
M compose/ui/ui-graphics/src/desktopTest/kotlin/androidx/compose/ui/graphics/layer/DesktopGraphicsLayerTest.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/draw/DrawModifierTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/draw/DrawingPrebuiltGraphicsLayerTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/GraphicsLayerOwnerLayer.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/draw/DrawModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/graphics/GraphicsLayerScope.kt
M compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/draw/DesktopDrawingPrebuiltGraphicsLayerTest.kt
lo...@gmail.com
Thank you for fixing this!
lo...@gmail.com
Seems like it missed 1.7.0-alpha06 released on the 3rd April.
Will it be in 1.7.0-alpha07 next Wednesday the 17th?
lo...@gmail.com
Hello!
⚠️ ⚠️ ⚠️ I noticed that the same confusing method signature (name and return type) is used in the CacheDrawScope class in the DrawModifier.kt file.
Can you address it as well?
Just noticed it is fixed on
Thanks for doing that!
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui:1.7.0-alpha07androidx.compose.ui:ui-android:1.7.0-alpha07androidx.compose.ui:ui-desktop:1.7.0-alpha07androidx.compose.ui:ui-graphics:1.7.0-alpha07androidx.compose.ui:ui-graphics-android:1.7.0-alpha07androidx.compose.ui:ui-graphics-desktop:1.7.0-alpha07
Description
Jetpack Compose version: 1.7.0-alpha05
Jetpack Compose component(s) used: ui-graphics
Hello!
I've tried the new
GraphicsLayerAPI. It's nice!There's one confusing part: the
buildLayerfunction that takes aGraphicsLayerand returns the very sameGraphicsLayerinstance.I initially called
rememberGraphicsLayer()once, and tried to build multiple layers with it, which led to weird results, and it took me a while to realize that it was because eachbuildLayercall was actually mutating/overwriting the layer I had created withrememberGraphicsLayer().The naming of the function led me to believe that a new layer would be returned, which wasn't the case.
If the behavior is here to stay, I think another name is necessary, to properly communicate the fact that it's touching the layer it's called on.
To avoid this misunderstanding that easily leads to sneakily unwanted behavior (aka. bugs), I suggest a different name is used.
My vote is for
update, without returning theGraphicsLayerobject.The name
updateis already used inside Compose, it's the name of the parameter of theAndroidViewcomposable function that updates stuff inside theView, which, just likeGraphicsLayer, will keep state mutations.I hope it helps!
Have a great day,
Louis CAD