Jetpack Compose version: 1.7.0-alpha05

Jetpack Compose component(s) used: ui-graphics

Hello!

I've tried the new GraphicsLayer API. It's nice!

There's one confusing part: the buildLayer function that takes a GraphicsLayer and returns the very same GraphicsLayer instance.

I initially called rememberGraphicsLayer() once, and tried to build multiple layers with it, which led to weird results, and it took me a while to realize that it was because each buildLayer call was actually mutating/overwriting the layer I had created with rememberGraphicsLayer().

The naming of the function led me to believe that a new layer would be returned, which wasn't the case.

If the behavior is here to stay, I think another name is necessary, to properly communicate the fact that it's touching the layer it's called on.

To avoid this misunderstanding that easily leads to sneakily unwanted behavior (aka. bugs), I suggest a different name is used.

My vote is for update, without returning the GraphicsLayer object.

The name update is already used inside Compose, it's the name of the parameter of the AndroidView composable function that updates stuff inside the View, which, just like GraphicsLayer, will keep state mutations.

I hope it helps!

Have a great day,

Louis CAD