GraphicsLayer.buildLayer name is misleading. Rename it to update and don't return anything [330758155]

Fixed

Bug

Status Update

No update yet.

Description

lo...@gmail.com

created issue #1

Mar 21, 2024 10:41PM

Jetpack Compose version: 1.7.0-alpha05

Jetpack Compose component(s) used: ui-graphics

Hello!

I've tried the new GraphicsLayer API. It's nice!

There's one confusing part: the buildLayer function that takes a GraphicsLayer and returns the very same GraphicsLayer instance.

I initially called rememberGraphicsLayer() once, and tried to build multiple layers with it, which led to weird results, and it took me a while to realize that it was because each buildLayer call was actually mutating/overwriting the layer I had created with rememberGraphicsLayer().

The naming of the function led me to believe that a new layer would be returned, which wasn't the case.

If the behavior is here to stay, I think another name is necessary, to properly communicate the fact that it's touching the layer it's called on.

To avoid this misunderstanding that easily leads to sneakily unwanted behavior (aka. bugs), I suggest a different name is used.

My vote is for update, without returning the GraphicsLayer object.

The name update is already used inside Compose, it's the name of the parameter of the AndroidView composable function that updates stuff inside the View, which, just like GraphicsLayer, will keep state mutations.

I hope it helps!

Have a great day,

Louis CAD

Comments

an...@google.com <an...@google.com> Mar 22, 2024 10:03AM

Assigned to nj...@google.com.

lo...@gmail.com <lo...@gmail.com> #2Mar 29, 2024 04:35PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

nj...@google.com <nj...@google.com> #3Mar 29, 2024 05:21PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

lo...@gmail.com <lo...@gmail.com> #4Mar 29, 2024 05:42PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ap...@google.com <ap...@google.com> #5Mar 29, 2024 07:58PM

Marked as fixed.

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

lo...@gmail.com <lo...@gmail.com> #6Mar 29, 2024 09:49PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

lo...@gmail.com <lo...@gmail.com> #7Apr 15, 2024 06:11PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

lo...@gmail.com <lo...@gmail.com> #8Apr 16, 2024 01:09PM

Thank you, I'll try it and check.

Message last modified on Apr 16, 2024 01:11PM

na...@google.com <na...@google.com> #9Apr 17, 2024 05:17PM

Hello. I have similar experience.

I'm using mlkit-language 16.1.1
I didnot meet this error until using AGP 4.2
I can get this error since using AGP 7.0
This error raised on Release build only(minimized by R8)
This error raised without obfuscation.