FR: Provide a way to suppress AGP compatiblity warnings in the baseline profile plugin [331237001]

Fixed

Feature Request

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Mar 25, 2024 07:42PM

The below warning is quite noisy (and IMO unnecessary for patch releases). Could there be a means to suppress this, for example a gradle property?

This version of the Baseline Profile Gradle Plugin was tested at most with the Android
Gradle Plugin version Android Gradle Plugin version 8.3.0 and it may not work as intended.
Current version is Android Gradle Plugin version 8.3.1.

Comments

cc...@google.com <cc...@google.com> #2Mar 25, 2024 08:37PM

Reassigned to ma...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ma...@google.com <ma...@google.com> Apr 17, 2024 11:13PM

Accepted by ma...@google.com.

ma...@google.com <ma...@google.com> Apr 19, 2024 06:26PM

Accepted by ma...@google.com.

ma...@google.com <ma...@google.com> #3Apr 22, 2024 10:13PM

With aosp/3052862 it's possible to suppress warnings with:

baselineProfile {
    warnings {

        /**
        * Controls the warning for when the Android Gradle Plugin version is higher than the max
        * tested one.
        */
        maxAgpVersion = false

        /**
        * Controls the warning for when a benchmark or baseline profile variant has been disabled.
        */
        disabledVariants = false

        /**
        * Controls the warning printed when invoking `generateBaselineProfile` with AGP 8.0, that
        * does not support running instrumentation tests for multiple build types at once.
        */
        multipleBuildTypesWithAgp80 = false

        /**
        * Controls the warning printed when no baseline profile are generated after running
        * the generate baseline profile command.
        */
        noBaselineProfileRulesGenerated = false

        /**
        * Controls the warning printed when no startup profile are generated after running
        * the generate baseline profile command.
        */
        noStartupProfileRulesGenerated = false
    }
}

This change should be in the next 1.3.0 alpha version.

Message last modified on Apr 22, 2024 10:14PM

ap...@google.com <ap...@google.com> #4Apr 22, 2024 11:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit 970f828d52d060bdb9908083bd3b7c291687f00b
Author: Marcello Albano <maralb@google.com>
Date: Mon Apr 22 11:29:32 2024

Added suppressWarnings options to Baseline Profile Gradle Plugin

Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Bug: 331237001
Relnote: Added DSL to disable warnings
Change-Id: Ic4deb86fc3b91a31854053f19581e9798e43cbd6

M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerExtension.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/task/GenerateBaselineProfileTask.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/task/MergeBaselineProfileTask.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/utils/AgpPlugin.kt
A benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/utils/BaselineProfilePluginLogger.kt
A benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/utils/WarningsExtension.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt

https://android-review.googlesource.com/3052862

ma...@google.com <ma...@google.com> Apr 22, 2024 11:35PM

Marked as fixed.

pu...@gmail.com <pu...@gmail.com> #5May 18, 2024 11:15AM

Does not seem to work for me using these (using latest Koala canary, hence the alpha plugins):

plugins {
    id 'com.android.application' version '8.6.0-alpha02' apply false
    id 'com.android.library' version '8.6.0-alpha02' apply false
    id 'com.android.test' version '8.6.0-alpha02' apply false
    id 'androidx.baselineprofile' version '1.3.0-alpha05' apply false
}

and in the app's build.gradle:

baselineProfile {
    warnings {
        maxAgpVersion = false
    }
}

Running gradle generateReleaseBaselineProfile I still get:

> Configure project :<redacted>
This version of the Baseline Profile Gradle Plugin was tested with versions below Android
Gradle Plugin version Android Gradle Plugin version 8.6.0-alpha01 and it may not work as intended.
Current version is Android Gradle Plugin version 8.6.0-alpha02.

This warning can be disabled setting the following property:
baselineProfile {
    warnings {
        maxAgpVersion = false
    }
}

Moreover the baseline profile module does not recognize the warnings block at all. If I specify it in its build.gradle I get:

A problem occurred evaluating project ':<redacted>:baselineprofile'.
> Could not find method warnings() for arguments [build_8d5dquia6ug00tolkaqmxgwm3$_run_closure2$_closure11@98db54f] on extension 'baselineProfile' of type androidx.baselineprofile.gradle.producer.BaselineProfileProducerExtension.

This is weird since the app's module recognize the warnings block (but it seems inoperative).

Message last modified on May 18, 2024 11:20AM

ma...@google.com <ma...@google.com> May 18, 2024 09:26PM

Status: Assigned (reopened)

ma...@google.com <ma...@google.com> #6May 18, 2024 09:31PM

Thanks for reporting this.

Found a bug and fixed with aosp/3094293 -> should be in the next alpha. The bug should be only for maxAgpVersion.

Note that the warnings block can be specified only in the baseline profile consumer (i.e. library or app).

Message last modified on May 18, 2024 09:32PM

ma...@google.com <ma...@google.com> May 20, 2024 03:39AM

Marked as fixed.

ap...@google.com <ap...@google.com> #7May 20, 2024 03:42AM

Project: platform/frameworks/support
Branch: androidx-main

commit 2e16cf049aadcf74ca52a356aeab0d26ea85f861
Author: Marcello Albano <maralb@google.com>
Date: Sat May 18 14:26:24 2024

Fixed max agp version warning always printed

Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Bug: 331237001
Change-Id: Ic501bf99e7f231132019b8c11bf37149fa3c02a1

M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/utils/AgpPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/utils/BaselineProfilePluginLogger.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt

https://android-review.googlesource.com/3094293

pr...@google.com <pr...@google.com> #8Jun 12, 2024 10:45PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.0-beta01