FR: Provide a way to suppress AGP compatiblity warnings in the baseline profile plugin [331237001]

Fixed

Feature Request

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Mar 25, 2024 07:42PM

The below warning is quite noisy (and IMO unnecessary for patch releases). Could there be a means to suppress this, for example a gradle property?

This version of the Baseline Profile Gradle Plugin was tested at most with the Android
Gradle Plugin version Android Gradle Plugin version 8.3.0 and it may not work as intended.
Current version is Android Gradle Plugin version 8.3.1.

Comments

cc...@google.com <cc...@google.com> #2Mar 25, 2024 08:37PM

Reassigned to ma...@google.com.

Any suggestions on where such an interface might live? I don't think it makes sense for the interface to be in the drawerlayout artifact if you're specifically going to use the interface to *not* use DrawerLayout.

ma...@google.com <ma...@google.com> Apr 17, 2024 11:13PM

Accepted by ma...@google.com.

ma...@google.com <ma...@google.com> Apr 19, 2024 06:26PM

Accepted by ma...@google.com.

ma...@google.com <ma...@google.com> #3Apr 22, 2024 10:13PM

androidx.customview would be a good candidate. This is used by all of the widget libraries.

Message last modified on Apr 22, 2024 10:14PM

ap...@google.com <ap...@google.com> #4Apr 22, 2024 11:06PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020

Create an interface for layouts that can be opened

Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.

Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19

M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/940787

ma...@google.com <ma...@google.com> Apr 22, 2024 11:35PM

Marked as fixed.

pu...@gmail.com <pu...@gmail.com> #5May 18, 2024 11:15AM

Does not seem to work for me using these (using latest Koala canary, hence the alpha plugins):

plugins {
    id 'com.android.application' version '8.6.0-alpha02' apply false
    id 'com.android.library' version '8.6.0-alpha02' apply false
    id 'com.android.test' version '8.6.0-alpha02' apply false
    id 'androidx.baselineprofile' version '1.3.0-alpha05' apply false
}

and in the app's build.gradle:

baselineProfile {
    warnings {
        maxAgpVersion = false
    }
}

Running gradle generateReleaseBaselineProfile I still get:

> Configure project :<redacted>
This version of the Baseline Profile Gradle Plugin was tested with versions below Android
Gradle Plugin version Android Gradle Plugin version 8.6.0-alpha01 and it may not work as intended.
Current version is Android Gradle Plugin version 8.6.0-alpha02.

This warning can be disabled setting the following property:
baselineProfile {
    warnings {
        maxAgpVersion = false
    }
}

Moreover the baseline profile module does not recognize the warnings block at all. If I specify it in its build.gradle I get:

A problem occurred evaluating project ':<redacted>:baselineprofile'.
> Could not find method warnings() for arguments [build_8d5dquia6ug00tolkaqmxgwm3$_run_closure2$_closure11@98db54f] on extension 'baselineProfile' of type androidx.baselineprofile.gradle.producer.BaselineProfileProducerExtension.

This is weird since the app's module recognize the warnings block (but it seems inoperative).

Message last modified on May 18, 2024 11:20AM

ma...@google.com <ma...@google.com> May 18, 2024 09:26PM

Status: Assigned (reopened)

ma...@google.com <ma...@google.com> #6May 18, 2024 09:31PM

Thanks for reporting this.

Found a bug and fixed with aosp/3094293 -> should be in the next alpha. The bug should be only for maxAgpVersion.

Note that the warnings block can be specified only in the baseline profile consumer (i.e. library or app).

Message last modified on May 18, 2024 09:32PM

ma...@google.com <ma...@google.com> May 20, 2024 03:39AM

Marked as fixed.

ap...@google.com <ap...@google.com> #7May 20, 2024 03:42AM

Project: platform/frameworks/support
Branch: androidx-main

commit 2e16cf049aadcf74ca52a356aeab0d26ea85f861
Author: Marcello Albano <maralb@google.com>
Date: Sat May 18 14:26:24 2024

Fixed max agp version warning always printed

Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Bug: 331237001
Change-Id: Ic501bf99e7f231132019b8c11bf37149fa3c02a1

M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/utils/AgpPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/utils/BaselineProfilePluginLogger.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt

https://android-review.googlesource.com/3094293

pr...@google.com <pr...@google.com> #8Jun 12, 2024 10:45PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.0-beta01