FR: Provide a way to suppress AGP compatiblity warnings in the baseline profile plugin [331237001]

Fixed

Feature Request

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Mar 25, 2024 07:42PM

The below warning is quite noisy (and IMO unnecessary for patch releases). Could there be a means to suppress this, for example a gradle property?

This version of the Baseline Profile Gradle Plugin was tested at most with the Android
Gradle Plugin version Android Gradle Plugin version 8.3.0 and it may not work as intended.
Current version is Android Gradle Plugin version 8.3.1.

Comments

cc...@google.com <cc...@google.com> #2Mar 25, 2024 08:37PM

Reassigned to ma...@google.com.

I had created the same issue with wrong component earlier https://issuetracker.google.com/284424171. If anyone has the access to mark that as duplicate, please go ahead.

ma...@google.com <ma...@google.com> Apr 17, 2024 11:13PM

Accepted by ma...@google.com.

ma...@google.com <ma...@google.com> Apr 19, 2024 06:26PM

Accepted by ma...@google.com.

ma...@google.com <ma...@google.com> #3Apr 22, 2024 10:13PM

I noticed in the sample project you're using an emulator with api30.

We found a bug that is being fixed related to api 30 emulator and baseline profile generation.

Could you please try:

Updating the baseline profile gradle plugin version (alpha14 is the latest as we speak)
Change api version to 33 (or anything > 30)

Let me know if this works!

Thanks!

Message last modified on Apr 22, 2024 10:14PM

ap...@google.com <ap...@google.com> #4Apr 22, 2024 11:06PM

deleted

ma...@google.com <ma...@google.com> Apr 22, 2024 11:35PM

Marked as fixed.

pu...@gmail.com <pu...@gmail.com> #5May 18, 2024 11:15AM

Thanks for suggestions and I could generate profiles in few scenarios. Few observations:

The issue seems to be specific to ARM devices running in FTL, regardless of the API version. When testing the application on a physical device (from FTL) with API 33, the profiles were successfully generated. This suggests that the problem lies in the ARM device profiles not being located where the extraction process expects them to be. It's worth investigating whether this issue originates from the plugin itself and whether it requires attention and resolution.
The current behavior of the BaselineProfileConsumerExtension does not save the options saveInSrc and baselineProfileOutputDir in the designated locations. This inconsistency exists when running in FTL managed device. It would be beneficial to enhance the plugin's functionality to ensure consistent behavior across different environments. This improvement would ensure that the specified options for saving profiles are reliably honored, regardless of the testing environment being used.

Message last modified on May 18, 2024 11:20AM

ma...@google.com <ma...@google.com> May 18, 2024 09:26PM

Status: Assigned (reopened)

ma...@google.com <ma...@google.com> #6May 18, 2024 09:31PM

Thanks for your observations.

About your second point: The plugin does not make any distinction around what device the baseline profile generators run, when it come to saveInSrc and baselineProfileOutputDir. Could you please describe the issue more in detail? Or update your sample project if you'd like, so I can give a look.

Message last modified on May 18, 2024 09:32PM

ma...@google.com <ma...@google.com> May 20, 2024 03:39AM

Marked as fixed.

ap...@google.com <ap...@google.com> #7May 20, 2024 03:42AM

Actually could you also please check logcat for the devices where it wasn't generated and look for anything related to dex2oat? I'm wondering if the issue is only in the emulators rather than the gradle task.

pr...@google.com <pr...@google.com> #8Jun 12, 2024 10:45PM

I am trying to save it in the source after generating by following the DSL specification. This works when the tests run locally on GMD and the profiles are saved in the specified directory as mentioned in the documentation. However, if I switch the GMD to run on FTL, it doesn't save.

I have attached the sample project (Macrobenchmark) and included comments in the build.gradle.kts file in baselineProfile module.