Fixed
Status Update
No update yet.
Comments
du...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
d-...@yandex-team.ru
py...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
mo...@google.com
There is a script to add value class collections generateValueClassCollections.sh that works for both sets and lists. I think it is reasonable to expose these.
I do think it is reasonable to expose the packedValue for value types so that this can be done.
mo...@google.com
Dustin, do you have a recommendation for exposing the scripts/templates?
du...@google.com
Exposing packedValue seems reasonable to me. George already put up a CL for this here: aosp/3094908
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 2c947e6474a89b230eb6f7acae460a9059b006c1
Author: George Mount <mount@google.com>
Date: Tue May 21 09:21:11 2024
Expose packedValue properties of IntIntPair and FloatFloatPair
Fixes: 331853566
Relnote: "Exposed the packedValue internal representation for IntIntPair
and FloatFloatPair."
Test: new tests
Change-Id: Ifeb75cb8ea63d2b5c23d78640fd76bf81ec4f090
M collection/collection/api/current.txt
M collection/collection/api/restricted_current.txt
M collection/collection/src/commonMain/kotlin/androidx/collection/FloatFloatPair.kt
M collection/collection/src/commonMain/kotlin/androidx/collection/IntIntPair.kt
M collection/collection/src/commonTest/kotlin/androidx/collection/PairTest.kt
https://android-review.googlesource.com/3094908
Branch: androidx-main
commit 2c947e6474a89b230eb6f7acae460a9059b006c1
Author: George Mount <mount@google.com>
Date: Tue May 21 09:21:11 2024
Expose packedValue properties of IntIntPair and FloatFloatPair
Fixes: 331853566
Relnote: "Exposed the packedValue internal representation for IntIntPair
and FloatFloatPair."
Test: new tests
Change-Id: Ifeb75cb8ea63d2b5c23d78640fd76bf81ec4f090
M collection/collection/api/current.txt
M collection/collection/api/restricted_current.txt
M collection/collection/src/commonMain/kotlin/androidx/collection/FloatFloatPair.kt
M collection/collection/src/commonMain/kotlin/androidx/collection/IntIntPair.kt
M collection/collection/src/commonTest/kotlin/androidx/collection/PairTest.kt
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.collection:collection:1.5.0-alpha01androidx.collection:collection-iosarm64:1.5.0-alpha01androidx.collection:collection-iossimulatorarm64:1.5.0-alpha01androidx.collection:collection-iosx64:1.5.0-alpha01androidx.collection:collection-jvm:1.5.0-alpha01androidx.collection:collection-linuxarm64:1.5.0-alpha01androidx.collection:collection-linuxx64:1.5.0-alpha01androidx.collection:collection-macosarm64:1.5.0-alpha01androidx.collection:collection-macosx64:1.5.0-alpha01androidx.collection:collection-tvosarm64:1.5.0-alpha01androidx.collection:collection-tvossimulatorarm64:1.5.0-alpha01androidx.collection:collection-tvosx64:1.5.0-alpha01androidx.collection:collection-watchosarm32:1.5.0-alpha01androidx.collection:collection-watchosarm64:1.5.0-alpha01androidx.collection:collection-watchossimulatorarm64:1.5.0-alpha01androidx.collection:collection-watchosx64:1.5.0-alpha01
Description
Version used: 1.4.0
Devices/Android versions reproduced on: any
It would be beneficial to have the ability to utilize primitive pairs within collections. At present, there is no means to store numerous pairs that are internally represented as the Long type (IntIntPair, FloatFloatPair) within a MutableLongMap. Therefore, in instances where we require storing multiple pairs, an ArrayList or a MutableObjectList is currently utilized, which leads to unnecessary boxing/unboxing operations.
It would be beneficial to provide public access to the internal pair's Long value or to generate an IntIntPairList and FloatFloatPairList classes within the library.