SharedTransitionLayout + ConstraintLayout [332898040]

Fixed

Bug

Status Update

No update yet.

Description

ri...@google.com

created issue #1

Apr 4, 2024 04:39PM

Compose version: 1.7.0-SNAPSHOT ConstraintLayout version: 1.0.1 (it seems to not be an issue when using 1.1.0-alpha13)

When wrapping ConstraintLayout in Compose with SharedTransitionLayout, the following crash is observed, will the 1.1.0-alpha13 be released soon?

java.lang.IllegalStateException: Error: Placement happened before lookahead.
                                                                                                    	at androidx.compose.ui.internal.InlineClassHelperKt.throwIllegalStateException(InlineClassHelper.kt:26)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeSelf-MLgxB_4(LayoutNodeLayoutDelegate.kt:2031)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeAt-f8xVGno(LayoutNodeLayoutDelegate.kt:761)
                                                                                                    	at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                    	at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50(Placeable.kt:598)
                                                                                                    	at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50$default(Placeable.kt:258)
                                                                                                    	at androidx.constraintlayout.compose.Measurer.performLayout(ConstraintLayout.kt:1321)
                                                                                                    	at androidx.constraintlayout.compose.ConstraintLayoutKt$rememberConstraintLayoutMeasurePolicy$1$measurePolicy$1$measure$1.invoke(ConstraintLayout.kt:123)
                                                                                                    	at androidx.constraintlayout.compose.ConstraintLayoutKt$rememberConstraintLayoutMeasurePolicy$1$measurePolicy$1$measure$1.invoke(ConstraintLayout.kt:122)
                                                                                                    	at androidx.compose.ui.node.LookaheadCapablePlaceable$layout$1.placeChildren(LookaheadDelegate.kt:212)

Comments

ap...@google.com <ap...@google.com> #2May 10, 2024 01:56AM

Project: platform/frameworks/support
Branch: androidx-main

commit 243d46d8fc8bd72e138d084c37df15db2cbe25ef
Author: Oscar Adame Vázquez <oscarad@google.com>
Date: Mon May 06 10:25:34 2024

[Compose] Cleanup and API feedback for ConstraintLayout

Applying API feedback changes to ConstraintLayout and MotionLayout.

Some minor code cleaup and a couple of tests fixed.

Removed blank lines in documentation (nbsp;) as the renderer in Studio and DAC have changed so that additional blank lines are not necessary.

Relnote: "Simplified `animateChanges` API in ConstraintLayout to only need a non-null AnimationSpec. `onIncomingConstraints` in InvalidationStrategy is now a regular lambda. `fixedWidthRate` renamed to `shouldInvalidateOnFixedWith`, same for the Height variant."

Bug: 291769109
Bug: 298404266
Bug: 332898040
Bug: 336370035
Test: N/A
Change-Id: Ie59cd551b999788c0f11ce77feb62d00dc8b9de6

M constraintlayout/constraintlayout-compose/api/current.txt
M constraintlayout/constraintlayout-compose/api/restricted_current.txt
M constraintlayout/constraintlayout-compose/integration-tests/compose-benchmark/src/androidTest/java/androidx/constraintlayout/compose/benchmark/MotionSceneBenchmark.kt
M constraintlayout/constraintlayout-compose/integration-tests/demos/src/main/java/androidx/constraintlayout/compose/demos/ChainsDemo.kt
M constraintlayout/constraintlayout-compose/src/androidInstrumentedTest/kotlin/androidx/constraintlayout/compose/ConstraintLayoutTest.kt
M constraintlayout/constraintlayout-compose/src/androidInstrumentedTest/kotlin/androidx/constraintlayout/compose/MotionLayoutTest.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/ConstrainScope.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/ConstraintLayout.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/ConstraintLayoutBaseScope.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/ConstraintSet.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/LateMotionLayout.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/MotionDragHandler.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/MotionLayout.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/MotionMeasurer.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/MotionScene.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/MotionSceneScope.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/Transition.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/TransitionHandler.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/TransitionScope.kt

https://android-review.googlesource.com/3076005

os...@google.com <os...@google.com> #3Nov 7, 2024 10:22PM

Marked as fixed.

1.1.0 stable is now officially available.

Marking as resolved, but do let me know if there's issues after updating dependencies.

Issue 332898040

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2May 10, 2024 01:56AM

os...@google.com <os...@google.com> #3Nov 7, 2024 10:22PM

Add comment

Issue metadata