SharedTransitionLayout + ConstraintLayout [332898040]

Fixed

Bug

Status Update

No update yet.

Description

ri...@google.com

created issue #1

Apr 4, 2024 04:39PM

Compose version: 1.7.0-SNAPSHOT ConstraintLayout version: 1.0.1 (it seems to not be an issue when using 1.1.0-alpha13)

When wrapping ConstraintLayout in Compose with SharedTransitionLayout, the following crash is observed, will the 1.1.0-alpha13 be released soon?

java.lang.IllegalStateException: Error: Placement happened before lookahead.
                                                                                                    	at androidx.compose.ui.internal.InlineClassHelperKt.throwIllegalStateException(InlineClassHelper.kt:26)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeSelf-MLgxB_4(LayoutNodeLayoutDelegate.kt:2031)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeAt-f8xVGno(LayoutNodeLayoutDelegate.kt:761)
                                                                                                    	at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                    	at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50(Placeable.kt:598)
                                                                                                    	at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50$default(Placeable.kt:258)
                                                                                                    	at androidx.constraintlayout.compose.Measurer.performLayout(ConstraintLayout.kt:1321)
                                                                                                    	at androidx.constraintlayout.compose.ConstraintLayoutKt$rememberConstraintLayoutMeasurePolicy$1$measurePolicy$1$measure$1.invoke(ConstraintLayout.kt:123)
                                                                                                    	at androidx.constraintlayout.compose.ConstraintLayoutKt$rememberConstraintLayoutMeasurePolicy$1$measurePolicy$1$measure$1.invoke(ConstraintLayout.kt:122)
                                                                                                    	at androidx.compose.ui.node.LookaheadCapablePlaceable$layout$1.placeChildren(LookaheadDelegate.kt:212)

Comments

ap...@google.com <ap...@google.com> #2May 10, 2024 01:56AM

You can provide your own regex to By.text().
For example, By.text(Pattern.compile("All albums.*", Pattern.DOTALL)) should be equivalent to a multi-line startsWith.

os...@google.com <os...@google.com> #3Nov 7, 2024 10:22PM

Marked as fixed.

I'm probably dumb but why would it be the default and wanted behavior if not documented properly?

Every known startWith / contains function in Java/Kotlin are multiline, the javadoc says: A UI element will be considered a match if its text value starts with the substring parameter

Many people will fall into this non standard default behavior and loose tons of time trying to figure out why.

If you still consider this default is the correct one, then please document it.

Issue 332898040

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2May 10, 2024 01:56AM

os...@google.com <os...@google.com> #3Nov 7, 2024 10:22PM

Add comment

Issue metadata