SharedTransitionLayout + ConstraintLayout [332898040]

Fixed

Bug

Status Update

No update yet.

Description

ri...@google.com

created issue #1

Apr 4, 2024 04:39PM

Compose version: 1.7.0-SNAPSHOT ConstraintLayout version: 1.0.1 (it seems to not be an issue when using 1.1.0-alpha13)

When wrapping ConstraintLayout in Compose with SharedTransitionLayout, the following crash is observed, will the 1.1.0-alpha13 be released soon?

java.lang.IllegalStateException: Error: Placement happened before lookahead.
                                                                                                    	at androidx.compose.ui.internal.InlineClassHelperKt.throwIllegalStateException(InlineClassHelper.kt:26)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeSelf-MLgxB_4(LayoutNodeLayoutDelegate.kt:2031)
                                                                                                    	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeAt-f8xVGno(LayoutNodeLayoutDelegate.kt:761)
                                                                                                    	at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                    	at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50(Placeable.kt:598)
                                                                                                    	at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50$default(Placeable.kt:258)
                                                                                                    	at androidx.constraintlayout.compose.Measurer.performLayout(ConstraintLayout.kt:1321)
                                                                                                    	at androidx.constraintlayout.compose.ConstraintLayoutKt$rememberConstraintLayoutMeasurePolicy$1$measurePolicy$1$measure$1.invoke(ConstraintLayout.kt:123)
                                                                                                    	at androidx.constraintlayout.compose.ConstraintLayoutKt$rememberConstraintLayoutMeasurePolicy$1$measurePolicy$1$measure$1.invoke(ConstraintLayout.kt:122)
                                                                                                    	at androidx.compose.ui.node.LookaheadCapablePlaceable$layout$1.placeChildren(LookaheadDelegate.kt:212)

Comments

ap...@google.com <ap...@google.com> #2May 10, 2024 01:56AM

Ignore this msg

os...@google.com <os...@google.com> #3Nov 7, 2024 10:22PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e7b4b06e67951ab47157d06ff314a5c8b2e8fdc6
Author: Andrei Shikov <ashikov@google.com>
Date: Mon Jan 08 15:54:51 2024

Count recursive local declarations as captures

Local declarations were already counted as captures for composable lambdas before, but the traversal ordering missed the recursive captures, converting some of them into singletons.

Test: Compiler test
Fixes: 318745941
Change-Id: I9097d1be71fb67b73e5027f723fd187c4272f6b4

M compose/compiler/compiler-hosted/integration-tests/src/androidUnitTest/kotlin/androidx/compose/compiler/plugins/kotlin/ComposeBytecodeCodegenTest.kt
M compose/compiler/compiler-hosted/integration-tests/src/jvmTest/kotlin/androidx/compose/compiler/plugins/kotlin/AbstractCodegenTest.kt
M compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposerLambdaMemoization.kt

https://android-review.googlesource.com/2900890

Issue 332898040

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2May 10, 2024 01:56AM

os...@google.com <os...@google.com> #3Nov 7, 2024 10:22PM

Add comment

Issue metadata