IssueTracker

Sorry I think I made a mistake in step 4 and 7 (was confusing with https://issuetracker.google.com/issues/332772491 and https://issuetracker.google.com/issues/332982932 I reported recently).

The original <flavor>Release build (assembleProdRelease) does pickup both profiles if they're placed under src/<variant>/generated/baselineProfiles.

The <flavor>BenchmarkRelease task generated by the baseline profile plugin however can't seem to be able to pickup files in src/<variant>/generated/baselineProfiles, but src/<variant>/baselineProfiles works.

So to reproduce it you can run ./gradlew assembleDevBenchmarkRelease with the profiles in src/<variant>/generated/baselineProfiles VS src/<variant>/baselineProfiles, and compare app/build/intermediates folder:

• intermediates/merged_startup_profile/ is produced if the startup profile lives in src/<variant>/baselineProfiles
• no merged_startup_profile folder is produced if the startup profile lives in src/<variant>/generated/baselineProfiles

What this effectively means is without changing baselineProfileOutputDir to point to src/<variant>/baselineProfiles, the app being benchmarked won't include the profiles provided by the app which is how I found this issue (see https://github.com/ReactiveCircus/kstreamlined-mobile/pull/166)

Thank you for spending the time to reexplain this.

I went through it and found the bug.

I'm going to create a patch for the plugin.

The patch should be in baseline profile gradle plugin 1.2.4 and 1.3.0-alpha03

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.2.4
• androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.0-alpha03

I can still reproduce this in 1.3.0-alpha03. I've pushed a new branch. To reproduce:

• run ./gradlew assembleDevBenchmarkRelease
• the android/app/build/intermediates/merged_startup_profile/devBenchmarkRelease/mergeDevBenchmarkReleaseStartupProfile/ folder is still empty
• the android/app/build/intermediates/merged_art_profile/devBenchmarkRelease/mergeDevBenchmarkReleaseArtProfile/baseline-prof.txt only has profiles from libraries
• the build completes even when the baseline-prof.txt and startup-prof.txt in src/main/generated/baselineProfiles have unparsable content foo and bar.

Was looking at the project and I think the issue is here:

    beforeVariants {
        it.enable = it.name in listOf(
            "devDebug",
            "demoDebug",
            "mockDebug",
            "prodRelease",
            "devNonMinifiedRelease",
            "devBenchmarkRelease",
            "prodBenchmarkRelease",
        )
    }

In this beforeVariants block, the variant devRelease is disabled, so the onVariants callback for that variant won't run. The set up work for devBenchmarkRelease is done in that callback.

Unfortunately this code is a bit tricky because it's not possible to access a variant from another variant, using the variant api. So the baseline profile plugin processes the base variant and then schedules some work for when the benchmark variant is processed, in order to add the baseline profile src sets.

The (non-optimal) "fix" here would be to re-enable devRelease.

For reference: code.

Thanks, enabling devRelease does work. For now I've worked around this by enabling benchmark related variants only when running benchmarks by checking gradle.startParameter.