IssueTracker

Hi im wondering if the leak happening in this issue on media3's issue tracker

https://github.com/androidx/media/issues/1059#issuecomment-2031345189

is actually a leak within androix.media's MediaSessionCompat (see possibly related issue here)

By taking UAMP and having the MusicServiceConnection be a Dagger @Singleton, the MusicService is leaked with a very similar stack trace that is exposed here, which contains only stacktraces from androidx.media (until the MusicService, that is):

                                                              ====================================
                                                              HEAP ANALYSIS RESULT
                                                              ====================================
                                                              1 APPLICATION LEAKS
                                                              
                                                              References underlined with "~~~" are likely causes.
                                                              Learn more at https://squ.re/leaks.
                                                              
                                                              43381 bytes retained by leaking objects
                                                              Signature: 80f093d135adc2b278b02ca2f66fbd46aaa36bea
                                                              ┬───
                                                              │ GC Root: Global variable in native code
                                                              │
                                                              ├─ android.support.v4.media.session.MediaSessionCompat$MediaSessionImplApi21$ExtraSession instance
                                                              │    Leaking: UNKNOWN
                                                              │    Retaining 6,7 MB in 1826 objects
                                                              │    ↓ MediaSessionCompat$MediaSessionImplApi21$ExtraSession.this$0
                                                              │                                                            ~~~~~~
                                                              ├─ android.support.v4.media.session.MediaSessionCompat$MediaSessionImplApi29 instance
                                                              │    Leaking: UNKNOWN
                                                              │    Retaining 6,7 MB in 1825 objects
                                                              │    ↓ MediaSessionCompat$MediaSessionImplApi21.mSessionFwk
                                                              │                                               ~~~~~~~~~~~
                                                              ├─ android.media.session.MediaSession instance
                                                              │    Leaking: UNKNOWN
                                                              │    Retaining 1,8 kB in 12 objects
                                                              │    mContext instance of com.example.android.uamp.media.MusicService
                                                              │    ↓ MediaSession.mContext
                                                              │                   ~~~~~~~~
                                                              ╰→ com.example.android.uamp.media.MusicService instance
                                                              ​     Leaking: YES (ObjectWatcher was watching this because com.example.android.uamp.media.MusicService received
                                                              ​     Service#onDestroy() callback and Service not held by ActivityThread)
                                                              ​     Retaining 43,4 kB in 896 objects
                                                              ​     key = 11c50fab-5b0c-4267-8c51-ad235a51d861
                                                              ​     watchDurationMillis = 5391
                                                              ​     retainedDurationMillis = 390
                                                              ​     mApplication instance of com.example.android.uamp.UampApplication
                                                              ​     mBase instance of android.app.ContextImpl
                                                              ====================================

`

I really dont see how using @Singleton is any different from the default implementation on UAMP's media3 branch (which does not leak):

companion object {
    // For Singleton instantiation.
    @Volatile
    private var instance: MusicServiceConnection? = null

    fun getInstance(context: Context, serviceComponent: ComponentName) =
        instance ?: synchronized(this) {
            instance ?: MusicServiceConnection(context, serviceComponent)
                .also { instance = it }
        }
}

The issue can be reproduced on this branch of my fork of UAMP:

https://github.com/kelmer44/uamp/tree/dagger-nocast

Which uses Dagger Hilt and removes Cast for simplification.

To reproduce:

1. Open UAMP
2. Play something
3. Swipe the app away in the task manager
4. Music Service is leaked.
5. From this point restarting UAMP also reveals the issue because nothing is loaded as there will be two MusicService instances.