Convert AndroidX SavedState to Multiplatform [334076622]

Fixed

Task

Status Update

No update yet.

Description

mg...@google.com

created issue #1

Apr 12, 2024 03:33PM

Our goal is to convert androidx.savedstate to Kotlin Multiplatform without porting android.os.Bundle (which should be an internal implementation detail). We plan to leverage the existing rememberSaveable and Saver API as a foundation and extend its availability beyond Compose. To ensure backward compatibility, we'll try to redirect the current rememberSaveable API to our newly extracted implementation.

Further investigation is needed to assess the full viability of these ideas.

Comments

mg...@google.com <mg...@google.com> Apr 12, 2024 03:34PM

Accepted by mg...@google.com.

ca...@gmail.com <ca...@gmail.com> #2Apr 13, 2024 04:28AM

Comment has been deleted.

Message last modified on Apr 17, 2024 04:43PM

ap...@google.com <ap...@google.com> #3May 1, 2024 05:11PM

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

ap...@google.com <ap...@google.com> #4May 1, 2024 05:11PM

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

ap...@google.com <ap...@google.com> #5May 1, 2024 05:11PM

@ #4:

I think that is intended for Animator. If you set the currentPlayTime to 0 or the total duration the animator completes. We do some special checks in fragments to handle it.

ap...@google.com <ap...@google.com> #6May 1, 2024 05:11PM

Did some investigation on the Fragment side and it seems like the merged transition is targeting correctly.

Exiting Transition: Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
>>>>> ExitingViews <<<<<
View: android.widget.LinearLayout{f9add3d}
Entering Transition: Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
>>>>> EnteringViews <<<<<
View: android.widget.LinearLayout{b7f24bc}
Final merged transition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
merged transition passed to controlDelayedTransition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})

Still digging.

ap...@google.com <ap...@google.com> #7May 1, 2024 05:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 567b7459329d1ec8d27a8c6fe1c4a86442065d7d
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 26 20:06:54 2023

Add additional logging for transitions

Adding more debug logging in transitions to track the entering and
exiting transitions as well as the final merged transition and its
targets.

Test: added logging
Bug: 300157785
Change-Id: I0d9ad72b865422493c6c895ddb6115abf85eed16

M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.kt

https://android-review.googlesource.com/2763868

ap...@google.com <ap...@google.com> #8May 1, 2024 05:11PM

So I have isolated this outside of fragment into something much simpler and I think it breaks down when it comes to the adding and removing of Views with animateToStart.

The attached sample is a simple add that goes between two screens BLUE and GREEN. It has code for both the 1.5.0-alpha03 and 1.5.0-alpha04 versions, but I think alpha04 is currently broken in another way so I will upload the alpha03 version here.

This is integrated with predictive back similar to how fragment is, so upon cancelling we call animateToStart, then we do a beginDelayedTransition on a 0 duration Fade() and we reverse the view visibility back to what it was prior to starting the transition.

If you only do visibility, cancel always works the view never goes away, it is wonderful, but when you do adding and removing views like we need to in fragment it fails.

First the code for beginDelayedTransition goes from this:

TransitionManager.beginDelayedTransition(container, Fade().apply {
  duration = 0
})
reverseViews()

to this:

TransitionManager.beginDelayedTransition(container, Fade().apply {
  duration = 0
  addListener(onEnd = {
    reverseViews()
    blueScreen.visibility = View.VISIBLE
    greenScreen.visibility = View.VISIBLE
  })
})
reverseViews(useVisibility = true)

We need to make this change because after the animateToStart() view is still parented by the overlay, so we call reverseViews(useVisibility = true) to only change the visibility and then once the transition finishes we can call reverseViews() to parent the view properly, then we make both views visible again.

From our perspective after the 0 duration transition our views are back in the proper state, but they do not transition properly after a cancel.

If the app is doing this wrong and we can make the appropriate fixes, doing the same in fragment should resolve this. There is logging available that shows the state of the views when we start the transition.

ap...@google.com <ap...@google.com> #9May 3, 2024 10:38AM

The API has changed since that project was created in a way that makes the API more robust. I'm hoping that has fixed this...

ap...@google.com <ap...@google.com> #10May 3, 2024 01:19PM

There appears to be a problem with the order of operations. I'm going to look into fixing that.

ap...@google.com <ap...@google.com> #11May 3, 2024 03:07PM

Project: platform/frameworks/support
Branch: androidx-main

commit e57dd5f9ac6cbb8cf83b221e2d5b3fbd3e88ce6b
Author: George Mount <mount@google.com>
Date: Thu Nov 09 14:33:53 2023

Fix animateToStart with Slide.

Fixes: 300157785

Slide was not repositioning the View to its proper
translation after animating it to the start position.
This fixes that so that it is moved.

Test: new test
Change-Id: I698f4dbcef46304f9aa545847d205f7b70c80d63

M transition/transition/src/androidTest/java/androidx/transition/SlideEdgeTest.java
M transition/transition/src/androidTest/java/androidx/transition/TranslationAnimationCreatorTest.java
M transition/transition/src/main/java/androidx/transition/TranslationAnimationCreator.java

https://android-review.googlesource.com/2824840

ap...@google.com <ap...@google.com> #12May 3, 2024 03:07PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.transition:transition:1.5.0-alpha05

ap...@google.com <ap...@google.com> #13May 3, 2024 03:07PM

Project: platform/frameworks/support
Branch: androidx-main

commit 507de1178e29efb9e4fbfab001feacf6e1fa6711
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri May 03 15:27:19 2024

Rename `androidTest` to `androidInstrumentedTest` in `savedstate`

Test: N/A
Bug: 334076622
Change-Id: I39d9c83299ccabbc9f902d89d2ceaca0d76d28bb

M savedstate/savedstate/src/androidInstrumentedTest/AndroidManifest.xml
M savedstate/savedstate/src/androidInstrumentedTest/kotlin/androidx/savedstate/ErrorInStaticBlock.android.kt
M savedstate/savedstate/src/androidInstrumentedTest/kotlin/androidx/savedstate/SavedStateRegistryTest.android.kt
M savedstate/savedstate/src/androidInstrumentedTest/kotlin/androidx/savedstate/ViewTreeSavedStateRegistryOwnerTest.android.kt

https://android-review.googlesource.com/3071744

ap...@google.com <ap...@google.com> #14Sep 13, 2024 09:35AM

Project: platform/frameworks/support
Branch: androidx-main

commit f802d46e4221eb1a1833c4b0099891a5930d1ea6
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Tue May 07 14:55:20 2024

Introduce `SavedState` to abstract the data structure used to save and restore data in native platforms when using KMP.

* An opaque `SavedState` type that typealiases to a native type based on the platform.
* A `Reader` and `Writer` abstraction to modify the `SavedState` within Kotlin's common source sets. The abstraction utilizes a `value class` and all methods are `inline fun` to guarantee no overhead when using these methods to modify an `Bundle` on Android.

RelNote: "Introduce `SavedState` to abstract the data structure used to save and restore data in native platforms when using KMP. Includes a reader and writer used to mutate the `SavedState`."
Test: N/A
Bug: 334076622
Change-Id: I185754bb2e7e04c32ccc89209a4d4e765334e547

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/build.gradle
A savedstate/savedstate/src/androidInstrumentedTest/kotlin/androidx/savedstate/RobolectricTest.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/Recreator.android.kt
A savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedState.android.kt
A savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateRegistry.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateRegistryController.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateRegistryOwner.android.kt
A savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateWriter.android.kt
A savedstate/savedstate/src/androidUnitTest/kotlin/androidx/savedstate/ParcelableSavedStateTest.android.kt
A savedstate/savedstate/src/androidUnitTest/kotlin/androidx/savedstate/RobolectricTest.android.kt
A savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedState.kt
A savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
A savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateWriter.kt
A savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/internal/SavedStateUtils.kt
A savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/RobolectricTest.kt
A savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
A savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedState.nonAndroid.kt
A savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt
A savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateWriter.nonAndroid.kt
A savedstate/savedstate/src/nonAndroidTest/kotlin/androidx/savedstate/RobolectricTest.nonAndroid.kt

https://android-review.googlesource.com/3176247

ap...@google.com <ap...@google.com> #15Sep 18, 2024 01:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8b2da06337524429901a0c8c3db28d2eb1b529f0
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 13 11:26:35 2024

Add additional KMP targets to SavedState

RelNote: "SavedState, SavedStateWriter and SavedStateReader are now KMP compatible."
RelNote: "SavedState module now supports the following targets: android, desktop, ios, linux and mac."
Test: SavedStateRegistryTest
Bug: 334076622
Change-Id: I26305abd31dcbbf1c686e0bcfa9871b23cdd8545

A savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/build.gradle
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateWriter.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateWriter.nonAndroid.kt

https://android-review.googlesource.com/3266971

ap...@google.com <ap...@google.com> #16Sep 18, 2024 01:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit 904217890feef81667eb1ae57c2fd762ea9e24ee
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 13 18:29:51 2024

Replace `SafeIterableMap` with `synchronized` + `mutableMap`

* `SafeIterableMap` class wasn't converted to KMP. Instead of converting, and to prevent `ConcurrentModificationException` during iteration, we replaced it with a standard `mutableMap` wrapped in a `synchronized` block. This ensures thread safety and allows for safe iteration.

Test: SavedStateRegistryTest
Bug: 334076622
Change-Id: Ie5ea66fa06fa6d2cd5e7abccc569db9a14908654

M savedstate/savedstate/build.gradle
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateRegistry.android.kt
A savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/internal/SynchronizedObject.kt
A savedstate/savedstate/src/darwinMain/kotlin/androidx/savedstate/internal/SynchronizedObject.darwin.kt
A savedstate/savedstate/src/jvmMain/kotlin/androidx/savedstate/internal/SynchronizedObject.jvm.kt
A savedstate/savedstate/src/linuxMain/kotlin/androidx/savedstate/internal/SynchronizedObject.linux.kt
A savedstate/savedstate/src/nativeMain/kotlin/androidx/savedstate/internal/SynchronizedObject.native.kt

https://android-review.googlesource.com/3267277

ap...@google.com <ap...@google.com> #17Sep 18, 2024 01:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit 33d5114f54ef6377d5d47176581551453825134e
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 13 22:33:32 2024

Use unique Lifecycle dependency version in SavedState

* The project included, by mistake, two different lifecycle artifacts: one in the commonMain source set and the other in the androidMain source set.

Test: SavedStateRegistryTest
Bug: 334076622
Change-Id: I33cb7caeda5a5b3b0ffd4bd96985ea6e60d46f93

M savedstate/savedstate/build.gradle

https://android-review.googlesource.com/3267333

ap...@google.com <ap...@google.com> #18Sep 18, 2024 01:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit c5c7f78edc095ca6f789b455c6cb6eb61fd89905
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Mon Sep 16 16:32:56 2024

Disable experimental Android Lint K2 UAST

* The `useK2Uast` flag in Android Lint is causing `IllegalArgumentExceptionWithAttachments` errors when analyzing `SavedState` classes that have been converted to KMP.
* Instead of suppressing these warnings, the Android Lint team has recommended disabling the experimental K2 UAST integration entirely. This change disables the `useK2Uast` flag and adds a comment referencing the related bug (

b/345531033

) for future consideration.

Test: N/A
Bug: 334076622
Change-Id: Iba2ab0f64f7a5418e78f017a949de47d244cb161

M savedstate/savedstate/build.gradle

https://android-review.googlesource.com/3266975

ap...@google.com <ap...@google.com> #19Sep 18, 2024 01:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1cc768070d5a75812e335581109a42ad9a7b9427
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 13 20:29:18 2024

Extract common logic to `SavedStataRegistryImpl`

* By extracting a shared `SavedStateRegistryImpl`, that enable us to migrate `SavedStateRegistry` and `Controller` to `commonMain` with different `expect` and `actual` per platform, reducing duplication and the CL diff.

Test: SavedStateRegistryTest
Bug: 334076622
Change-Id: Id064dec964ee278438909f6099a16b158d9b769f

M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateRegistry.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateRegistryController.android.kt
A savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/internal/SavedStateRegistryImpl.kt

https://android-review.googlesource.com/3267278

ap...@google.com <ap...@google.com> #20Sep 18, 2024 01:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit 79a1767e2fe38493991d583c84b02c4524fc8e31
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 13 20:34:36 2024

Move `SavedStateRegistry` and `Controller` to `commonMain`

RelNote: "SavedStateRegistry and SavedStateRegistryController are now KMP compatible."
Test: SavedStateRegistryTest
Bug: 334076622
Change-Id: Id7bb8064cc8bf19faade95636dd1436943056ce6

M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateRegistry.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateRegistryController.android.kt
A savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateRegistry.kt
A savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateRegistryController.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateRegistryOwner.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/internal/SavedStateRegistryImpl.kt
A savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateRegistry.nonAndroid.kt
A savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateRegistryController.nonAndroid.kt

https://android-review.googlesource.com/3267279

ap...@google.com <ap...@google.com> #21Sep 19, 2024 10:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3a82f00a1255b352441328eb85c936e33ea56843
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Sep 19 11:59:40 2024

Add `android` suffix to all files from `androidMain` in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: Ia5911896f02a81c45c6e79b9a33da44bc937e417

M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/AbstractSavedStateViewModelFactory.android.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/LegacySavedStateHandleController.android.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandle.android.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandleController.android.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.android.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateViewModelFactory.android.kt

https://android-review.googlesource.com/3272055

ap...@google.com <ap...@google.com> #22Sep 19, 2024 10:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7a5ebf9d0c904e240e92e0df38dcc774798c1541
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Sep 19 11:20:32 2024

Dump native ABI in `viewmodel-savedstate`

RelNote: "ViewModel SavedState is now configured to be KMP compatible."
Test: N/A
Bug: 334076622
Change-Id: I48764a7a611bc102a08a6caf941d609e7576a350

A lifecycle/lifecycle-viewmodel-savedstate/bcv/native/current.txt

https://android-review.googlesource.com/3272054

ap...@google.com <ap...@google.com> #23Sep 19, 2024 10:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit 08b27e88a631e57e640a73dbdf0a2587d7b50c43
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Sep 19 12:43:54 2024

Disable experimental Android Lint K2 UAST in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: I07875a07c1d3d645824a2156641bbb610cc7b8eb

M lifecycle/lifecycle-viewmodel-savedstate/build.gradle

https://android-review.googlesource.com/3274332

ap...@google.com <ap...@google.com> #24Sep 19, 2024 10:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit fa2c57837b54211c436a252e2a19842efebfe146
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Sep 19 11:57:47 2024

Rename `main` to `androidMain` in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: I4e3227aaf1be3b78e7b5b6d7cd97df82b216e605

M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/AndroidManifest.xml
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/AbstractSavedStateViewModelFactory.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/LegacySavedStateHandleController.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandle.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandleController.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateViewModelFactory.kt

https://android-review.googlesource.com/3272161

ap...@google.com <ap...@google.com> #25Sep 19, 2024 10:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit f97adace59c8d317769ef5e7d4a194c01076d9e8
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Sep 19 11:54:36 2024

Rename `androidTest` to `androidInstrumentedTest` in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: I7f8a411058d0e2d89e87a8ded59d67a9c83d0184

M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/AndroidManifest.xml
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/SavedStateHandleParcelingTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/SavedStateHandleProviderTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/SavedStateFactoryTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/SavedStateHandleSupportTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/SavedStateHandleTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/TestComponent.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/ViewModelsWithStateTest.kt

https://android-review.googlesource.com/3272160

ap...@google.com <ap...@google.com> #26Sep 19, 2024 10:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0d0a80faba7b22908f1e76f5eeeb4b9cca19061c
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Sep 19 12:42:24 2024

Use `kmpDocs` in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: If4af4f7c1eb9f38048e77f5d5d16770439ca823e

M docs-tip-of-tree/build.gradle

https://android-review.googlesource.com/3274331

ap...@google.com <ap...@google.com> #27Sep 19, 2024 10:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5ead08cbe81ea0f294d32a8f376a10f48cb9621c
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Sep 19 10:48:58 2024

Set-up `BuildType.KMP` in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: Ibf62bfaf1a1fc1516e8b43afd668383b508184a7

M settings.gradle

https://android-review.googlesource.com/3272158

ap...@google.com <ap...@google.com> #28Sep 19, 2024 10:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit ba34f18aea459660d5693696167c31b6ddbbfdc1
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Sep 19 10:47:47 2024

Set-up KMP configurations in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: I948d7db5234af0f0c76bd4abc30c82b34f29328b

M lifecycle/lifecycle-viewmodel-savedstate/build.gradle

https://android-review.googlesource.com/3272159

ap...@google.com <ap...@google.com> #29Sep 23, 2024 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 261ed3f7932a933693fade67651e3ef1b52d41b4
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 20 08:51:52 2024

Rename `main` to `androidMain` in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: I6584efb8fe73e52108c75cf4cddf0e0319baac09

M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/AndroidManifest.xml
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/AbstractSavedStateViewModelFactory.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/LegacySavedStateHandleController.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandle.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandleController.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateViewModelFactory.kt

https://android-review.googlesource.com/3274419

ap...@google.com <ap...@google.com> #30Sep 23, 2024 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 795e7b8af8818d85f3fd63a9ce4f979f26451b11
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 20 08:51:52 2024

Add `android` suffix to all files from `androidMain` in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: Ic90439c1a5d99a949d4bf4944d3fe558dae32abf

M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/AbstractSavedStateViewModelFactory.android.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/LegacySavedStateHandleController.android.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandle.android.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandleController.android.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.android.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateViewModelFactory.android.kt

https://android-review.googlesource.com/3274420

ap...@google.com <ap...@google.com> #31Sep 23, 2024 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 167b22b90fa6eeeb3758f0677555e2ac5884b4d4
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 20 15:21:03 2024

Move SavedStateHandleSupport internal keys to `commonMain` in `viewmodel-savedstate`

* Due to KT-52344, an empty `commonMain` source set with our current KMP configuration causes a build breakage. Moving the internal keys (`VIEWMODEL_KEY` and `SAVED_STATE_KEY`) are easy to do proactively and ensures the build does not fail.
* Please note we will convert the rest of the module in multiple follow-up CLs.
* Reference:

https://youtrack.jetbrains.com/issue/KT-52344

Test: N/A
Bug: 334076622
Change-Id: I34825bafb1195af7d333d95f46ad6290feebcec2

M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.android.kt
A lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.kt

https://android-review.googlesource.com/3271759

ap...@google.com <ap...@google.com> #32Sep 23, 2024 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit ffdc23a5b5a562ebc37cdd283caca0637a034ddd
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 20 08:51:52 2024

Disable experimental Android Lint K2 UAST in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: I7f1e66e50d54807d9c637a95a797684066993957

M lifecycle/lifecycle-viewmodel-savedstate/build.gradle

https://android-review.googlesource.com/3274416

ap...@google.com <ap...@google.com> #33Sep 23, 2024 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit a9b5cba2f3005bd311cfaace946ad3d64c55b094
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 20 08:51:52 2024

Use `kmpDocs` in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: Icd9cfeee9a7b603b187e6c597271339d2a444c07

M docs-tip-of-tree/build.gradle

https://android-review.googlesource.com/3274415

ap...@google.com <ap...@google.com> #34Sep 23, 2024 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit c9f50467a2eea8726582b428769eb26d376bd3a4
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 20 08:51:52 2024

Rename `androidTest` to `androidInstrumentedTest` in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: Ie0b617397b023f9cf8c067271f6827741e8ca6d4

M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/AndroidManifest.xml
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/SavedStateHandleParcelingTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/SavedStateHandleProviderTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/SavedStateFactoryTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/SavedStateHandleSupportTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/SavedStateHandleTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/TestComponent.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/ViewModelsWithStateTest.kt

https://android-review.googlesource.com/3274418

ap...@google.com <ap...@google.com> #35Sep 23, 2024 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 736ec1d65d3ff6898719a33432b83f845bef2e64
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 20 08:51:52 2024

Set-up KMP configurations in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: I57c860fe40aa9ff6ff6e321ee9881e57faea7840

M lifecycle/lifecycle-viewmodel-savedstate/build.gradle

https://android-review.googlesource.com/3274413

ap...@google.com <ap...@google.com> #36Sep 23, 2024 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0caa028d83f488d0c7b845565f5366ee662aa522
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 20 08:51:52 2024

Dump native ABI in `viewmodel-savedstate`

RelNote: "ViewModel SavedState is now configured to be KMP compatible."
Test: N/A
Bug: 334076622
Change-Id: I503edb3551108b6c4877c17767a787dda4aaaf4c

A lifecycle/lifecycle-viewmodel-savedstate/bcv/native/current.txt

https://android-review.googlesource.com/3274417

ap...@google.com <ap...@google.com> #37Sep 23, 2024 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit b82c31c48b26e66c66b60925e2a26813a6b161db
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Sep 20 08:51:52 2024

Set-up `BuildType.KMP` in `viewmodel-savedstate`

Test: N/A
Bug: 334076622
Change-Id: Ibe243694a50542c7977018cf4183c8ecde6075f4

M settings.gradle

https://android-review.googlesource.com/3274414

ap...@google.com <ap...@google.com> #38Oct 4, 2024 09:39PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3294255

Disable Metalava K2's UAST in savedstate

Expand for full commit details

Disable Metalava K2's UAST in `savedstate`

* Currently, resolving JVM annotations from the common source set in K2 is not functioning correctly. This is due to the absence of a common source JAR containing the necessary annotations. Disabling UAST allows Metalava to continue operating while we address the underlying issue with annotation resolution in Metalava.

Test: N/A
Bug: 334076622
Change-Id: I61396dcb8b28fb545ea625c7d4408969e7259039

Files:

M lifecycle/lifecycle-viewmodel-savedstate/build.gradle

Hash: e01363eb9b9866ece101e46e1d9bb122e5d25ebe
Date: Fri Oct 04 22:13:59 2024

mg...@google.com <mg...@google.com> #39Oct 17, 2024 04:32PM

We have created b/374102924 to add KotlinX Serialization support for Saved State KMP.

ap...@google.com <ap...@google.com> #40Oct 18, 2024 09:58AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3313277

Add Long support to Saved State KMP

Expand for full commit details

Add `Long` support to Saved State KMP

RelNote: "SavedState KMP now supports Long."
Test: SavedStateTest
Bug: 334076622
Change-Id: I4c180e12c8259436628e5b6b62a0dfa38f003be6

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateWriter.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateWriter.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/internal/SavedStateUtils.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateWriter.nonAndroid.kt

Hash: cce3e22b1e9d5b3932236e96bc882b2fb056a10e
Date: Thu Oct 17 14:49:13 2024

ap...@google.com <ap...@google.com> #41Oct 23, 2024 10:24AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3315651

Fix SavedStateReader.get*OrElse not returning defaultValue for primitives

Expand for full commit details

Fix `SavedStateReader.get*OrElse` not returning `defaultValue` for primitives 
 
Test: SavedStateTest 
Bug: 334076622 
Change-Id: Ic1d74cda55075f87718a0e4315fd6f64465276ca

Files:

M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/androidUnitTest/kotlin/androidx/savedstate/ParcelableSavedStateTest.android.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt

Hash: 792010e1704764e91abb256be96d340587d38bd6
Date: Mon Oct 21 19:47:27 2024

ap...@google.com <ap...@google.com> #42Oct 23, 2024 10:24AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3311742

Add contentDeepEquals to Saved State

Expand for full commit details

Add `contentDeepEquals` to Saved State 
 
RelNote: "SavedState KMP now supports `contentDeepEquals` comparison." 
Test: SavedStateTest 
Bug: 334076622 
Change-Id: Ia515c97b16e17bcb8a20dafbc043cf2d971c4405

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt

Hash: a080e2c245d7b896f5f0a45f12b87b9f07858a75
Date: Thu Oct 17 15:53:34 2024

ap...@google.com <ap...@google.com> #43Oct 23, 2024 05:07PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3314754

Add additional savedState factory functions

Expand for full commit details

Add additional `savedState` factory functions 
 
RelNote: "Add additional `savedState` factory parameters supporting an initial `Map<String, Any>`" 
Test: SavedStateTest 
Bug: 334076622 
Change-Id: I9b37da20978bc549e1ab5c354985aa4ca450f6be

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedState.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedState.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedState.nonAndroid.kt

Hash: d5bd36accebb332017f303381c21502b14766d67
Date: Tue Oct 22 19:15:28 2024

ap...@google.com <ap...@google.com> #44Oct 23, 2024 08:27PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3316780

Add support for marking a key as a null reference in SavedState

Expand for full commit details

Add support for marking a key as a `null` reference in `SavedState` 
 
* When encoding/decoding data that contains properties that are both nullable and has default values, we need a way to identify both. 
 
RelNote: "Add `putNull` and `isNull` to SavedState KMP." 
Test: SavedStateTest 
Bug: 334076622 
Change-Id: Iea71d9d8652c9cbd45e701d5b4785579acd73969

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedState.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateWriter.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedState.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateWriter.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedState.nonAndroid.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateWriter.nonAndroid.kt

Hash: 906259e5143e561e6babe52542348d8e929bf72e
Date: Wed Oct 23 16:01:37 2024

ap...@google.com <ap...@google.com> #45Oct 23, 2024 08:57PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3310926

Add Char support to Saved State KMP

Expand for full commit details

Add `Char` support to Saved State KMP 
 
RelNote: "SavedState KMP now supports Char." 
Test: SavedStateTest 
Bug: 334076622 
Change-Id: I9ac2ff6589371bd4bc79b1910334ce24710cd176

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateWriter.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateWriter.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/internal/SavedStateUtils.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateWriter.nonAndroid.kt

Hash: 13fd10604738a3af38ba1ac99d11343a071a8e75
Date: Fri Oct 18 17:41:54 2024

ap...@google.com <ap...@google.com> #46Oct 24, 2024 02:32PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3317337

Remove unused Writer.read/Reader.write methods from SavedState to avoid confusion

Expand for full commit details

Remove unused `Writer.read`/`Reader.write` methods from SavedState to avoid confusion 
 
RelNote: "Remove unused methods." 
Test: SavedStateTest 
Bug: 334076622 
Change-Id: Ib63477d99028dd517b070af089409b7a3e433ac6

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedState.kt

Hash: bd92701e50e46ef3486ce5b4e27c0426958c3ca7
Date: Wed Oct 23 21:40:46 2024

ap...@google.com <ap...@google.com> #47Oct 24, 2024 02:32PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3317338

Remove unused reader()/writer() methods from SavedState to avoid confusion

Expand for full commit details

Remove unused `reader()`/`writer()` methods from SavedState to avoid confusion 
 
* Keeping a reference to a writer or reader, can force Kotlin to box the `SavedState`. 
* Include a warning making sure holding the reference is not recommended/supported. 
 
RelNote: "Remove unused methods." 
Test: SavedStateTest 
Bug: 334076622 
Change-Id: I1b49071b8db2500379e753713dbfc02f48f06d53

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedState.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateWriter.kt

Hash: c31394126331102a173864757bca3be9360fd6d0
Date: Wed Oct 23 21:34:13 2024

ap...@google.com <ap...@google.com> #48Oct 25, 2024 10:31AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3314836

Add Array support to Saved State KMP

Expand for full commit details

Add `Array` support to Saved State KMP 
 
RelNote: "SavedState KMP now supports Arrays." 
Test: SavedStateTest 
Bug: 334076622 
Change-Id: Ic0552cac5744d8422524d8219438a6571f70c476

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateWriter.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateWriter.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateWriter.nonAndroid.kt

Hash: 1c48caff1cf283d29de06a80c0924975e4d2851b
Date: Thu Oct 24 16:22:38 2024

ap...@google.com <ap...@google.com> #49Oct 25, 2024 11:18AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3316968

Add toMap to SavedState

Expand for full commit details

Add `toMap` to `SavedState` 
 
* Allows a `SavedState` to be converted into a map. 
* Deep copy: any nested `SavedState` will be converted into a map too. 
 
RelNote: "Add `toMap` to SavedState." 
Test: N/A 
Bug: 334076622 
Change-Id: I487b901051ad68a3e27f9a5550fd7336734abbb1

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt

Hash: cd3236939c7139539e19f7b7c043b93c8f7446e4
Date: Thu Oct 24 16:12:28 2024

ap...@google.com <ap...@google.com> #50Oct 28, 2024 08:27AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3304623

Commonize SavedStateHandle

Expand for full commit details

Commonize `SavedStateHandle` 
 
Test: SavedStateHandleTest 
Bug: 334076622 
Change-Id: I80f3a7bb79ae4e4eb239076c3ff2da219ab43e38

Files:

M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandle.android.kt
A lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/SavedStateHandle.kt
A lifecycle/lifecycle-viewmodel-savedstate/src/nonAndroidMain/kotlin/androidx/lifecycle/SavedStateHandle.nonAndroid.kt

Hash: 89b9ba6bc6aaa6958bd5d5ee4fa42e475b0168e2
Date: Thu Oct 10 16:50:45 2024

ap...@google.com <ap...@google.com> #51Oct 28, 2024 08:27AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3304801

Commonize SavedStateHandleController

Expand for full commit details

Commonize `SavedStateHandleController` 
 
Test: N/A 
Bug: 334076622 
Change-Id: Ic0c6c091cd72ec0faf8fc56a6f19caf77911f088

Files:

M lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/SavedStateHandleController.kt

Hash: eb03b9169ce0c387cb8e63f8239247da1b7237c4
Date: Thu Oct 10 18:43:02 2024

ap...@google.com <ap...@google.com> #52Oct 28, 2024 08:27AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3320139

Remove recursive behaviour from toMap in SavedState

Expand for full commit details

Remove recursive behaviour from `toMap` in `SavedState` 
 
RelNote: "N/A" 
Test: N/A 
Bug: 334076622 
Change-Id: Ic5b39c79119de5337dd478fdf1a30975d5520287

Files:

M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt

Hash: 549d78495308320863ed7332b668b0edf1c3e9c1
Date: Fri Oct 25 15:41:13 2024

ap...@google.com <ap...@google.com> #53Oct 28, 2024 08:27AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3304802

Commonize SavedStateViewModelFactory

Expand for full commit details

Commonize `SavedStateViewModelFactory` 
 
Test: N/A 
Bug: 334076622 
Change-Id: I9d2f206705523cb5c73a09f11a2522e9bae36150

Files:

M lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateViewModelFactory.android.kt
A lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/SavedStateViewModelFactory.kt
A lifecycle/lifecycle-viewmodel-savedstate/src/nonAndroidMain/kotlin/androidx/lifecycle/SavedStateViewModelFactory.nonAndroid.kt

Hash: 73c35c37407f120469a46a16d068f55fd8f6966e
Date: Thu Oct 10 18:43:56 2024

ap...@google.com <ap...@google.com> #54Oct 28, 2024 08:27AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3304800

Commonize SavedStateHandleSupport

Expand for full commit details

Commonize `SavedStateHandleSupport` 
 
Test: SavedStateHandleSupportTest 
Bug: 334076622 
Change-Id: I8b85f3fde27969950304823c376d09bf0de43843

Files:

D lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.android.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.kt

Hash: aa7c9debe2caacd582e3db8004fdda5e37b0fdcd
Date: Wed Oct 16 17:42:16 2024

ap...@google.com <ap...@google.com> #55Oct 28, 2024 08:27AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3307916

Add SavedStateHandleImpl

Expand for full commit details

Add `SavedStateHandleImpl` 
 
* The new class will hold the data and logic from `SavedStateHandle`, and will be used by all platforms to share code. 
 
Test: N/A 
Bug: 334076622 
Change-Id: I9c384017a701a3ffe9491f2619dd3d13b41398f6

Files:

A lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/internal/SavedStateHandleImpl.android.kt
A lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/internal/SavedStateHandleImpl.kt
A lifecycle/lifecycle-viewmodel-savedstate/src/nonAndroidMain/kotlin/androidx/lifecycle/internal/SavedStateHandleImpl.nonAndroid.kt

Hash: adee1372b3a047fec3677de18952352af612c409
Date: Mon Oct 14 15:50:44 2024

ap...@google.com <ap...@google.com> #56Oct 28, 2024 08:27AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3304803

Bump ViewModel SavedState ABI

Expand for full commit details

Bump ViewModel SavedState ABI 
 
RelNote: "Lifecycle ViewModel SavedState is now KMP compatible" 
Test: N/A 
Bug: 334076622 
Change-Id: Ib63947f53600724de5ebf6c0e64c17c305592b2f

Files:

M lifecycle/lifecycle-viewmodel-savedstate/bcv/native/current.txt

Hash: ad0f2909d0413719c1dcd53403aa7d52e36fc3d8
Date: Thu Oct 10 18:46:15 2024

mg...@google.com <mg...@google.com> Oct 28, 2024 01:59PM

Marked as fixed.

ap...@google.com <ap...@google.com> #57Oct 29, 2024 10:43PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3323374

Clean up SavedState KMP Implementation

Expand for full commit details

Clean up SavedState KMP Implementation 
 
* Annotate constructors from `SavedStateWriter` and `SavedStateReader` in `common`, `android` and `nonAndroid` with `@PublishedApi`. Kotlin 1.9 introduces a warning if the expect and actual methods aren't annotated with `@PublishedApi` 
* All methods and constants in the `SavedState` are `@Published internal`, which are tracked by our tooling as a public API. By reducing the number of `@Published`, there is less APIs to maintain. 
* As everything is flag as `inline`, I have moved the suppression to `file:Suppress`. 
* For Android and JVM, included a `file:JvmName`, as class  were inconsistent due to `.android` and `.nonAndroid` suffix. 
* The original `getSingleResultOrThrow` function was created to share behavior between platforms. However, due to how default values work for primitives in `Bundle`, the original abstraction wasn't that useful for sharing code and created multiple levels of calls that was difficult to debug. 
* The original `getSingleResultOrElse` function was designed to handle generic lists. Since we've decided not to support generic lists and instead use typed lists (e.g., `List<Int>` instead of `List<T>`), this function became redundant with `getSingleResultOrThrow`. 
* The `SavedStateUtils` class was only used in the `SavedStateReader`. Its contents have been moved directly into the reader, and the class deleted. 
* The `keyNotFoundError` function now throws an `IllegalArgumentException` as it's caused by an invalid key provided by the caller. 
* The `valueNotFoundError` function throws an `IllegalStateException` as it indicates an inconsistency between the key and the internal state. 
* The error messages for `keyNotFoundError` and `valueNotFoundError` have been improved for clarity. 
 
RelNote: "N/A" 
Test: SavedStateTest 
Bug: 334076622 
Change-Id: I55971ae2560300408153eea5eef7ec96fb70c7ce

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedState.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateWriter.android.kt
M savedstate/savedstate/src/androidUnitTest/kotlin/androidx/savedstate/ParcelableSavedStateTest.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedState.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateWriter.kt
D savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/internal/SavedStateUtils.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedState.nonAndroid.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateWriter.nonAndroid.kt

Hash: 422d9d54c4c3cd79b2f380ae4b90412d53c6b2d2
Date: Mon Oct 28 16:30:02 2024

pr...@google.com <pr...@google.com> #58Oct 30, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.savedstate:savedstate:1.3.0-alpha04
androidx.savedstate:savedstate-android:1.3.0-alpha04
androidx.savedstate:savedstate-desktop:1.3.0-alpha04
androidx.savedstate:savedstate-iosarm64:1.3.0-alpha04
androidx.savedstate:savedstate-iossimulatorarm64:1.3.0-alpha04
androidx.savedstate:savedstate-iosx64:1.3.0-alpha04
androidx.savedstate:savedstate-linuxarm64:1.3.0-alpha04
androidx.savedstate:savedstate-linuxx64:1.3.0-alpha04
androidx.savedstate:savedstate-macosarm64:1.3.0-alpha04
androidx.savedstate:savedstate-macosx64:1.3.0-alpha04

ap...@google.com <ap...@google.com> #59Nov 8, 2024 10:19PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3342931

Add contentDeepHashCode to Saved State

Expand for full commit details

Add `contentDeepHashCode` to Saved State 
 
RelNote: "SavedState KMP now supports `contentDeepHashCode`." 
Test: SavedStateTest 
Bug: 334076622 
Change-Id: I4d9f7de7d26b78c592660e2ab137c593667b7675

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt

Hash: a253a5a1f79b8d2b382cbc7deaa2bc35caa1156b
Date: Fri Nov 08 16:38:22 2024

na...@google.com <na...@google.com> #60Nov 13, 2024 06:19PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.0-alpha07
androidx.lifecycle:lifecycle-viewmodel-savedstate-android:2.9.0-alpha07
androidx.lifecycle:lifecycle-viewmodel-savedstate-desktop:2.9.0-alpha07
androidx.lifecycle:lifecycle-viewmodel-savedstate-iosarm64:2.9.0-alpha07
androidx.lifecycle:lifecycle-viewmodel-savedstate-iossimulatorarm64:2.9.0-alpha07
androidx.lifecycle:lifecycle-viewmodel-savedstate-iosx64:2.9.0-alpha07
androidx.lifecycle:lifecycle-viewmodel-savedstate-linuxarm64:2.9.0-alpha07
androidx.lifecycle:lifecycle-viewmodel-savedstate-linuxx64:2.9.0-alpha07
androidx.lifecycle:lifecycle-viewmodel-savedstate-macosarm64:2.9.0-alpha07
androidx.lifecycle:lifecycle-viewmodel-savedstate-macosx64:2.9.0-alpha07
androidx.savedstate:savedstate:1.3.0-alpha05
androidx.savedstate:savedstate-android:1.3.0-alpha05
androidx.savedstate:savedstate-desktop:1.3.0-alpha05
androidx.savedstate:savedstate-iosarm64:1.3.0-alpha05
androidx.savedstate:savedstate-iossimulatorarm64:1.3.0-alpha05
androidx.savedstate:savedstate-iosx64:1.3.0-alpha05
androidx.savedstate:savedstate-linuxarm64:1.3.0-alpha05
androidx.savedstate:savedstate-linuxx64:1.3.0-alpha05
androidx.savedstate:savedstate-macosarm64:1.3.0-alpha05
androidx.savedstate:savedstate-macosx64:1.3.0-alpha05

ap...@google.com <ap...@google.com> #61Nov 15, 2024 11:38AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3342501

Add Android specific types to SavedState reader and writer

Expand for full commit details

Add Android specific types to `SavedState` reader and writer 
 
* Include support to Android specific types: Binder, Size, SizeF, 
 ParcelableArray and SparseParcelableArray. 
* Include support to JVM specific type: Serializable. 
* Include support to common type: CharSequence. 
* Note that Serializable is currently only available on Android. 
 
RelNote: "SavedState KMP now supports: IBinder, Size, SizeF, 
 Array<Parcelable>, SparseArray<Parcelable> and Serializable (Android)." 
Test: SavedStateAndroidTest.android.kt 
Bug: 334076622 
Change-Id: I1ba9446ed4dad6e018cbf17feaef1f5fcdeb6c3f

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateWriter.android.kt
D savedstate/savedstate/src/androidUnitTest/kotlin/androidx/savedstate/ParcelableSavedStateTest.android.kt
A savedstate/savedstate/src/androidUnitTest/kotlin/androidx/savedstate/SavedStateAndroidTest.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateWriter.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateWriter.nonAndroid.kt

Hash: 9ee8e41f9514ff07ee88a6e56cb14dcea5e3087d
Date: Mon Nov 11 11:46:22 2024

ap...@google.com <ap...@google.com> #62Nov 19, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3349813

Fix KDocs throws in SavedStateReader

Expand for full commit details

Fix KDocs `throws` in `SavedStateReader` 
 
RelNote: "N/A" 
Test: SavedStateTest.android.kt 
Bug: 334076622 
Change-Id: I359ae160033f1cd50412ac9974fc0e8fa2816059

Files:

M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt

Hash: 5d429c768e391200c9b698e7fd59e68e61b274d2
Date: Fri Nov 15 15:13:12 2024

ap...@google.com <ap...@google.com> #63Nov 19, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3349812

Rename values to value in SavedStateWriter

Expand for full commit details

Rename `values` to `value` in `SavedStateWriter` 
 
* Rename `values` argument to `value` in `SavedStateWriter` to match naming used by `Bundle`. 
* Rename `values` to `from` in `putAll` to match naming convention from `Map` interface. 
 
RelNote: "N/A" 
Test: SavedStateTest.android.kt 
Bug: 334076622 
Change-Id: Icc4665ded332b2a9e128f2d55d0c032e1aa1898b

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateWriter.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateWriter.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateTest.kt
M savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateWriter.nonAndroid.kt

Hash: 83e439f7919c35bcb000d6468afe53c187ab4dc5
Date: Fri Nov 15 14:45:38 2024

pr...@google.com <pr...@google.com> #64Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.savedstate:savedstate:1.3.0-alpha06
androidx.savedstate:savedstate-android:1.3.0-alpha06
androidx.savedstate:savedstate-desktop:1.3.0-alpha06
androidx.savedstate:savedstate-iosarm64:1.3.0-alpha06
androidx.savedstate:savedstate-iossimulatorarm64:1.3.0-alpha06
androidx.savedstate:savedstate-iosx64:1.3.0-alpha06
androidx.savedstate:savedstate-linuxarm64:1.3.0-alpha06
androidx.savedstate:savedstate-linuxx64:1.3.0-alpha06
androidx.savedstate:savedstate-macosarm64:1.3.0-alpha06
androidx.savedstate:savedstate-macosx64:1.3.0-alpha06

Issue 334076622

Description

Issue summary

Comments

mg...@google.com <mg...@google.com> Apr 12, 2024 03:34PM

ca...@gmail.com <ca...@gmail.com> #2Apr 13, 2024 04:28AM

ap...@google.com <ap...@google.com> #3May 1, 2024 05:11PM

ap...@google.com <ap...@google.com> #4May 1, 2024 05:11PM

ap...@google.com <ap...@google.com> #5May 1, 2024 05:11PM

ap...@google.com <ap...@google.com> #6May 1, 2024 05:11PM

ap...@google.com <ap...@google.com> #7May 1, 2024 05:11PM

ap...@google.com <ap...@google.com> #8May 1, 2024 05:11PM

ap...@google.com <ap...@google.com> #9May 3, 2024 10:38AM

ap...@google.com <ap...@google.com> #10May 3, 2024 01:19PM

ap...@google.com <ap...@google.com> #11May 3, 2024 03:07PM

ap...@google.com <ap...@google.com> #12May 3, 2024 03:07PM

ap...@google.com <ap...@google.com> #13May 3, 2024 03:07PM

ap...@google.com <ap...@google.com> #14Sep 13, 2024 09:35AM

ap...@google.com <ap...@google.com> #15Sep 18, 2024 01:42PM

ap...@google.com <ap...@google.com> #16Sep 18, 2024 01:42PM

ap...@google.com <ap...@google.com> #17Sep 18, 2024 01:42PM

ap...@google.com <ap...@google.com> #18Sep 18, 2024 01:42PM

ap...@google.com <ap...@google.com> #19Sep 18, 2024 01:42PM

ap...@google.com <ap...@google.com> #20Sep 18, 2024 01:42PM

ap...@google.com <ap...@google.com> #21Sep 19, 2024 10:39PM

ap...@google.com <ap...@google.com> #22Sep 19, 2024 10:39PM

ap...@google.com <ap...@google.com> #23Sep 19, 2024 10:39PM

ap...@google.com <ap...@google.com> #24Sep 19, 2024 10:39PM

ap...@google.com <ap...@google.com> #25Sep 19, 2024 10:39PM

ap...@google.com <ap...@google.com> #26Sep 19, 2024 10:39PM

ap...@google.com <ap...@google.com> #27Sep 19, 2024 10:39PM

ap...@google.com <ap...@google.com> #28Sep 19, 2024 10:39PM

ap...@google.com <ap...@google.com> #29Sep 23, 2024 05:16PM

ap...@google.com <ap...@google.com> #30Sep 23, 2024 05:16PM

ap...@google.com <ap...@google.com> #31Sep 23, 2024 05:16PM

ap...@google.com <ap...@google.com> #32Sep 23, 2024 05:16PM

ap...@google.com <ap...@google.com> #33Sep 23, 2024 05:16PM

ap...@google.com <ap...@google.com> #34Sep 23, 2024 05:16PM

ap...@google.com <ap...@google.com> #35Sep 23, 2024 05:16PM

ap...@google.com <ap...@google.com> #36Sep 23, 2024 05:16PM

ap...@google.com <ap...@google.com> #37Sep 23, 2024 05:16PM

ap...@google.com <ap...@google.com> #38Oct 4, 2024 09:39PM

mg...@google.com <mg...@google.com> #39Oct 17, 2024 04:32PM

ap...@google.com <ap...@google.com> #40Oct 18, 2024 09:58AM

ap...@google.com <ap...@google.com> #41Oct 23, 2024 10:24AM

ap...@google.com <ap...@google.com> #42Oct 23, 2024 10:24AM

ap...@google.com <ap...@google.com> #43Oct 23, 2024 05:07PM

ap...@google.com <ap...@google.com> #44Oct 23, 2024 08:27PM

ap...@google.com <ap...@google.com> #45Oct 23, 2024 08:57PM

ap...@google.com <ap...@google.com> #46Oct 24, 2024 02:32PM

ap...@google.com <ap...@google.com> #47Oct 24, 2024 02:32PM

ap...@google.com <ap...@google.com> #48Oct 25, 2024 10:31AM

ap...@google.com <ap...@google.com> #49Oct 25, 2024 11:18AM

ap...@google.com <ap...@google.com> #50Oct 28, 2024 08:27AM

ap...@google.com <ap...@google.com> #51Oct 28, 2024 08:27AM

ap...@google.com <ap...@google.com> #52Oct 28, 2024 08:27AM

ap...@google.com <ap...@google.com> #53Oct 28, 2024 08:27AM

ap...@google.com <ap...@google.com> #54Oct 28, 2024 08:27AM

ap...@google.com <ap...@google.com> #55Oct 28, 2024 08:27AM

ap...@google.com <ap...@google.com> #56Oct 28, 2024 08:27AM

mg...@google.com <mg...@google.com> Oct 28, 2024 01:59PM

ap...@google.com <ap...@google.com> #57Oct 29, 2024 10:43PM

pr...@google.com <pr...@google.com> #58Oct 30, 2024 05:37PM

ap...@google.com <ap...@google.com> #59Nov 8, 2024 10:19PM

na...@google.com <na...@google.com> #60Nov 13, 2024 06:19PM

ap...@google.com <ap...@google.com> #61Nov 15, 2024 11:38AM

ap...@google.com <ap...@google.com> #62Nov 19, 2024 10:39AM

ap...@google.com <ap...@google.com> #63Nov 19, 2024 10:39AM

pr...@google.com <pr...@google.com> #64Dec 11, 2024 06:27PM

Add comment

Issue metadata