Support expanded handwriting bounds [335339283]

Fixed

Feature Request

Status Update

No update yet.

Description

ha...@google.com

created issue #1

Apr 17, 2024 01:31AM

No description yet.

Comments

ap...@google.com <ap...@google.com> #2Apr 29, 2024 07:17AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Apr 29, 2024 09:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit fd06360296066ed231e36bbbfb2ff0c2b26aab63
Author: Justin Ghan <justinghan@google.com>
Date: Mon Apr 29 11:52:25 2024

Extended handwriting bounds for handwriting detector

Bug: 327271923
Bug: 335339283
Test: HandwritingDetectorTest
Change-Id: Iacac1d536775711cdd3b4dbc2e1240c34c0b2cd0

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/HandwritingDetectorTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/handwriting/HandwritingDetector.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/handwriting/StylusHandwriting.kt

https://android-review.googlesource.com/3063195

ap...@google.com <ap...@google.com> #4Oct 8, 2024 05:21PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Haoyu Zhang <haoyuchang@google.com>
Link: https://android-review.googlesource.com/3249020

Introduce PointerInputModifierNode#touchBoundsExpansion

Expand for full commit details

Introduce PointerInputModifierNode#touchBoundsExpansion

Bug: 335339283
Test: HitTestTouchBoundsExpansionTest
Relnote: "Introduced PointerInputModifierNode#touchBoundsExpansion, which can be used to enlarge the touch bounds of a single pointer input modifier."

Change-Id: Iccf028b886639d3b24e7a257a023320362399389

Files:

A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/ExpandedTouchBoundsDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
A compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/node/HitTestTouchBoundsExpansionTest.kt
M compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
A compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/node/TouchBoundsExpansionTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/HitTestResult.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/NodeCoordinator.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/PointerInputModifierNode.kt

Hash: 3976106460a5de53a6821af410363ce4ef9625ba
Date: Wed Aug 28 19:28:11 2024

ap...@google.com <ap...@google.com> #5Oct 8, 2024 05:21PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Haoyu Zhang <haoyuchang@google.com>
Link: https://android-review.googlesource.com/3293242

Use MutableObjectList and MutableLongList in HitTestResult

Expand for full commit details

Use MutableObjectList and MutableLongList in HitTestResult

Use the newly introduced collections to simply the code.

Bug: 335339283
Test: HitTestResult, HitTestTouchBoundsExpansionTest, manually tested
Change-Id: If81864bf690db574d2d19c263f858b04bef2c013

Files:

M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/HitTestResult.kt

Hash: 6e4cda785e10e16b652d7ab135325b9e38dcbe8e
Date: Thu Oct 03 18:44:21 2024

ap...@google.com <ap...@google.com> #6Oct 10, 2024 08:09PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Haoyu Zhang <haoyuchang@google.com>
Link: https://android-review.googlesource.com/3299738

Fix that PointerInputModifier#touchBoundsExpansion doesn't work for stylus

Expand for full commit details

Fix that PointerInputModifier#touchBoundsExpansion doesn't work for stylus

Bug: 335339283
Test: LayoutNodeTest, HitTestTouchBoundsExpansionTest, manually tested
Change-Id: Ia33bc9dfb1bc40119a4d9accc4047879458b575e

Files:

M compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/node/HitTestTouchBoundsExpansionTest.kt
M compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessor.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/InnerNodeCoordinator.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/NodeCoordinator.kt

Hash: 4f2c54a0e60683918c050d22e82f3d9cfecd9089
Date: Tue Oct 08 15:22:34 2024

ap...@google.com <ap...@google.com> #7Oct 11, 2024 01:25AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Haoyu Zhang <haoyuchang@google.com>
Link: https://android-review.googlesource.com/3299651

Use PointerInputModifier.touchBoundsExpansion in Modifier.stylusHandwriting

Expand for full commit details

Use PointerInputModifier.touchBoundsExpansion in Modifier.stylusHandwriting

Bug: 335339283
Test: HandwritingDetectorTest, CoreTextFieldHandwritingBoundsTest
Change-Id: Idb1d94e7012e861f6fbc59d98a757fcd8727113a

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/CoreTextFieldHandwritingBoundsTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/HandwritingDetectorTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/handwriting/HandwritingDetector.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/handwriting/StylusHandwriting.kt

Hash: 3bc9af4a45b151bd0402e7f18edac35b787b4784
Date: Tue Oct 08 15:52:25 2024

ap...@google.com <ap...@google.com> #8Oct 24, 2024 12:44AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Haoyu Zhang <haoyuchang@google.com>
Link: https://android-review.googlesource.com/3313392

Support expanded touch bounds in BTF2

Expand for full commit details

Support expanded touch bounds in BTF2 
 
This CL extract Modifier.stylusHandwriting from TextFieldDecoratorModifierNode, so that it can have an expanded touch bounds.(Modifier.stylusHandwriting overwrites PointerInputModifierNode.touchBoundsExpansion.) And the other gestures detectors in TextFieldDecoratorModifierNode will have a touch bounds equal to editor's bounds. 
 
Bug: 335339283 
Test: BasicTextFieldHandwritingBoundsTest 
Change-Id: I9ea0f806d8eea3e0bc016477f7556d152d3ac995

Files:

A compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/BasicTextFieldHandwritingBoundsTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/handwriting/HandwritingDetector.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/handwriting/StylusHandwriting.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldDecoratorModifier.kt

Hash: 25302f79d6380813251a2a1d5b9402e7514a56e4
Date: Thu Oct 17 15:10:14 2024

ap...@google.com <ap...@google.com> #9Nov 6, 2024 03:58PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Justin Ghan <justinghan@google.com>
Link: https://android-review.googlesource.com/3326539

Introduce DpTouchBoundsExpansion API

Expand for full commit details

Introduce DpTouchBoundsExpansion API 
 
A stylus hover icon modifier will be added which uses touch bounds 
expansion, so a dp variant of TouchBoundsExpansion is needed. 
 
Bug: 335339283 
Test: HitTestTouchBoundsExpansionTest 
Relnote: N/A 
Change-Id: I38e7b12798c2d672a196b0a5ce2484c5c03c3871

Files:

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/PointerInputModifierNode.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/TouchBoundsExpansion.kt

Hash: ddc0b14383397c813ee0ca4ba88aa57fb9f1e092
Date: Thu Oct 31 00:41:35 2024

ha...@google.com <ha...@google.com> Nov 8, 2024 12:09AM

Marked as fixed.

na...@google.com <na...@google.com> #10Nov 13, 2024 06:19PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.8.0-alpha06
androidx.compose.ui:ui-android:1.8.0-alpha06
androidx.compose.ui:ui-jvmstubs:1.8.0-alpha06
androidx.compose.ui:ui-linuxx64stubs:1.8.0-alpha06

Issue 335339283

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Apr 29, 2024 07:17AM

ap...@google.com <ap...@google.com> #3Apr 29, 2024 09:31PM

ap...@google.com <ap...@google.com> #4Oct 8, 2024 05:21PM

ap...@google.com <ap...@google.com> #5Oct 8, 2024 05:21PM

ap...@google.com <ap...@google.com> #6Oct 10, 2024 08:09PM

ap...@google.com <ap...@google.com> #7Oct 11, 2024 01:25AM

ap...@google.com <ap...@google.com> #8Oct 24, 2024 12:44AM

ap...@google.com <ap...@google.com> #9Nov 6, 2024 03:58PM

ha...@google.com <ha...@google.com> Nov 8, 2024 12:09AM

na...@google.com <na...@google.com> #10Nov 13, 2024 06:19PM

Add comment

Issue metadata