Status Update
Comments
ap...@google.com <ap...@google.com> #2
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ap...@google.com <ap...@google.com> #3
ap...@google.com <ap...@google.com> #4
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Haoyu Zhang <
Link:
Use MutableObjectList and MutableLongList in HitTestResult
Expand for full commit details
Use MutableObjectList and MutableLongList in HitTestResult
Use the newly introduced collections to simply the code.
Bug: 335339283
Test: HitTestResult, HitTestTouchBoundsExpansionTest, manually tested
Change-Id: If81864bf690db574d2d19c263f858b04bef2c013
Files:
- M
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/HitTestResult.kt
Hash: 6e4cda785e10e16b652d7ab135325b9e38dcbe8e
Date: Thu Oct 03 18:44:21 2024
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
Author: Haoyu Zhang <
Link:
Fix that PointerInputModifier#touchBoundsExpansion doesn't work for stylus
Expand for full commit details
Fix that PointerInputModifier#touchBoundsExpansion doesn't work for stylus
Bug: 335339283
Test: LayoutNodeTest, HitTestTouchBoundsExpansionTest, manually tested
Change-Id: Ia33bc9dfb1bc40119a4d9accc4047879458b575e
Files:
- M
compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/node/HitTestTouchBoundsExpansionTest.kt
- M
compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
- M
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessor.kt
- M
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/InnerNodeCoordinator.kt
- M
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
- M
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/NodeCoordinator.kt
Hash: 4f2c54a0e60683918c050d22e82f3d9cfecd9089
Date: Tue Oct 08 15:22:34 2024
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
Author: Haoyu Zhang <
Link:
Use PointerInputModifier.touchBoundsExpansion in Modifier.stylusHandwriting
Expand for full commit details
Use PointerInputModifier.touchBoundsExpansion in Modifier.stylusHandwriting
Bug: 335339283
Test: HandwritingDetectorTest, CoreTextFieldHandwritingBoundsTest
Change-Id: Idb1d94e7012e861f6fbc59d98a757fcd8727113a
Files:
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/CoreTextFieldHandwritingBoundsTest.kt
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/HandwritingDetectorTest.kt
- M
compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/handwriting/HandwritingDetector.android.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/handwriting/StylusHandwriting.kt
Hash: 3bc9af4a45b151bd0402e7f18edac35b787b4784
Date: Tue Oct 08 15:52:25 2024
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
Author: Haoyu Zhang <
Link:
Support expanded touch bounds in BTF2
Expand for full commit details
Support expanded touch bounds in BTF2
This CL extract Modifier.stylusHandwriting from TextFieldDecoratorModifierNode, so that it can have an expanded touch bounds.(Modifier.stylusHandwriting overwrites PointerInputModifierNode.touchBoundsExpansion.) And the other gestures detectors in TextFieldDecoratorModifierNode will have a touch bounds equal to editor's bounds.
Bug: 335339283
Test: BasicTextFieldHandwritingBoundsTest
Change-Id: I9ea0f806d8eea3e0bc016477f7556d152d3ac995
Files:
- A
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/BasicTextFieldHandwritingBoundsTest.kt
- M
compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/handwriting/HandwritingDetector.android.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicTextField.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/handwriting/StylusHandwriting.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldDecoratorModifier.kt
Hash: 25302f79d6380813251a2a1d5b9402e7514a56e4
Date: Thu Oct 17 15:10:14 2024
ap...@google.com <ap...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-main
Author: Justin Ghan <
Link:
Introduce DpTouchBoundsExpansion API
Expand for full commit details
Introduce DpTouchBoundsExpansion API
A stylus hover icon modifier will be added which uses touch bounds
expansion, so a dp variant of TouchBoundsExpansion is needed.
Bug: 335339283
Test: HitTestTouchBoundsExpansionTest
Relnote: N/A
Change-Id: I38e7b12798c2d672a196b0a5ce2484c5c03c3871
Files:
- M
compose/ui/ui/api/current.txt
- M
compose/ui/ui/api/restricted_current.txt
- M
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/PointerInputModifierNode.kt
- A
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/TouchBoundsExpansion.kt
Hash: ddc0b14383397c813ee0ca4ba88aa57fb9f1e092
Date: Thu Oct 31 00:41:35 2024
ha...@google.com <ha...@google.com>
na...@google.com <na...@google.com> #10
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui:1.8.0-alpha06
androidx.compose.ui:ui-android:1.8.0-alpha06
androidx.compose.ui:ui-jvmstubs:1.8.0-alpha06
androidx.compose.ui:ui-linuxx64stubs:1.8.0-alpha06
Description
No description yet.