Fixed
Status Update
Comments
je...@google.com <je...@google.com> #2
Comment has been deleted.
hu...@google.com <hu...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit b214d707cbc673eaf61d0fefdd95bd8e14dda7fc
Author: Marcello Albano <maralb@google.com>
Date: Wed Nov 29 14:28:33 2023
Fix for bp plugin when agp < 8.3.0-alpha15 to support library profiles
When min agp version requirement to support baseline profile source sets
in libraries we have to fallback on merging all the profiles and always
writing in src/main/baseline-prof.txt.
Bug: 313992099
Change-Id: I1d2af6193d596a43a5f6a05eb15b2b0951523ad4
Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Relnote: Fix for including library baseline profiles in AAR prior to AGP 8.3.0-alpha15
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/utils/Agp.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/producer/BaselineProfileProducerPluginTest.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/utils/BaselineProfileProjectSetupRule.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/utils/Constants.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/wrapper/BaselineProfileWrapperPluginTest.kt
M benchmark/integration-tests/baselineprofile-library-producer/src/main/java/androidx/benchmark/integration/baselineprofile/library/producer/BaselineProfileTest.kt
M gradle/verification-metadata.xml
https://android-review.googlesource.com/2853470
Branch: androidx-main
commit b214d707cbc673eaf61d0fefdd95bd8e14dda7fc
Author: Marcello Albano <maralb@google.com>
Date: Wed Nov 29 14:28:33 2023
Fix for bp plugin when agp < 8.3.0-alpha15 to support library profiles
When min agp version requirement to support baseline profile source sets
in libraries we have to fallback on merging all the profiles and always
writing in src/main/baseline-prof.txt.
Bug: 313992099
Change-Id: I1d2af6193d596a43a5f6a05eb15b2b0951523ad4
Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Relnote: Fix for including library baseline profiles in AAR prior to AGP 8.3.0-alpha15
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/utils/Agp.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/producer/BaselineProfileProducerPluginTest.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/utils/BaselineProfileProjectSetupRule.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/utils/Constants.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/wrapper/BaselineProfileWrapperPluginTest.kt
M benchmark/integration-tests/baselineprofile-library-producer/src/main/java/androidx/benchmark/integration/baselineprofile/library/producer/BaselineProfileTest.kt
M gradle/verification-metadata.xml
an...@google.com <an...@google.com> #4
sending this back, as it's not specific to JankStats (nor do I have any context on what the problems/fixes are)
sa...@gmail.com <sa...@gmail.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.0-alpha01
Description
(Extracted fromhttp://issuetracker.google.com/230454566#comment20 .)
Steps to reproduce
https://github.com/android/nowinandroid
The build will fail with:
Root cause
When setting up the query of classes .
DexingWithFullClasspathTransform
(available whenandroid.useFullClasspathForDexingTransform = true
), we didn't add all the necessary attributes forTherefore, Gradle couldn't select the correct transform among multiple available ones.
Fix
Add the missing attributes to the transform setup:
Workaround
If you run into this issue, please try adding the attribute manually in your build script as follows:
The attribute to add can be found by analyzing the error message. In most cases, the above will work; but if it doesn't, please let us know.