Assigned
Status Update
No update yet.
Comments
me...@booking.com
I face with the same problem. I have different pageMargin in landscape and portrait and when viewpager is scrolled for the more than first position, after rotating device it is shifted.
I beleive the problem is inside onSizeChanged that is called after onConfigurationChanged, it has following code:
if (w != oldw) {
recomputeScrollPosition(w, oldw, mPageMargin, mPageMargin);
}
w always not equals oldw when changing orientation, so recomputeScrollPosition is called, but whit the same values for margin and oldMargin.
This should be fixed.
I beleive the problem is inside onSizeChanged that is called after onConfigurationChanged, it has following code:
if (w != oldw) {
recomputeScrollPosition(w, oldw, mPageMargin, mPageMargin);
}
w always not equals oldw when changing orientation, so recomputeScrollPosition is called, but whit the same values for margin and oldMargin.
This should be fixed.
Description
Version used:Androidx.AppCompat 1.6.1
Devices/Android versions reproduced on: All
I would like to use
However, Androidx registers CoreComponentFactory when included in the project. I would have to use tools:replace and opt for my version of CustomAppComponentFactory which probably would result in missing features and crashes if I read the code right.
I could update my Custom AppComponentFactory delegate to CoreComponentFactory, However, this class is marked Restricted to LibraryGroupPrefix
Could CoreComponentFactory be used as delegate. i.e. the restriction removed please.
Or Could framework be updated to enable multiple AppComponentFactory using delegates. Without these updates AppComponentFactory is literally only usable by Androidx libraries.
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).