Macrobenchmarks - Regression found between 11748432 and 11748459 [336588271]

Fixed

Bug

Status Update

No update yet.

Description

sk...@skia-public.iam.gserviceaccount.com

created issue on behalf of an...@google.com #1

Apr 23, 2024 07:12PM

Perf Regression (High) found, matching 214 tracked metrics from benchmarks.

To triage this regression, see the guide at go/androidx-bench-triage.

Tests affected:

 androidx.benchmark.integration.macrobenchmark.GridBenchmark_scroll_compilation_WarmupProfile_iterations_3__
 androidx.benchmark.integration.macrobenchmark.SeparateProcessBenchmark_startup
 androidx.benchmark.integration.macrobenchmark.SmallListStartupBenchmark_startup_startup_COLD_compilation_None_
 androidx.benchmark.integration.macrobenchmark.SmallListStartupBenchmark_startup_startup_COLD_compilation_WarmupProfile_iterations_3__
 androidx.benchmark.integration.macrobenchmark.StartupPressHomeBenchmark_startup_pressHomeInMeasure_false_startup_WARM_
 androidx.benchmark.integration.macrobenchmark.StartupPressHomeBenchmark_startup_pressHomeInMeasure_true_startup_COLD_
 androidx.benchmark.integration.macrobenchmark.TrivialListScrollBenchmark_start_compilation_Full_
 androidx.benchmark.integration.macrobenchmark.TrivialListScrollBenchmark_start_compilation_None_
 androidx.compose.integration.hero.macrobenchmark.jetsnack.JetsnackScrollBenchmark_scrollHome_compilation_WarmupProfile_iterations_3__
 androidx.compose.integration.hero.macrobenchmark.jetsnack.JetsnackStartupBenchmark_startup_startup_COLD_compilationMode_None_
 androidx.compose.integration.hero.macrobenchmark.jetsnack.JetsnackStartupBenchmark_startup_startup_HOT_compilationMode_BaselineProfile_
 androidx.compose.integration.macrobenchmark.AndroidViewListScrollBenchmark_scroll_compilation_BaselineProfile_
 androidx.compose.integration.macrobenchmark.AndroidViewListScrollBenchmark_scroll_compilation_None_
 androidx.compose.integration.macrobenchmark.AndroidViewListScrollBenchmark_scroll_compilation_WarmupProfile_iterations_3__
 androidx.constraintlayout.compose.integration.macrobenchmark.MotionLayoutBenchmark_messageDsl
 androidx.constraintlayout.compose.integration.macrobenchmark.MotionLayoutBenchmark_messageJson
 androidx.profileinstaller.integration.macrobenchmark.ProfileinstallerStartupBenchmark_startup_startup_COLD_compilation_WarmupProfile_iterations_3__
 androidx.wear.benchmark.integration.macrobenchmark.ScrollBenchmark_start_compilation_BaselineProfile_
 androidx.wear.benchmark.integration.macrobenchmark.ScrollBenchmark_start_compilation_Full_
 androidx.wear.benchmark.integration.macrobenchmark.ScrollBenchmark_start_compilation_None_
 androidx.wear.benchmark.integration.macrobenchmark.ScrollBenchmark_start_compilation_WarmupProfile_iterations_3__
 androidx.wear.benchmark.integration.macrobenchmark.StartupBenchmark_startup_startup_HOT_compilation_BaselineProfile_
 androidx.wear.benchmark.integration.macrobenchmark.StartupBenchmark_startup_startup_WARM_compilation_BaselineProfile_
 androidx.wear.benchmark.integration.macrobenchmark.SwipeBenchmark_start_compilation_None_
 androidx.wear.benchmark.integration.macrobenchmark.SwipeBenchmark_start_compilation_WarmupProfile_iterations_3__
 androidx.wear.compose.integration.macrobenchmark.PositionIndicatorBenchmark_start_compilation_Full_
 androidx.wear.compose.integration.macrobenchmark.PositionIndicatorBenchmark_start_compilation_None_
 androidx.wear.compose.integration.macrobenchmark.PositionIndicatorBenchmark_start_compilation_WarmupProfile_iterations_3__
 androidx.wear.compose.integration.macrobenchmark.test.ScrollBenchmark_start_compilation_BaselineProfile_
 androidx.wear.compose.integration.macrobenchmark.test.ScrollBenchmark_start_compilation_Full_
 androidx.wear.compose.integration.macrobenchmark.test.ScrollBenchmark_start_compilation_WarmupProfile_iterations_3__
 androidx.wear.compose.integration.macrobenchmark.test.StartupBenchmark_startup_startup_COLD_compilation_Full_
 androidx.wear.compose.integration.macrobenchmark.test.SwipeBenchmark_start_compilation_BaselineProfile_
 androidx.wear.compose.integration.macrobenchmark.test.SwipeBenchmark_start_compilation_Full_
 androidx.wear.compose.integration.macrobenchmark.test.SwipeBenchmark_start_compilation_None_
 androidx.wear.compose.integration.macrobenchmark.test.SwipeBenchmark_start_compilation_WarmupProfile_iterations_3__

Devices affected:

 sailfish

API Level:

 API_29_Q

Comments

ra...@google.com <ra...@google.com> #2Apr 24, 2024 06:50PM

Accepted by ra...@google.com.

Since this is happening in Tink, rather than in the AndroidX library, it would be best to open an issue with that project, as there isn't an easy way for us to fix this.

cc...@google.com <cc...@google.com> #3Apr 25, 2024 09:50PM

@2 I don't know what "Tink" is, but here, created:

https://github.com/google/tink/issues/534

Would this mean that this bug report should be written there as well:

https://issuetracker.google.com/issues/176215143
?

ap...@google.com <ap...@google.com> #4Apr 26, 2024 07:00PM

Marked as fixed.

Tink is the library that does the heavy lifting in Jetpack Security.

And yes, potentially raising that issue with the Tink team directly could help.

ap...@google.com <ap...@google.com> #5Apr 30, 2024 07:48PM

@4 Well why didn't Google offer it there? Crashes are far more important than warning logs...
Here, created it there too:

https://github.com/google/tink/issues/535

pr...@google.com <pr...@google.com> #6May 14, 2024 05:22PM

Anyone here solved the issue? I have implemented the jetpack security and got the same crashes.

Issue 336588271