Macrobenchmarks - Regression found between 11748432 and 11748459 [336588271]

Fixed

Bug

Status Update

No update yet.

Description

sk...@skia-public.iam.gserviceaccount.com

created issue on behalf of an...@google.com #1

Apr 23, 2024 07:12PM

Perf Regression (High) found, matching 214 tracked metrics from benchmarks.

To triage this regression, see the guide at go/androidx-bench-triage.

Tests affected:

 androidx.benchmark.integration.macrobenchmark.GridBenchmark_scroll_compilation_WarmupProfile_iterations_3__
 androidx.benchmark.integration.macrobenchmark.SeparateProcessBenchmark_startup
 androidx.benchmark.integration.macrobenchmark.SmallListStartupBenchmark_startup_startup_COLD_compilation_None_
 androidx.benchmark.integration.macrobenchmark.SmallListStartupBenchmark_startup_startup_COLD_compilation_WarmupProfile_iterations_3__
 androidx.benchmark.integration.macrobenchmark.StartupPressHomeBenchmark_startup_pressHomeInMeasure_false_startup_WARM_
 androidx.benchmark.integration.macrobenchmark.StartupPressHomeBenchmark_startup_pressHomeInMeasure_true_startup_COLD_
 androidx.benchmark.integration.macrobenchmark.TrivialListScrollBenchmark_start_compilation_Full_
 androidx.benchmark.integration.macrobenchmark.TrivialListScrollBenchmark_start_compilation_None_
 androidx.compose.integration.hero.macrobenchmark.jetsnack.JetsnackScrollBenchmark_scrollHome_compilation_WarmupProfile_iterations_3__
 androidx.compose.integration.hero.macrobenchmark.jetsnack.JetsnackStartupBenchmark_startup_startup_COLD_compilationMode_None_
 androidx.compose.integration.hero.macrobenchmark.jetsnack.JetsnackStartupBenchmark_startup_startup_HOT_compilationMode_BaselineProfile_
 androidx.compose.integration.macrobenchmark.AndroidViewListScrollBenchmark_scroll_compilation_BaselineProfile_
 androidx.compose.integration.macrobenchmark.AndroidViewListScrollBenchmark_scroll_compilation_None_
 androidx.compose.integration.macrobenchmark.AndroidViewListScrollBenchmark_scroll_compilation_WarmupProfile_iterations_3__
 androidx.constraintlayout.compose.integration.macrobenchmark.MotionLayoutBenchmark_messageDsl
 androidx.constraintlayout.compose.integration.macrobenchmark.MotionLayoutBenchmark_messageJson
 androidx.profileinstaller.integration.macrobenchmark.ProfileinstallerStartupBenchmark_startup_startup_COLD_compilation_WarmupProfile_iterations_3__
 androidx.wear.benchmark.integration.macrobenchmark.ScrollBenchmark_start_compilation_BaselineProfile_
 androidx.wear.benchmark.integration.macrobenchmark.ScrollBenchmark_start_compilation_Full_
 androidx.wear.benchmark.integration.macrobenchmark.ScrollBenchmark_start_compilation_None_
 androidx.wear.benchmark.integration.macrobenchmark.ScrollBenchmark_start_compilation_WarmupProfile_iterations_3__
 androidx.wear.benchmark.integration.macrobenchmark.StartupBenchmark_startup_startup_HOT_compilation_BaselineProfile_
 androidx.wear.benchmark.integration.macrobenchmark.StartupBenchmark_startup_startup_WARM_compilation_BaselineProfile_
 androidx.wear.benchmark.integration.macrobenchmark.SwipeBenchmark_start_compilation_None_
 androidx.wear.benchmark.integration.macrobenchmark.SwipeBenchmark_start_compilation_WarmupProfile_iterations_3__
 androidx.wear.compose.integration.macrobenchmark.PositionIndicatorBenchmark_start_compilation_Full_
 androidx.wear.compose.integration.macrobenchmark.PositionIndicatorBenchmark_start_compilation_None_
 androidx.wear.compose.integration.macrobenchmark.PositionIndicatorBenchmark_start_compilation_WarmupProfile_iterations_3__
 androidx.wear.compose.integration.macrobenchmark.test.ScrollBenchmark_start_compilation_BaselineProfile_
 androidx.wear.compose.integration.macrobenchmark.test.ScrollBenchmark_start_compilation_Full_
 androidx.wear.compose.integration.macrobenchmark.test.ScrollBenchmark_start_compilation_WarmupProfile_iterations_3__
 androidx.wear.compose.integration.macrobenchmark.test.StartupBenchmark_startup_startup_COLD_compilation_Full_
 androidx.wear.compose.integration.macrobenchmark.test.SwipeBenchmark_start_compilation_BaselineProfile_
 androidx.wear.compose.integration.macrobenchmark.test.SwipeBenchmark_start_compilation_Full_
 androidx.wear.compose.integration.macrobenchmark.test.SwipeBenchmark_start_compilation_None_
 androidx.wear.compose.integration.macrobenchmark.test.SwipeBenchmark_start_compilation_WarmupProfile_iterations_3__

Devices affected:

 sailfish

API Level:

 API_29_Q

Comments

ra...@google.com <ra...@google.com> #2Apr 24, 2024 06:50PM

Accepted by ra...@google.com.

Any suggestions on where such an interface might live? I don't think it makes sense for the interface to be in the drawerlayout artifact if you're specifically going to use the interface to *not* use DrawerLayout.

cc...@google.com <cc...@google.com> #3Apr 25, 2024 09:50PM

androidx.customview would be a good candidate. This is used by all of the widget libraries.

ap...@google.com <ap...@google.com> #4Apr 26, 2024 07:00PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020

Create an interface for layouts that can be opened

Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.

Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19

M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/940787

ap...@google.com <ap...@google.com> #5Apr 30, 2024 07:48PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2d1785e9837b97c6d64878413efb96d873895cd0
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Apr 24 16:57:02 2024

Move method tracing to a separate phase.

* Method tracing now runs as a separate phase, without interfering with metrics.

Fixes: 285912360
Fixes: 336588271
Test: Existing unit tests.
Change-Id: If9a504a7bce7228840339b34294ba3fdf98aceeb
Relnote: Method tracing runs as a seperate phase during a Macrobenchmark, and it no longer affects measurements.

M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt
A benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkPhase.kt

https://android-review.googlesource.com/3059411

pr...@google.com <pr...@google.com> #6May 14, 2024 05:22PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.3.0-alpha05

Issue 336588271