ResolutionsMerger does not consider high resolution when usecase add cameraEffect [337336152]

Fixed

Bug

Status Update

No update yet.

Description

hu...@gmail.com

created issue #1

Apr 27, 2024 12:19PM

CAMERAX VERSION (1.4.0-alpha05)

CAMERA APPLICATION NAME AND VERSION: (Settings > Apps > (app name) > version)

ANDROID OS BUILD NUMBER: (android 11)

DEVICE NAME: (Samsung A32 5G)

in camerX 1.4.0-alpha5 androidx.camera.core.streamsharing.ResolutionsMerger have a bug:

1.use two usecanse ,preview,imagecapture,and set androidx.camera.effects.OverlayEffect

2.imagecapture and preview set capturemodel to PREFER_HIGHER_RESOLUTION_OVER_CAPTURE_RATE to use the heightresolution

3.then crash

Caused by: androidx.camera.core.internal.CameraUseCaseAdapter$CameraException: java.lang.IllegalArgumentException: No available output size is found for androidx.camera.core.streamsharing.StreamSharingConfig@52e6012

androidx.camera.core.streamsharing.ResolutionsMerger.java
private ResolutionsMerger(@NonNull Size sensorSize, @NonNull CameraInfoInternal cameraInfo,
            @NonNull Set<UseCaseConfig<?>> childrenConfigs) {
        this(sensorSize, childrenConfigs, new SupportedOutputSizesSorter(cameraInfo, sensorSize),
                cameraInfo.getSupportedResolutions(INTERNAL_DEFINED_IMAGE_FORMAT_PRIVATE));// should fix it,consider the children usecase of StreamSharing set capturemode PREFER_HIGHER_RESOLUTION_OVER_CAPTURE_RATE to use heightrResolution
    }

Comments

wu...@google.com <wu...@google.com> Apr 30, 2024 06:42AM

Reassigned to mi...@google.com.

mi...@google.com <mi...@google.com> #2Apr 30, 2024 09:18AM

Accepted by mi...@google.com.

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

hu...@gmail.com <hu...@gmail.com> #3Apr 30, 2024 11:03AM

Great! Thanks a lot, I'll look for the live updates soon!

mi...@google.com <mi...@google.com> #4May 2, 2024 06:59AM

Thank you for sharing the information, I think the cause of the crash is what we suspected.

ap...@google.com <ap...@google.com> #5May 8, 2024 04:53AM

Project: platform/frameworks/support
Branch: androidx-main

commit 9ba9bef43da0b3d6b0cbf5b51d5f66f80333e49d
Author: mingdatsai <mingdatsai@google.com>
Date: Thu May 02 17:29:20 2024

Consider high resolutions in ResolutionsMerger

Relnote: "Fixed a bug where High Resolutions can not be selected when
CameraEffect is enabled on some devices. (e.g. 4000x3000 on Samsung
A32 5G)."

Bug: 337336152
Test: manual test and ResolutionsMergerTest
Change-Id: Ie3ed3a802305628e471d73b4741add0d46ac12ad

M camera/camera-core/src/main/java/androidx/camera/core/streamsharing/ResolutionsMerger.java
M camera/camera-core/src/test/java/androidx/camera/core/streamsharing/ResolutionsMergerTest.kt

https://android-review.googlesource.com/3069984

mi...@google.com <mi...@google.com> #6May 8, 2024 04:55AM

The fix is merged and would be released in the 1.4.0-beta02 release.

mi...@google.com <mi...@google.com> #7May 8, 2024 04:58AM

Marked as fixed.

I will close the bug, please feel free to reopen it if there are any issues.

pr...@google.com <pr...@google.com> #8May 14, 2024 05:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-core:1.4.0-beta01