Add linuxArm64 as supported target [338268719]

Fixed

Bug

Status Update

No update yet.

Description

go...@jakewharton.com

created issue #1

May 2, 2024 02:59AM

Today there's only linuxX64, but Macs get x64 and ARM. Let's extend an ARM to our Linux friends! This target is buildable from any host OS.

Comments

go...@jakewharton.com <go...@jakewharton.com> #2May 2, 2024 06:18PM

Note that only target platforms supported by Compose (not to confuse with Compose Multiplatform) will be supported by the lifecycle-viewmodel-compose artifact.

ap...@google.com <ap...@google.com> #3May 13, 2024 04:34PM

Project: platform/frameworks/support
Branch: androidx-main

commit 74baccb421292733fcff3fc12335fdbfdb69ece0
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:39:47 2024

Add `KClass` method variants on `viewmodel-compose`

RelNote: "Composable `viewModel` functions now accept a `KClass` for Multiplatform compatibility. The `Class` variants are kept for Android compatibility."
Test: N/A
Bug: 330323282
Change-Id: I59611546d8a5fd133694817837a986c029fcd47e

M lifecycle/lifecycle-viewmodel-compose/api/current.txt
M lifecycle/lifecycle-viewmodel-compose/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.android.kt

https://android-review.googlesource.com/3007640

ap...@google.com <ap...@google.com> #4May 13, 2024 04:34PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4beef5f6d988924a9640138db56f193301ef1329
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:18:32 2024

Configure KMP on `viewmodel-compose`

* Setup the build scripts.
* Setup folder hierarchy.

Test: N/A
Bug: 330323282
Change-Id: Ib7d563bb2c2277b3c3a4167803ffdc9472dcfd5c

M docs-tip-of-tree/build.gradle
M lifecycle/lifecycle-viewmodel-compose/build.gradle
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/AndroidManifest.xml
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaverTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/TestViewModelClasses.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInAppCompatActivityTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInComponentActivityTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInFragmentTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaveableApi.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaver.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.kt

https://android-review.googlesource.com/3007634

fs...@google.com <fs...@google.com> May 14, 2024 04:17PM

Accepted by fs...@google.com.

ap...@google.com <ap...@google.com> #5May 22, 2024 04:53PM

Project: platform/frameworks/support
Branch: androidx-main

commit 89a169b4573e1b28c7a5a73fd52d294bd0596a79
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:33:41 2024

Move `LocalViewModelStoreOwner` to common on `viewmodel-compose`

Test: N/A
Bug: 330323282
Change-Id: I1ead8036fc8b3c49d5846c417d301f281cff90e3

M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.android.kt
A lifecycle/lifecycle-viewmodel-compose/src/commonMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.kt
A lifecycle/lifecycle-viewmodel-compose/src/desktopMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.desktop.kt

https://android-review.googlesource.com/3007638

au...@google.com <au...@google.com> #6Jul 12, 2024 04:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit b8e5ea51a234c4cdbbed82e41f6ffd28f630dcd9
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:22:15 2024

Rename source from `viewmodel-compose` to follow KMP convention

Test: N/A
Bug: 330323282
Change-Id: Ic417903127417b53f0888263a35fc5e4a82d57cc

M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaverTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/TestViewModelClasses.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInAppCompatActivityTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInComponentActivityTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInFragmentTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaveableApi.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaver.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.android.kt

https://android-review.googlesource.com/3007635

ap...@google.com <ap...@google.com> #7Jul 12, 2024 04:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit 37991db14175338fe6beac23bae696090689d418
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:24:42 2024

Update Compose UI and Runtime to 1.6.0 in `viewmodel-compose`

* Required to use the `Composable` annotation from the common source set.

Test: N/A
Bug: 330323282
Change-Id: I879d9bd2c904524f157cf24068130d7cfc1cce45

M lifecycle/lifecycle-viewmodel-compose/build.gradle

https://android-review.googlesource.com/3007636

au...@google.com <au...@google.com> Jul 12, 2024 06:36PM

Marked as fixed.

pr...@google.com <pr...@google.com> #8Aug 13, 2024 06:58PM

Project: platform/frameworks/support
Branch: androidx-main

commit 288826d6e5ecd81e1300562feb62ceedf6ecc912
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:44:25 2024

Move `ViewModel.kt` to common on `viewmodel-compose`

Test: N/A
Bug: 330323282
Change-Id: I0cec3da46577619bdf51a57976fa726ce961ad93

M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.android.kt
A lifecycle/lifecycle-viewmodel-compose/src/commonMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.kt

https://android-review.googlesource.com/3007642

na...@google.com <na...@google.com> #9Aug 21, 2024 07:55PM

Project: platform/frameworks/support
Branch: androidx-main

commit 61e7561c841336e65be6c18fa7fd8d8b003fb2a4
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:26:09 2024

Move dependencies to `commonMain` on `viewmodel-compose`

Test: N/A
Bug: 330323282
Change-Id: I9ccddf090462f16a71dabe9a0f687c7e91ffb5f6

M lifecycle/lifecycle-viewmodel-compose/build.gradle

https://android-review.googlesource.com/3007637

pr...@google.com <pr...@google.com> #10Sep 5, 2024 08:09PM

Project: platform/frameworks/support
Branch: androidx-main

commit a1f7b7585088dd00015c61bfa10053e76f77cc85
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:41:44 2024

Use `ViewModelProvider.create` method on `viewmodel-compose`

Test: N/A
Bug: 330323282
Change-Id: I056165d298392ddae01f170bd7912196207c30ea

M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.android.kt

https://android-review.googlesource.com/3007641