[M3][ModalBottomSheet] The statusbar doesn't follow app's status bar settings when expanded [338342149]

Fixed

Bug

Status Update

No update yet.

Description

64...@gmail.com

created issue #1

May 2, 2024 11:30AM

description

Since the last alpha (1.3.0-alpha06) the bottom sheet doesn't respect the existing options of the status bar (light/dark) when fully expanded. Resulting in an unreadable statusbar when fully expanded (see sample code & screenshot).

info

Jetpack Compose version: bom 2024.05.00 / compiler 1.5.13
Material Library Version (M2, M3 or Both?): m3 1.3.0-alpha06
Material Compose component used: ModalBottomSheet
Android Studio Build: #AI-241.14494.240.2411.11771556
Kotlin version: 1.9.23

code sample to reproduce:

var isSheetVisible by remember {
    mutableStateOf(false)
}
val sheetState = rememberModalBottomSheetState()
val scope = rememberCoroutineScope()

Button(onClick = { isSheetVisible = true }) {
    Text("Show modal bottom sheet")
}

if (isSheetVisible) {
    ModalBottomSheet(
        sheetState = sheetState,
        onDismissRequest = {
            scope
                .launch { sheetState.hide() }
                .invokeOnCompletion {
                    isSheetVisible = false
                }
        },
        content = {
            Text(
                "This is a modal bottom sheet",
                modifier = Modifier.fillMaxSize()
            )
        }
    )
}

Screenshot 2024-05-02 at 13.19.55.png

19 KB

View

Download

Screenshot 2024-05-02 at 13.20.05.png

23 KB

View

Download

Comments

se...@google.com <se...@google.com> May 2, 2024 02:11PM

Reassigned to se...@google.com.

pe...@gmail.com <pe...@gmail.com> #2May 6, 2024 07:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

64...@gmail.com <64...@gmail.com> #3May 7, 2024 10:52AM

#2 i didn't have the chance to investigate on a workaround sadly, let me know if you do find some way :)

se...@google.com <se...@google.com> May 10, 2024 02:10PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #4May 13, 2024 06:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6408e12a00fe573586bf1f052317ad7a4868e8a3
Author: Jose Figueroa <serniebanders@google.com>
Date: Fri May 10 10:17:32 2024

Update status and nav bar icons to respond to system dark theme status.

Note: new style res have been moved under androidMain

Bug: 338342149
Test: Manual
Relnote: ModalBottomSheet status and nav bar icons now respond to dark theme status
Change-Id: Ie1fe7e1f792c39d52b4d419a08209c2577bf1175

M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/res/values-v30/styles.xml
M compose/material3/material3/src/androidMain/res/values/styles.xml

https://android-review.googlesource.com/3079589

se...@google.com <se...@google.com> #5May 13, 2024 06:50PM

Marked as fixed.

The updated fix here has the sheet dialog respond to system dark theme to toggle between light and dark icons. Because the dialog provides a new window it does not respect an applications theme unfortunately. Down the line we hope to split the window and sheet logic so users can customize this more thoroughly.

na...@google.com <na...@google.com> #6May 29, 2024 06:05PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.3.0-beta02
androidx.compose.material3:material3-android:1.3.0-beta02
androidx.compose.material3:material3-desktop:1.3.0-beta02

64...@gmail.com <64...@gmail.com> #7Jun 5, 2024 04:15PM

thanks for the fix!

gi...@spotify.com <gi...@spotify.com> #8Sep 24, 2024 02:51PM

The fix introduced a new bug. In our app, we don't use the night mode and only have one dark theme. After upgrading to 1.3.0, whenever a bottom sheet is opened, the navigation bar turns bright, instead of staying dark. It might be better to decide, if a dark theme is used by using the current colorScheme instead of the system's night mode.