[M3][ModalBottomSheet] The statusbar doesn't follow app's status bar settings when expanded [338342149]

Fixed

Bug

Status Update

No update yet.

Description

64...@gmail.com

created issue #1

May 2, 2024 11:30AM

description

Since the last alpha (1.3.0-alpha06) the bottom sheet doesn't respect the existing options of the status bar (light/dark) when fully expanded. Resulting in an unreadable statusbar when fully expanded (see sample code & screenshot).

info

Jetpack Compose version: bom 2024.05.00 / compiler 1.5.13
Material Library Version (M2, M3 or Both?): m3 1.3.0-alpha06
Material Compose component used: ModalBottomSheet
Android Studio Build: #AI-241.14494.240.2411.11771556
Kotlin version: 1.9.23

code sample to reproduce:

var isSheetVisible by remember {
    mutableStateOf(false)
}
val sheetState = rememberModalBottomSheetState()
val scope = rememberCoroutineScope()

Button(onClick = { isSheetVisible = true }) {
    Text("Show modal bottom sheet")
}

if (isSheetVisible) {
    ModalBottomSheet(
        sheetState = sheetState,
        onDismissRequest = {
            scope
                .launch { sheetState.hide() }
                .invokeOnCompletion {
                    isSheetVisible = false
                }
        },
        content = {
            Text(
                "This is a modal bottom sheet",
                modifier = Modifier.fillMaxSize()
            )
        }
    )
}

Screenshot 2024-05-02 at 13.19.55.png

19 KB

View

Download

Screenshot 2024-05-02 at 13.20.05.png

23 KB

View

Download

Comments

se...@google.com <se...@google.com> May 2, 2024 02:11PM

Reassigned to se...@google.com.

pe...@gmail.com <pe...@gmail.com> #2May 6, 2024 07:38PM

Project: platform/frameworks/support
Branch: androidx-main

commit a330c0d3bcdd41326f37968a60e6084ad4a2e32c
Author: Chet Haase <chet@google.com>
Date: Wed Jul 05 07:26:46 2023

Convert APIs using PointF to use Float instead

PointF is a convenient mechanism for passing around x.y values
representing 2D points. But there are downsides, including:
- Converting to PointF: You may not have the data in PointF form
to begin with, so using an API which takes PointF requires converting
the data to that form (including allocating a PointF object every time)
- Mutability: Point structures can be mutated internally, causing
unpredictability in what that mutation means. Should the library
react to those changes? Ignore them? Do defensive copies (requiring
even more allocations)? Using primitive types like Float make the
behavior more obvious (by making the data inherently immutable).
- Allocations: Whenever we use object types, there are necessarily
allocations on the Java heap for them. This puts pressure on the GC
at both allocation and collection time. Given the amount of points
being passed around (especially at morph creation time, when curves
are being split and created), this causes a lot of PointF objects to
be allocated (even temporarily). Using Float avoids that problem.

Also fixed bug with unclosed paths causing discontinuity at the
start/end point.

Bug: 276466399
Bug: 290254314
Test: integration and unit tests pass
Relnote: PointF parameters changed to Float pairs
Change-Id: Id4705d27c7be31b26ade8186b99fffe2e2f8450e

M graphics/graphics-shapes/api/current.txt
M graphics/graphics-shapes/api/restricted_current.txt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicShapeTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonMeasureTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/RoundedPolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/ShapesTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/TestUtils.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Cubic.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/CubicShape.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FeatureMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FloatMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Morph.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/PolygonMeasure.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/RoundedPolygon.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Shapes.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Utils.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/DebugDraw.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/ShapeEditor.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/MaterialShapes.kt

https://android-review.googlesource.com/2649119

64...@gmail.com <64...@gmail.com> #3May 7, 2024 10:52AM

PointF was the main (possibly only) mutability issue, marking this as fixed

se...@google.com <se...@google.com> May 10, 2024 02:10PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #4May 13, 2024 06:43PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.graphics:graphics-shapes:1.0.0-alpha04

se...@google.com <se...@google.com> #5May 13, 2024 06:50PM

Marked as fixed.

The updated fix here has the sheet dialog respond to system dark theme to toggle between light and dark icons. Because the dialog provides a new window it does not respect an applications theme unfortunately. Down the line we hope to split the window and sheet logic so users can customize this more thoroughly.

na...@google.com <na...@google.com> #6May 29, 2024 06:05PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.3.0-beta02
androidx.compose.material3:material3-android:1.3.0-beta02
androidx.compose.material3:material3-desktop:1.3.0-beta02

64...@gmail.com <64...@gmail.com> #7Jun 5, 2024 04:15PM

thanks for the fix!

gi...@spotify.com <gi...@spotify.com> #8Sep 24, 2024 02:51PM

The fix introduced a new bug. In our app, we don't use the night mode and only have one dark theme. After upgrading to 1.3.0, whenever a bottom sheet is opened, the navigation bar turns bright, instead of staying dark. It might be better to decide, if a dark theme is used by using the current colorScheme instead of the system's night mode.