[M3][ModalBottomSheet] The statusbar doesn't follow app's status bar settings when expanded [338342149]

Fixed

Bug

Status Update

No update yet.

Description

64...@gmail.com

created issue #1

May 2, 2024 11:30AM

description

Since the last alpha (1.3.0-alpha06) the bottom sheet doesn't respect the existing options of the status bar (light/dark) when fully expanded. Resulting in an unreadable statusbar when fully expanded (see sample code & screenshot).

info

Jetpack Compose version: bom 2024.05.00 / compiler 1.5.13
Material Library Version (M2, M3 or Both?): m3 1.3.0-alpha06
Material Compose component used: ModalBottomSheet
Android Studio Build: #AI-241.14494.240.2411.11771556
Kotlin version: 1.9.23

code sample to reproduce:

var isSheetVisible by remember {
    mutableStateOf(false)
}
val sheetState = rememberModalBottomSheetState()
val scope = rememberCoroutineScope()

Button(onClick = { isSheetVisible = true }) {
    Text("Show modal bottom sheet")
}

if (isSheetVisible) {
    ModalBottomSheet(
        sheetState = sheetState,
        onDismissRequest = {
            scope
                .launch { sheetState.hide() }
                .invokeOnCompletion {
                    isSheetVisible = false
                }
        },
        content = {
            Text(
                "This is a modal bottom sheet",
                modifier = Modifier.fillMaxSize()
            )
        }
    )
}

Screenshot 2024-05-02 at 13.19.55.png

19 KB

View

Download

Screenshot 2024-05-02 at 13.20.05.png

23 KB

View

Download

Comments

se...@google.com <se...@google.com> May 2, 2024 02:11PM

Reassigned to se...@google.com.

pe...@gmail.com <pe...@gmail.com> #2May 6, 2024 07:38PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

64...@gmail.com <64...@gmail.com> #3May 7, 2024 10:52AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

se...@google.com <se...@google.com> May 10, 2024 02:10PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #4May 13, 2024 06:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6408e12a00fe573586bf1f052317ad7a4868e8a3
Author: Jose Figueroa <serniebanders@google.com>
Date: Fri May 10 10:17:32 2024

Update status and nav bar icons to respond to system dark theme status.

Note: new style res have been moved under androidMain

Bug: 338342149
Test: Manual
Relnote: ModalBottomSheet status and nav bar icons now respond to dark theme status
Change-Id: Ie1fe7e1f792c39d52b4d419a08209c2577bf1175

M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/res/values-v30/styles.xml
M compose/material3/material3/src/androidMain/res/values/styles.xml

https://android-review.googlesource.com/3079589

se...@google.com <se...@google.com> #5May 13, 2024 06:50PM

Marked as fixed.

The updated fix here has the sheet dialog respond to system dark theme to toggle between light and dark icons. Because the dialog provides a new window it does not respect an applications theme unfortunately. Down the line we hope to split the window and sheet logic so users can customize this more thoroughly.

na...@google.com <na...@google.com> #6May 29, 2024 06:05PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.3.0-beta02
androidx.compose.material3:material3-android:1.3.0-beta02
androidx.compose.material3:material3-desktop:1.3.0-beta02

64...@gmail.com <64...@gmail.com> #7Jun 5, 2024 04:15PM

thanks for the fix!

gi...@spotify.com <gi...@spotify.com> #8Sep 24, 2024 02:51PM

The fix introduced a new bug. In our app, we don't use the night mode and only have one dark theme. After upgrading to 1.3.0, whenever a bottom sheet is opened, the navigation bar turns bright, instead of staying dark. It might be better to decide, if a dark theme is used by using the current colorScheme instead of the system's night mode.