Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Thanks for bringing this to our attention, this is definitely not intended behavior, we'll try and get a fix for it out soon.
da...@google.com <da...@google.com>
pr...@google.com <pr...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
Author: elifbilgin <
Link:
Supporting ByteBuffer in non-Android & non-JVM platforms.
Expand for full commit details
Supporting ByteBuffer in non-Android & non-JVM platforms.
Since ByteBuffer is a JVM-only API, it was erroneously used in generated code in non-JVM platforms. It has been replaced altogether with a new ByteArrayWrapper class which holds a byte array and replaces the use of a ByteBuffer by implementing equals() and hashcode().
Bug: 367205685
Test: BaseQueryTest
Relnote: Create internal ByteArrayWrapper class to support Relations with ByteBuffer in non-Android & non-JVM platforms.
Change-Id: I755433b8d624c88a6d645d40cf845d9bd3123398
Files:
- M
room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseQueryTest.kt
- M
room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/SampleDatabase.kt
- M
room/room-compiler/src/main/kotlin/androidx/room/ext/xpoet_ext.kt
- M
room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
- A
room/room-compiler/src/main/kotlin/androidx/room/solver/types/ByteArrayWrapperColumnTypeAdapter.kt
- M
room/room-compiler/src/main/kotlin/androidx/room/vo/RelationCollector.kt
- M
room/room-compiler/src/test/test-data/kotlinCodeGen/relations_byteBufferKey.kt
- M
room/room-runtime/api/restricted_current.txt
- M
room/room-runtime/bcv/native/current.txt
- A
room/room-runtime/src/androidUnitTest/kotlin/androidx/room/util/ByteArrayWrapperTest.kt
- A
room/room-runtime/src/commonMain/kotlin/androidx/room/util/ByteArrayWrapper.kt
Hash: c5fc6b2da2301441f4a320485d6bcd763265ce14
Date: Mon Sep 16 15:43:39 2024
Description
It could be useful to completely replace the generation of instantiateImpl() and the need to take in a factory lambda in Room's builder.