Using ChangeTransform() on a shared element Fragment transition breaks predictive back animation [339169168]

Fixed

Bug

Status Update

No update yet.

Description

ch...@beyls.net

created issue #1

May 7, 2024 04:19PM

Component used: Fragment

Version used: 1.7.0

Devices/Android versions reproduced on: Pixel 7 running Android 14

When enabling predictive back animations, the predictive back gesture now also animates transitions between fragments since Fragment 1.7.0 (in combination with the AndroidX Transition library version 1.5.0).

However, if the Fragment transition includes a shared element that uses the ChangeTransform() transition, then the animation breaks when triggered by the back gesture.

Display also ends up empty if the transition is cancelled, then both fragments are shown at the same time when navigating back. See the attached video for a demonstration.

A sample project to reproduce the issue can be cloned from:

https://github.com/cbeyls/PredictiveBackFragmentTransitionBug

Screen_recording_fragment_transition_predictive_back_bug.mp4

689 KB

Download

Comments

jb...@google.com <jb...@google.com> #2May 7, 2024 05:42PM

Status: Won't Fix (Infeasible)

Project: platform/frameworks/support
Branch: androidx-main

commit 016fab7f37837deb6e0924730ed70b81042c36db
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Jan 25 15:16:26 2022

Converting `query interceptor` related files in `room-runtime` from Java to Kotlin.

Test: N/A
Bug: 206859668
Relnote: Converting `query` related files in `room-runtime` from Java to Kotlin.
Change-Id: I92b932b1a1037c68195140ffb038f8add17d8de4

M room/room-runtime/src/main/java/androidx/room/RoomDatabase.java
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorStatement.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorOpenHelperFactory.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorProgram.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorDatabase.kt

https://android-review.googlesource.com/1960726

ch...@beyls.net <ch...@beyls.net> #3May 7, 2024 08:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit 049d12d74b775c193e641a3fd11fb4b3c5c20dc6
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Jan 25 15:37:31 2022

Converting `paging` related files in `room-runtime` from Java to Kotlin.

Test: LimitOffsetDataSourceTest.java
Bug: 206859668
Relnote: Converting `paging` related files in `room-runtime` from Java to Kotlin.
Change-Id: I82fc81469540315dbe4865ccde68396a4339dfd9

M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/main/java/androidx/room/paging/LimitOffsetDataSource.kt
M room/room-runtime/api/restricted_current.ignore
M room/room-runtime/build.gradle

https://android-review.googlesource.com/1960734

il...@google.com <il...@google.com> #4May 7, 2024 08:45PM

Status: New (reopened)

Project: platform/frameworks/support
Branch: androidx-main

commit 04773d8513b7ce6fbea263031c7618144c6e695d
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Jan 25 15:34:19 2022

Converting `util` related files in `room-runtime` from Java to Kotlin.

Test: Existing tests in Java for util/. These will be migrated later as a safe migration measure.
Bug: 206859668
Relnote: Converting `util` related files in `room-runtime` from Java to Kotlin.
Change-Id: I697ee52d9234358fd83dc8d94c66d4f2b849fc1b

M room/room-runtime/src/test/java/androidx/room/util/UUIDUtilTest.kt
M room/room-paging/src/androidTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt
M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/main/java/androidx/room/util/StringUtil.kt
M room/room-runtime/src/main/java/androidx/room/util/FileUtil.kt
M room/room-runtime/src/main/java/androidx/room/util/FtsTableInfo.kt
M room/room-runtime/src/main/java/androidx/room/util/UUIDUtil.kt
M room/room-runtime/src/main/java/androidx/room/util/CursorUtil.kt
M room/room-runtime/src/test/java/androidx/room/util/CursorUtilTest.kt
M room/room-paging/src/main/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt
M room/room-runtime/src/main/java/androidx/room/util/TableInfo.kt
M room/room-compiler/build.gradle
M room/room-runtime/api/current.txt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/vo/StringToIntListConverters.kt
M room/room-runtime/src/main/java/androidx/room/util/ViewInfo.kt
M room/room-runtime/api/public_plus_experimental_current.txt
M room/room-runtime/api/restricted_current.ignore
M room/room-runtime/src/main/java/androidx/room/util/DBUtil.kt

https://android-review.googlesource.com/1960732

jb...@google.com <jb...@google.com> May 8, 2024 04:05PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #5May 8, 2024 06:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9e87eb671143418ff2f2412dc43516582c1e775f
Author: Elif Bilgin <elifbilgin@google.com>
Date: Mon Feb 07 22:00:47 2022

Converting `invalidation tracker` related files in `room-runtime` from Java to Kotlin.

Test: BuilderTest.kt, InvalidationTrackerTest.kt, InvalidationLiveDataContainerTest.kt, ObservedTableTrackerTest.kt
Bug: 206859668
Relnote: Converting `invalidation tracker` related files in `room-runtime` from Java to Kotlin. This includes a source incompatible change for Kotlin users, which will require them to declare their `onInvalidate()` in their `Observer` to have a param of type `Set` and not `MutableSet`.
Change-Id: If2069426a29fffe312a58fcd3e116551090c0b4e

M room/room-paging/src/androidTest/kotlin/androidx/room/InvalidationTrackerExtRoomPaging.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/InvalidationTrackerTrojan.java
M room/room-paging/src/androidTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt
M room/room-runtime/api/restricted_current.txt
M room/room-common/build.gradle
M room/room-ktx/src/androidTest/java/androidx/room/CoroutineRoomCancellationTest.kt
M room/room-runtime/api/current.txt
M room/room-runtime/src/main/java/androidx/room/MultiInstanceInvalidationService.kt
M room/benchmark/src/androidTest/java/androidx/room/benchmark/InvalidationTrackerBenchmark.kt
M room/room-ktx/src/main/java/androidx/room/CoroutinesRoom.kt
M room/room-runtime/api/public_plus_experimental_current.txt
A room/room-runtime/api/current.ignore
M room/room-runtime/api/restricted_current.ignore
M room/room-paging/src/main/java/androidx/room/paging/util/ThreadSafeInvalidationObserver.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/PagingSourceTest.kt
M room/room-runtime/src/test/java/androidx/room/InvalidationTrackerTest.java
M room/room-runtime/src/test/java/androidx/room/BuilderTest.java
M room/room-runtime/src/main/java/androidx/room/InvalidationLiveDataContainer.kt
M room/room-runtime/src/main/java/androidx/room/MultiInstanceInvalidationClient.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/InvalidationTrackerExt.kt
M room/room-runtime/src/main/java/androidx/room/Room.kt
M room/room-runtime/src/test/java/androidx/room/InvalidationLiveDataContainerTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/SyncTriggersConcurrencyTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomTrackingLiveData.kt
M sqlite/integration-tests/inspection-room-testapp/src/androidTest/java/androidx/sqlite/inspection/RoomInvalidationHookTest.kt
M room/room-runtime/src/main/java/androidx/room/AutoCloser.java
M room/room-runtime/src/main/java/androidx/room/InvalidationTracker.kt
M room/room-runtime/src/test/java/androidx/room/BuilderTest_TestDatabase_Impl.java

https://android-review.googlesource.com/1976130

jb...@google.com <jb...@google.com> #6May 8, 2024 07:28PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 3267211f72168a905ff880a4e34558185dc6c313
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Apr 27 14:28:44 2022

Converting `auto closer` related files in `room-runtime` from Java to Kotlin.

Test: Existing tests
Bug: 206859668
Relnote: Converting `auto closer` related files in `room-runtime` from Java to Kotlin.
Change-Id: I6ee76590c1d110a4bb46219c126ef79177e3c975

M room/room-runtime/src/androidTest/java/androidx/room/AutoClosingRoomOpenHelperFactoryTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomDatabase.java
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelperFactory.kt
M room/room-runtime/src/main/java/androidx/room/AutoCloser.kt

https://android-review.googlesource.com/2043166

ch...@beyls.net <ch...@beyls.net> #7May 8, 2024 07:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit a6f3b46c1dd9f4f1b419462c50451a120a863232
Author: Elif Bilgin <elifbilgin@google.com>
Date: Thu Apr 14 16:25:45 2022

Converting the final set of Java files in `room-runtime` from Java to Kotlin.

Test: Existing tests
Bug: 206859668
Relnote: Converting the final set of Java files in `room-runtime` from Java to Kotlin.
Change-Id: I96c25112c3ab32f8df71c1408c8006bdae1b3b7f

M room/room-runtime/src/androidTest/java/androidx/room/AutoClosingRoomOpenHelperTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomDatabase.java
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/SQLiteCopyOpenHelperFactory.kt
M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/test/java/androidx/room/SQLiteCopyOpenHelperTest.kt
M room/room-runtime/src/main/java/androidx/room/DatabaseConfiguration.kt
M room/room-runtime/src/main/java/androidx/room/EntityInsertionAdapter.kt
M room/room-runtime/src/main/java/androidx/room/EntityDeletionOrUpdateAdapter.kt
M room/room-runtime/src/main/java/androidx/room/SQLiteCopyOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/SharedSQLiteStatement.kt
M room/room-runtime/api/current.txt
M room/room-runtime/api/public_plus_experimental_current.txt
M room/room-runtime/api/current.ignore
M room/room-runtime/src/main/java/androidx/room/ExperimentalRoomApi.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorOpenHelper.kt
M room/room-testing/src/main/java/androidx/room/testing/MigrationTestHelper.java
M room/room-runtime/api/restricted_current.ignore
M room/room-runtime/src/main/java/androidx/room/DelegatingOpenHelper.kt

https://android-review.googlesource.com/2065333

pr...@google.com <pr...@google.com> #8May 14, 2024 05:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3e34c01fd2679c1deb0d5ef4cdd76823f425a3ec
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Jan 25 15:58:34 2022

Converting all RoomDatabase related files in `room-runtime` from Java to Kotlin.

Test: Existing tests
Bug: 206859668
Relnote: Converting all RoomDatabase related files in `room-runtime` from Java to Kotlin.
Change-Id: Ie4b55827902c6ddcc4cc004de8bb5286823e9ab5

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-paging-rxjava3/src/main/java/androidx/room/paging/rxjava3/LimitOffsetRxPagingSource.kt
M room/room-runtime/src/main/java/androidx/room/TransactionExecutor.kt
M room/room-paging/src/androidTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt
M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/test/java/androidx/room/RoomSQLiteQueryTest.java
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/ListenableFuturePagingSourceTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomDatabase.kt
M room/room-ktx/src/androidTest/java/androidx/room/CoroutineRoomCancellationTest.kt
M room/room-paging-guava/src/main/java/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSource.kt
M room/room-compiler/src/test/data/databasewriter/output/ComplexDatabase.java
M room/room-ktx/src/main/java/androidx/room/RoomDatabaseExt.kt
M room/room-runtime/src/main/java/androidx/room/RoomSQLiteQuery.kt
M room/room-runtime/api/current.txt
M room/room-runtime/src/main/java/androidx/room/RoomOpenHelper.kt
M room/room-ktx/src/main/java/androidx/room/CoroutinesRoom.kt
M room/room-runtime/api/public_plus_experimental_current.txt
M room/room-runtime/api/current.ignore
M room/room-runtime/api/restricted_current.ignore
M development/build_log_simplifier/messages.ignore
M room/room-runtime/src/test/java/androidx/room/InvalidationTrackerTest.java
M room/room-runtime/src/main/java/androidx/room/AutoCloser.kt
M room/room-compiler/src/main/kotlin/androidx/room/writer/SQLiteOpenHelperWriter.kt
M room/room-ktx/src/test/java/androidx/room/CoroutinesRoomTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/AlteredTableColumnOrderTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx3PagingSourceTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomTrackingLiveData.kt
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/SampleDatabaseService.java
M room/room-testing/src/main/java/androidx/room/testing/MigrationTestHelper.java
M sqlite/integration-tests/inspection-room-testapp/src/androidTest/java/androidx/sqlite/inspection/RoomInvalidationHookTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx2PagingSourceTest.kt
M room/room-paging-rxjava2/src/main/java/androidx/room/paging/rxjava2/LimitOffsetRxPagingSource.kt
M room/room-runtime/src/main/java/androidx/room/InvalidationTracker.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/QueryInterceptorTest.kt

https://android-review.googlesource.com/1961019

pr...@google.com <pr...@google.com> #9Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.transition:transition:1.6.0-alpha01