In Progress
Status Update
Comments
ma...@google.com <ma...@google.com> #2
Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:
Please provide sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.
Expected output
What is the expected output?
Current output
What is the current output?
ma...@google.com <ma...@google.com> #3
How can you possibly need more information, i just told you the exact part of code causing the issue, and the code changes required to fix it!
Please read the description.
Expected output:
What is the expected output?
See attached "expected.webm" video in OP
Current output
What is the current output?
See attached "actual.webm" video in OP
Please read the description.
Expected output:
What is the expected output?
See attached "expected.webm" video in OP
Current output
What is the current output?
See attached "actual.webm" video in OP
bu...@google.com <bu...@google.com> #4
1. Import attached project
2. Install and run on Android 5 (Lollipop) or above
3. Click FAB and see it fall below/behind the navigation bar once the Snackbar disappear
2. Install and run on Android 5 (Lollipop) or above
3. Click FAB and see it fall below/behind the navigation bar once the Snackbar disappear
Description
AGP currently has two packages,
gradle-core
andgradle-api
. The former contains implementation details of the APIs, while the latter contains APIs only.We've been migrating to b/328665802 ), and we recommend doing so for the benchmark libraries. Looking at the codebase under the benchmark libraries, The following files would need to be changed:
gradle-api
package APIs only inbuildSrc
(see changes inThe main challenge in both files is that the
gradle-core
's LibraryExtension/ApplicationExtension classes have access to the variants, so we could do something like:However, in the
gradle-api
package,Variants
are separated fromCommonExtensions
. You access the variant instead viaLibraryAndroidComponentsExtension.onVariants{}
. I tried to make the changes myself in the benchmark library but I found it challenging to replace thevariants.configureEach
block in both files I listed above.There are also references in the codebase to b/337839571 )
com.android.build.gradle.internal.tasks.BuildAnalyzer
, which I've already opened a bug with the AGP team to make public (