Fixed
Status Update
Comments
jb...@google.com <jb...@google.com>
do...@google.com <do...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
cl...@google.com <cl...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
st...@warting.se <st...@warting.se> #4
deleted
cl...@google.com <cl...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
st...@warting.se <st...@warting.se> #6
I might be wrong, but i thought this did:
path-abempty = *( "/" segment )
path-abempty = *( "/" segment )
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 77e7bde966e9c9efc0d2f3a1afb0f697802cf57c
Author: Clara Fok <clarafok@google.com>
Date: Tue Jun 18 11:20:37 2024
Add support for empty path strings
Previously, empty strings in path arguments are not allowed since path arguments are considered as required, and Uri.getPathSegments() does not return empty strings.
However, support for empty path strings is added since empty string is a valid string value in the world of type safety apis.
Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 339481310
Relnote: "Navigation now supports navigating with empty strings in path arguments."
Change-Id: Ic5dbdd3b4786f62f4544a70b6786a269da8a37cc
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
https://android-review.googlesource.com/3136075
Branch: androidx-main
commit 77e7bde966e9c9efc0d2f3a1afb0f697802cf57c
Author: Clara Fok <clarafok@google.com>
Date: Tue Jun 18 11:20:37 2024
Add support for empty path strings
Previously, empty strings in path arguments are not allowed since path arguments are considered as required, and Uri.getPathSegments() does not return empty strings.
However, support for empty path strings is added since empty string is a valid string value in the world of type safety apis.
Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 339481310
Relnote: "Navigation now supports navigating with empty strings in path arguments."
Change-Id: Ic5dbdd3b4786f62f4544a70b6786a269da8a37cc
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
cl...@google.com <cl...@google.com> #8
Fixed internally and will be available in navigation 2.8.0-rc01
pr...@google.com <pr...@google.com> #9
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.8.0-beta04
androidx.navigation:navigation-runtime:2.8.0-beta04
Description
Version used: 2.8.0-alpha08
If passing an empty string as an safe argument the destination does not exists
@Serializable
object LoginSelector
@Serializable
data class RegisterUser(val email: String)
NavHost(
navController = navController,
startDestination = LoginSelector,
modifier = modifier
) {
composable<LoginSelector> {
Button(onClick = {
navController.navigate(RegisterUser("foo")) // Works!
}) {
Text(text = "Login1")
}
Button(onClick = {
navController.navigate(RegisterUser("")) // Doesn't work. Destination does not exists
}) {
Text(text = "Login2")
}
Button(onClick = {
navController.navigate(RegisterUser(null)) // works if making email nullable
}) {
Text(text = "Login3")
}
}
composable<RegisterUser> { backStackEntry ->
val emailLogin: RegisterUser = backStackEntry.toRoute()
Text(text =emailLogin.email)
}
}