AGP 8.4 seems to break GMD downloads on CI [339670469]

Fixed

Bug

Status Update

No update yet.

Description

ma...@whatnot.com

created issue #1

May 9, 2024 07:19PM

Hi - after upgrading to AGP 8.4 our CI baseline profiles generators started to fail on GMD download step.

* What went wrong:
Execution failed for task ':modules:benchmark:pixel6Api32Setup'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.ManagedDeviceInstrumentationTestSetupTask$ManagedDeviceSetupRunnable
   > System Image specified by pixel6Api32 does not exist.

   Try one of the following fixes:
     1. The image does not exist from google-atd for this architecture on the given apiLevel. However, other sources exist. Set systemImageSource to any of [aosp] to use.

pixel6Api32 is defined as follows:

pixel6Api32(com.android.build.api.dsl.ManagedVirtualDevice) {
  device = "Pixel 6"
  apiLevel = 32
  systemImageSource = "google-atd"
}

We're using linux-based runners on GitHub Actions. What's weird is that those build always pass locally (perhaps images are cached) and sometimes on CI (we're making sure we're not caching anything over there).

Everything seems to be working fine when switching back to 8.3.

Comments

ma...@whatnot.com <ma...@whatnot.com> #2May 10, 2024 05:25AM

As reported by Aditya on ASG Slack, the actual error is printed earlier in the build log:

The specific error is on the lines of 
Warning: Failed to fetch URL https://dl.google.com/android/repository/sys-img/aosp_atd/sys-img2-4.xml/sys-img.xml, reason: File not found
Warning: Errors during XML parse:
Warning: https://dl.google.com/android/repository/sys-img/aosp_atd/sys-img2-4.xml parsing problem. unexpected element (uri:"", local:"abi"). Expected elements are <{}vendor>,<{}translatedAbis>,<{}abis>,<{}codename>,<{}base-extension>,<{}api-level>,<{}extension-level>,<{}tag>
Warning: javax.xml.bind.UnmarshalException: unexpected element (uri:"", local:"abi"). 
Warning: Additionally, the fallback loader failed to parse the XML.

The error appears irrespective of the image, device or API level specified.

xa...@google.com <xa...@google.com> #3May 10, 2024 05:45AM

Assigned to je...@google.com.

This is due to the new XML schema introduced with Jellyfish/8.4

AGP should be bundling the right SDK Manager code as well as the proper schema file, but for some reason something is not working. I suspect it affect all system image download from AGP (though this is only used by GMD so that may limit the actual impact of the bug). We need to fix and patch this ASAP.

cc Chester and James for visibility and to help Jerome (or whomever on the AGP team will fix this.)

ad...@guardian.co.uk <ad...@guardian.co.uk> #4May 10, 2024 08:21AM

Thanks for creating the issue, Marcin! Xavier, please let me know if you need more details or logs from local and CI runs.

je...@google.com <je...@google.com> May 10, 2024 03:12PM

Reassigned to da...@google.com.

ro...@google.com <ro...@google.com> #5May 10, 2024 05:17PM

It looks like the XML file has both <abi> and <abis> tags, which is expected now after ag/26588078 (i.e. the second revision of the v4 schema), but AGP only has ag/25904066 (i.e. the initial revision of v4). This can probably be fixed by cherry-picking ag/26588078.

da...@google.com <da...@google.com> #6May 10, 2024 07:44PM

Submitted a cherry pick for the bug. ag/27301663

Message last modified on May 10, 2024 07:44PM

da...@google.com <da...@google.com> #7May 13, 2024 06:51PM

New cherrypick for a more targeted fix: ag/27323705

da...@google.com <da...@google.com> #8May 21, 2024 06:01PM

Marked as fixed.

The fix has been submitted and should be a part of the next patch.

ad...@gmail.com <ad...@gmail.com> #9May 21, 2024 06:05PM

Can confirm that 8.4.1 fixes this.

an...@sigma.software <an...@sigma.software> #10Jun 6, 2024 08:35AM

Please update AGP version in your docs:

https://developer.android.com/build/releases/gradle-plugin. I got stuck with this problem for a few days not realizing there's a patch.

an...@google.com <an...@google.com> #11Jun 10, 2024 03:52PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Jellyfish | 2023.3.1 Patch 2
Android Gradle Plugin 8.4.2

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ab...@gmail.com <ab...@gmail.com> #12Jul 8, 2024 03:54PM

https://developer.android.com/build/releases/gradle-plugin