Compose navigation bad transition when replacing current back stack or navigating too fast [339835189]

Obsolete

Bug

Status Update

No update yet.

Description

fr...@gmail.com

created issue #1

May 10, 2024 08:57PM

Component used: Navigation Version used: 2.7.7 Devices/Android versions reproduced on: Emulator API level 33

When navigating too quickly or when clearing the back stack, compose navigation does a weird expanding transition. It appears to be running a SizeTransform from 0 to the current page size, instead of going from the previous page size to the current page size. This is visually jarring and definitely not desired behavior. Looking at the source of NavHost, there's a comment that seems relevant:

In some specific cases, such as clearing your back stack by changing your start destination, AnimatedContent can contain an entry that is no longer part of visible entries since it was cleared from the back stack and is not animating. In these cases the currentEntry will be null, and in those cases, AnimatedContent will just skip attempting to transition the old entry.

Some ideas for fixing this could be:

Ensure both the current and destination composables are measured before starting the size transition. I'm not sure if this is possible.
Store the last valid size and use that instead of transitioning from 0.
Don't transition size at all in this case, start at the destination's size.
Don't transition size at all if the NavHost has a fixed size due to constraints, which I suspect is most of the time. Since I'm using this for full-page navigation, I'm using fillMaxSize() on the NavHost.

Here's some sample code that replaces the back stack with a new route, causing the weird transition:

fun navigateToRoute(route: String) {
    navController.navigate(route) {
        // Clear the whole back stack including root since we're going to replace it.
        popUpTo(navController.graph.id) {
            inclusive = true
        }
        launchSingleTop = true
    }
}

Here's a stackoverflow question that appears to be the same issue, there's a video linked in the question: https://stackoverflow.com/questions/77542610/strange-jetpack-compose-navigation-transition-behavior

Comments

il...@google.com <il...@google.com> #2May 10, 2024 11:19PM

That comment is not relevant - that case only applies if you've changed your whole graph structure midway through your app running, it has nothing to do with any navigate call.

Navigation is a wrapper around AnimatedContent, passing your transitions to it with the current screen - it does not actually run any transitions itself.

There have been some changes in Navigation 2.8 specifically around switching to SeekableTransitionState and allowing you to set the SizeTransform you want, so if you're still able to reproduce bad transitions, please include a sample project that reproduces them.

fr...@gmail.com <fr...@gmail.com> #3May 13, 2024 03:29PM

Ok, I'll try and put something together to demo the bug.

By the way, I'm trying out 2.8.0-alpha08 and the bug is still present. I'm also seeing a couple of serious new issues. I don't want to derail this bug ticket, but I'll go ahead and log them:

Lots of error logs when transitioning for FrameEvents my.package E updateAcquireFence: Did not find frame.
Transitions have significant startup lag where it appears to be dropping a lot of frames when starting. Might be related to errors.
Race condition where back stack gets in an incorrect state when rapidly adding and popping a page. I'm seeing my root page occasionally get popped instead of my page on top of the stack.

fr...@gmail.com <fr...@gmail.com> #4May 13, 2024 06:20PM

I've created a minimal reproduction case here: https://github.com/distinctdan/compose-navigation-transition-bug. The key bit is that Page 1 blocks the main thread for 1 second when the page exits. This simulates lag in our real application which uses ExoPlayer, which can sometimes block the main thread for long periods of time when tearing down.

Steps to reproduce:

Click "Page 2" to navigate to Page 2.
Click "Back" button within 1 second to navigate back to Page 1.
Observe the weird "zoom from center" transition that occurs.

In the video, I first demonstrate working navigation, where I'm waiting at least 1 second to let the main thread unblock. Then, I navigate rapidly while the main thread is blocked, which triggers the weird transition.

Screen Recording 2024-05-13 at 2.12.12 PM.mov

1.1 MB

Download

ty...@gmail.com <ty...@gmail.com> #5Jun 3, 2024 01:55PM

I ran into a similar issue with

Race condition where back stack gets in an incorrect state when rapidly adding and popping a page. I'm seeing my root page occasionally get popped instead of my page on top of the stack.

For me I had a nav graph with destination A -> B. If during this transition I used system back the screen content would not update but the nav controller stack was.

So if I did A -> B -> back during transition, the back transition did not occur and the B composable was still showing. Using system back again would finish the activity since the nav controller thinks the stack only has 1 entry.

Butttt, I then enabled predictive back in the manifest with

android:enableOnBackInvokedCallback="true"

and now it seems to work just fine

Message last modified on Jun 3, 2024 01:56PM

ty...@gmail.com <ty...@gmail.com> #6Jun 3, 2024 02:26PM

Although this only seems to work for devices that support predictive back. Pixel Fold running Android 15 beta works great, Pixel 6A running Android 13 still has the problem.

ty...@gmail.com <ty...@gmail.com> #7Jun 3, 2024 09:35PM

Updated my Pixel 6A to Android 14 and now it also works. Hopefully this is helpful..

fe...@gmail.com <fe...@gmail.com> #8Jun 6, 2024 12:08PM

I'm facing this issue too, even with the most recent beta version (2.8.0-beta02).

ty...@gmail.com <ty...@gmail.com> #9Jun 27, 2024 10:30PM

2.8.0-beta04 fixed the issues I was having :)

il...@google.com <il...@google.com> #10Jul 1, 2024 05:09PM

Status: Won't Fix (Obsolete)

That's great to hear. Please file a new issue with a sample project if you're still seeing any lingering issues after upgrading to Navigation 2.8.0-beta04 or higher.

bi...@gmail.com <bi...@gmail.com> #11Oct 8, 2024 08:34AM

Still having this exact same issue (repro repository for post #4) on 2.8.2
Also easily reproducted with a bottom NavigationBar when navigating quickly from a NavigatinoBarItem to another with

drawerNavController.runCatching {
drawerNavController.navigate(item.route) {
popUpTo(drawerNavController.graph.findStartDestination().id) {
saveState = true
}
launchSingleTop = true
restoreState = true
}
}