Changing state parameter of DateRangePicker doesn't update the current UI state [339898760]

Fixed

Bug

Status Update

No update yet.

Description

ds...@gmail.com

created issue #1

May 11, 2024 04:01PM

Jetpack Compose version: compose.material3 1.3.0-alpha06

Material Library Version (M2, M3 or Both?): M3

Material Compose component used: compose.material3

Android Studio Build: Android Studio Jellyfish | 2023.3.1

Kotlin version: 1.9.23

The below sample code uses a button to switch between two DateRangePickerStates used by a DateRangePicker. The states differ only by their selectableDates parameter where one state only allows previous dates to be selected, the other only allows future dates.

Expected behavior is that the UI instantly updates according to the selectable dates when the button state parameter is changed (i.e. the button is pressed in the example).

Actual behavior is that only those months display the selectable dates correctly that are freshly scrolled into view. The dates of the months currently visible are only updated when scrolled out of view and back again into view.

Column {
	val pastOnlyState: DateRangePickerState = rememberDateRangePickerState(
		selectableDates = object : SelectableDates {
			override fun isSelectableDate(utcTimeMillis: Long): Boolean {
				return utcTimeMillis < Clock.System.now().toEpochMilliseconds()
			}
		}
	)

	val futureOnlyState: DateRangePickerState = rememberDateRangePickerState(
		selectableDates = object : SelectableDates {
			override fun isSelectableDate(utcTimeMillis: Long): Boolean {
				return utcTimeMillis > Clock.System.now().toEpochMilliseconds()
			}
		}
	)

	var usePastOnly by remember { mutableStateOf(true) }

	Button(onClick = { usePastOnly = !usePastOnly }) {
		Text("switch to only allow ${if (usePastOnly) "future" else "past"} dates")
	}

	DateRangePicker(state = if (usePastOnly) pastOnlyState else futureOnlyState)
}

Comments

ba...@gmail.com <ba...@gmail.com> #2Jul 5, 2024 03:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit a330c0d3bcdd41326f37968a60e6084ad4a2e32c
Author: Chet Haase <chet@google.com>
Date: Wed Jul 05 07:26:46 2023

Convert APIs using PointF to use Float instead

PointF is a convenient mechanism for passing around x.y values
representing 2D points. But there are downsides, including:
- Converting to PointF: You may not have the data in PointF form
to begin with, so using an API which takes PointF requires converting
the data to that form (including allocating a PointF object every time)
- Mutability: Point structures can be mutated internally, causing
unpredictability in what that mutation means. Should the library
react to those changes? Ignore them? Do defensive copies (requiring
even more allocations)? Using primitive types like Float make the
behavior more obvious (by making the data inherently immutable).
- Allocations: Whenever we use object types, there are necessarily
allocations on the Java heap for them. This puts pressure on the GC
at both allocation and collection time. Given the amount of points
being passed around (especially at morph creation time, when curves
are being split and created), this causes a lot of PointF objects to
be allocated (even temporarily). Using Float avoids that problem.

Also fixed bug with unclosed paths causing discontinuity at the
start/end point.

Bug: 276466399
Bug: 290254314
Test: integration and unit tests pass
Relnote: PointF parameters changed to Float pairs
Change-Id: Id4705d27c7be31b26ade8186b99fffe2e2f8450e

M graphics/graphics-shapes/api/current.txt
M graphics/graphics-shapes/api/restricted_current.txt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicShapeTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonMeasureTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/RoundedPolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/ShapesTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/TestUtils.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Cubic.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/CubicShape.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FeatureMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FloatMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Morph.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/PolygonMeasure.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/RoundedPolygon.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Shapes.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Utils.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/DebugDraw.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/ShapeEditor.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/MaterialShapes.kt

https://android-review.googlesource.com/2649119

sg...@google.com <sg...@google.com> Sep 27, 2024 12:50AM

Accepted by sg...@google.com.

ap...@google.com <ap...@google.com> #3Sep 27, 2024 08:53PM

Marked as fixed.

PointF was the main (possibly only) mutability issue, marking this as fixed

na...@google.com <na...@google.com> #4Oct 16, 2024 05:48PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.graphics:graphics-shapes:1.0.0-alpha04

pr...@google.com <pr...@google.com> #5Oct 30, 2024 05:38PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.3.1
androidx.compose.material3:material3-android:1.3.1
androidx.compose.material3:material3-desktop:1.3.1

Issue 339898760