Restore state with ID exception due to failure to find destination [339908057]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

May 10, 2024 10:34PM

Repro test. Cause likely due to findDestination within restore state not searching through entire graph. (Route pattern restore delegates to id-based implementation)

    @UiThreadTest
    @Test
    fun testSaveState3() {
        val navController = createNavController()
        val graph = createNavController().createGraph(route = "root", startDestination = "graphA") {
            navigation(route = "graphA", startDestination = "A1") {
                test("A1")
                test("A2")
            }
            navigation(route = "graphB", startDestination = "B1") {
                test("B1")
            }
        }
        navController.graph = graph
        navController.navigate("A2")

        assertThat(navController.currentDestination?.route).isEqualTo("A2")

        navController.navigate("graphB") {
            popUpTo("A2") {
                inclusive = true
                saveState = true
            }
        }

        navController.navigate("A2") {
            restoreState = true
        }
    }

Note: possible duplication b/334120900, need investigation

Comments

cl...@google.com <cl...@google.com> May 15, 2024 09:33PM

Accepted by cl...@google.com.

ap...@google.com <ap...@google.com> #2May 22, 2024 10:07PM

seems to be dup: b/212982460

ap...@google.com <ap...@google.com> #3May 22, 2024 10:07PM

Fundamentally the issue here is that the selection logic happening in composition depends on the text layout result which is available on measure. So we end up using stale TextLayoutResult which causes the issue.

ap...@google.com <ap...@google.com> #4May 22, 2024 10:07PM

This is the same exception as in b/229378536 and b/221580975 as well, and it also involves selection, so I'm wondering if those two bugs have the same cause Anastasia described.

ap...@google.com <ap...@google.com> #5May 22, 2024 11:06PM

There is a similar problem regarding Magnifier but I don't think these are directly related. The main cause for this issue is the async relation between TextFieldValue and layoutResult. Magnifier related crashes don't seem to be caused by changes in TextFieldValue or layout.

cl...@google.com <cl...@google.com> #6May 22, 2024 11:28PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit c1e913cdea06ac6cf01c596000d375013f1a1d7c
Author: Halil Ozercan <halilibo@google.com>
Date: Thu Jun 23 13:51:14 2022

Fix crash when selected text is cleared by state changes and re-added later

BasicTextField's String API manages the selection and composition completely internally. Therefore, its selection value stays the same across value changes that comes from hoisted state, instead of IME commands. In a case where selected text is removed by a state change and later added, text layout result lags behind. This change makes sure that selection handles are only drawn when layout result is in sync with the latest TextFieldValue.

Fix:

b/208655565

Fix:

b/214253689

Test: CoreTextFieldSelectionContentChangeTest.kt
Relnote: Fixed a crash where TextField is cleared and refilled while selection is active.
Change-Id: I1235b669921e67dcbec9e55a6d1a95ff609fe4b6

A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldSelectionContentChangeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt

https://android-review.googlesource.com/2133687

na...@google.com <na...@google.com> #7May 29, 2024 06:05PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.8.0-beta02
androidx.navigation:navigation-runtime:2.8.0-beta02

wa...@gmail.com <wa...@gmail.com> #8Jun 8, 2024 02:59PM

I still have this issue on 2.8.0-beta02. My app systematically crashes on the initial destination, when restored from the background, with this exception:

java.lang.IllegalStateException: Restoring the Navigation back stack failed: destination 129493933 cannot be found from the current destination ComposeNavGraph(0x0) startDestination={Destination(0x7ec3ee2) route=com.brewthings.app.ui.screens.navigation.Screen.Scanning}

cl...@google.com <cl...@google.com> #9Jun 10, 2024 04:37PM

Re comment#8 can you please file a separate bug and attach a sample app?

ab...@dexcom.com <ab...@dexcom.com> #10Jun 12, 2024 01:18PM

I have the same issue on 2.8.0-beta02 when revoking app permission and the process gets Killed

il...@google.com <il...@google.com> #11Jun 12, 2024 04:47PM

Re comment#10 - please also file a new issue with a sample project that reproduces your issue.

ab...@dexcom.com <ab...@dexcom.com> #12Jul 7, 2024 04:22AM

https://issuetracker.google.com/issues/339908057#comment11
thanks fixed in
Version 2.8.0-beta04

vi...@gmail.com <vi...@gmail.com> #13Aug 1, 2024 09:11PM

Will this fix land in 2.7.x?

cl...@google.com <cl...@google.com> #14Aug 1, 2024 10:01PM

As mentioned in comment#6, it is released in navigation 2.8.0-beta02. This fix is applied to that release onwards. So it will not be fixed in 2.7.x.

Message last modified on Aug 1, 2024 10:01PM