Fixed
Status Update
Comments
cl...@google.com <cl...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ap...@google.com <ap...@google.com> #3
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 8bb1f1cb1606dc128dfc2b3995016af3d9eb5e50
Author: Clara Fok <clarafok@google.com>
Date: Wed May 15 11:22:18 2024
Fix restoreState that is based on id
Id based savedState restoration searches for target destination by recursing up the parents. This mean you cannot directly restore a nested destination in a sibling graph.
This isn’t an issue in a strictly id-based world since you cannot navigate directly to a sibling graph to begin with.
However, these route based restoration delegates to id-based restoration:
Route pattern
Route from KClass
Given that route APIs allow navigation to sibling graphs directly, it should also allow restore state from sibling graphs. We add support for this by searching for the target dest by recursing through both the parents and its children.
Since clearBackStack eventually delegates to restore state, this change also fixes these route based clearBackStack that delegates to id implementation:
Route pattern
Route from KClass
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 339908057
Relnote: "Fixed NavController state restoration crash during operations such as clearBackStackEntry."
Change-Id: I423c3f6d8ee27be46450dcb53c28272fe0a1e085
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
https://android-review.googlesource.com/3089428
Branch: androidx-main
commit 8bb1f1cb1606dc128dfc2b3995016af3d9eb5e50
Author: Clara Fok <clarafok@google.com>
Date: Wed May 15 11:22:18 2024
Fix restoreState that is based on id
Id based savedState restoration searches for target destination by recursing up the parents. This mean you cannot directly restore a nested destination in a sibling graph.
This isn’t an issue in a strictly id-based world since you cannot navigate directly to a sibling graph to begin with.
However, these route based restoration delegates to id-based restoration:
Route pattern
Route from KClass
Given that route APIs allow navigation to sibling graphs directly, it should also allow restore state from sibling graphs. We add support for this by searching for the target dest by recursing through both the parents and its children.
Since clearBackStack eventually delegates to restore state, this change also fixes these route based clearBackStack that delegates to id implementation:
Route pattern
Route from KClass
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 339908057
Relnote: "Fixed NavController state restoration crash during operations such as clearBackStackEntry."
Change-Id: I423c3f6d8ee27be46450dcb53c28272fe0a1e085
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
cl...@google.com <cl...@google.com> #6
Fixed internally and will be available in navigation 2.8.0-beta02
.
na...@google.com <na...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.8.0-beta02
androidx.navigation:navigation-runtime:2.8.0-beta02
wa...@gmail.com <wa...@gmail.com> #8
I still have this issue on 2.8.0-beta02
. My app systematically crashes on the initial destination, when restored from the background, with this exception:
java.lang.IllegalStateException: Restoring the Navigation back stack failed: destination 129493933 cannot be found from the current destination ComposeNavGraph(0x0) startDestination={Destination(0x7ec3ee2) route=com.brewthings.app.ui.screens.navigation.Screen.Scanning}
ab...@dexcom.com <ab...@dexcom.com> #10
I have the same issue on 2.8.0-beta02 when revoking app permission and the process gets Killed
il...@google.com <il...@google.com> #11
Re
vi...@gmail.com <vi...@gmail.com> #13
Will this fix land in 2.7.x?
Description
Repro test. Cause likely due to findDestination within restore state not searching through entire graph. (Route pattern restore delegates to id-based implementation)
Note: possible duplication b/334120900 , need investigation