Restore state with ID exception due to failure to find destination [339908057]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

May 10, 2024 10:34PM

Repro test. Cause likely due to findDestination within restore state not searching through entire graph. (Route pattern restore delegates to id-based implementation)

    @UiThreadTest
    @Test
    fun testSaveState3() {
        val navController = createNavController()
        val graph = createNavController().createGraph(route = "root", startDestination = "graphA") {
            navigation(route = "graphA", startDestination = "A1") {
                test("A1")
                test("A2")
            }
            navigation(route = "graphB", startDestination = "B1") {
                test("B1")
            }
        }
        navController.graph = graph
        navController.navigate("A2")

        assertThat(navController.currentDestination?.route).isEqualTo("A2")

        navController.navigate("graphB") {
            popUpTo("A2") {
                inclusive = true
                saveState = true
            }
        }

        navController.navigate("A2") {
            restoreState = true
        }
    }

Note: possible duplication b/334120900, need investigation

Comments

cl...@google.com <cl...@google.com> May 15, 2024 09:33PM

Accepted by cl...@google.com.

ap...@google.com <ap...@google.com> #2May 22, 2024 10:07PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ap...@google.com <ap...@google.com> #3May 22, 2024 10:07PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ap...@google.com <ap...@google.com> #4May 22, 2024 10:07PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ap...@google.com <ap...@google.com> #5May 22, 2024 11:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8bb1f1cb1606dc128dfc2b3995016af3d9eb5e50
Author: Clara Fok <clarafok@google.com>
Date: Wed May 15 11:22:18 2024

Fix restoreState that is based on id

Id based savedState restoration searches for target destination by recursing up the parents. This mean you cannot directly restore a nested destination in a sibling graph.
This isn’t an issue in a strictly id-based world since you cannot navigate directly to a sibling graph to begin with.

However, these route based restoration delegates to id-based restoration:
Route pattern
Route from KClass

Given that route APIs allow navigation to sibling graphs directly, it should also allow restore state from sibling graphs. We add support for this by searching for the target dest by recursing through both the parents and its children.

Since clearBackStack eventually delegates to restore state, this change also fixes these route based clearBackStack that delegates to id implementation:
Route pattern
Route from KClass

Test: ./gradlew navigation:navigation-runtime:cC
Bug: 339908057
Relnote: "Fixed NavController state restoration crash during operations such as clearBackStackEntry."
Change-Id: I423c3f6d8ee27be46450dcb53c28272fe0a1e085

M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/3089428

cl...@google.com <cl...@google.com> #6May 22, 2024 11:28PM

Marked as fixed.

Fixed internally and will be available in navigation 2.8.0-beta02.

na...@google.com <na...@google.com> #7May 29, 2024 06:05PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.8.0-beta02
androidx.navigation:navigation-runtime:2.8.0-beta02

wa...@gmail.com <wa...@gmail.com> #8Jun 8, 2024 02:59PM

I still have this issue on 2.8.0-beta02. My app systematically crashes on the initial destination, when restored from the background, with this exception:

java.lang.IllegalStateException: Restoring the Navigation back stack failed: destination 129493933 cannot be found from the current destination ComposeNavGraph(0x0) startDestination={Destination(0x7ec3ee2) route=com.brewthings.app.ui.screens.navigation.Screen.Scanning}

cl...@google.com <cl...@google.com> #9Jun 10, 2024 04:37PM

Re comment#8 can you please file a separate bug and attach a sample app?

ab...@dexcom.com <ab...@dexcom.com> #10Jun 12, 2024 01:18PM

I have the same issue on 2.8.0-beta02 when revoking app permission and the process gets Killed

il...@google.com <il...@google.com> #11Jun 12, 2024 04:47PM

Re comment#10 - please also file a new issue with a sample project that reproduces your issue.

ab...@dexcom.com <ab...@dexcom.com> #12Jul 7, 2024 04:22AM

https://issuetracker.google.com/issues/339908057#comment11
thanks fixed in
Version 2.8.0-beta04

vi...@gmail.com <vi...@gmail.com> #13Aug 1, 2024 09:11PM

Will this fix land in 2.7.x?

cl...@google.com <cl...@google.com> #14Aug 1, 2024 10:01PM

As mentioned in comment#6, it is released in navigation 2.8.0-beta02. This fix is applied to that release onwards. So it will not be fixed in 2.7.x.

Message last modified on Aug 1, 2024 10:01PM