Fixed
Status Update
Comments
lp...@google.com <lp...@google.com> #2
Howdy it's jb, who the fuck is this
nj...@google.com <nj...@google.com> #3
Can you provide the below requested information to better understand the issue:
Steps to reproduce
Please provide a sample application or apk to reproduce the issue.
Also kindly mention the steps to be followed for reproducing the issue with the given sample application.
Expected output
Could you please explain the expected behavior.
Current output
Could you please explain the current behavior.
Steps to reproduce
Please provide a sample application or apk to reproduce the issue.
Also kindly mention the steps to be followed for reproducing the issue with the given sample application.
Expected output
Could you please explain the expected behavior.
Current output
Could you please explain the current behavior.
ap...@google.com <ap...@google.com> #4
Please provide the information as requested in comment #3 , For us to further investigate this issue.
na...@google.com <na...@google.com> #5
Please find attached a simple testcase.
Steps to reproduce:
- Run the application
- Click on the Button
Expected output
- The Feature 1 activity is shown
Current output
- The Chooser activity is briefly shown
- The Feature 1 activity is shown
Steps to reproduce:
- Run the application
- Click on the Button
Expected output
- The Feature 1 activity is shown
Current output
- The Chooser activity is briefly shown
- The Feature 1 activity is shown
Description
See: b/336270922
Currently Modifier.drawWithCache queries the current density and layout direction from
DelegatableNode#requireDensity
andDelegatableNode#requireLayoutDirection
. However, LayoutNode currently does not broadcast changes back to the modifier chain whenever the density or layout direction change. That leads to issues where Modifier.drawWithCache does not update based on the latest density/layout direction that was available.There is already prior art that special cases PointerInput modifiers to receive updates to density/layoutdirection changes and the fix for b/336270922 does the same for Modifier.drawWithCache. This is because at the time b/336270922 was addressed, API changes to add APIs to DelegatableNode are disallowed. So introduce a stopgap solution to fix the bug now and introduce a more holistic solution going forward.
Discussions with the wider team in the Modifier task force group lead to consensus that introducinghttps://chat.google.com/room/AAAAbSAVMlo/m_-HpV0vl1o
DelegateableNode#onLayoutDirectionChanged
andDelegatabelNode#onDensityChanged
would be a preferable longer term solution. See: