Add onDensityChanged/onLayoutDirectionChanged APIs to DelegatableNode [340662451]

Fixed

Bug

Status Update

No update yet.

Description

nj...@google.com

created issue #1

May 14, 2024 11:09PM

See: b/336270922

Currently Modifier.drawWithCache queries the current density and layout direction from DelegatableNode#requireDensity and DelegatableNode#requireLayoutDirection. However, LayoutNode currently does not broadcast changes back to the modifier chain whenever the density or layout direction change. That leads to issues where Modifier.drawWithCache does not update based on the latest density/layout direction that was available.

There is already prior art that special cases PointerInput modifiers to receive updates to density/layoutdirection changes and the fix for b/336270922 does the same for Modifier.drawWithCache. This is because at the time b/336270922 was addressed, API changes to add APIs to DelegatableNode are disallowed. So introduce a stopgap solution to fix the bug now and introduce a more holistic solution going forward.

Discussions with the wider team in the Modifier task force group lead to consensus that introducing DelegateableNode#onLayoutDirectionChanged and DelegatabelNode#onDensityChanged would be a preferable longer term solution. See: https://chat.google.com/room/AAAAbSAVMlo/m_-HpV0vl1o

Comments

lp...@google.com <lp...@google.com> #2Oct 8, 2024 10:36PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

nj...@google.com <nj...@google.com> #3Oct 8, 2024 10:37PM

Reassigned to lp...@google.com.

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

ap...@google.com <ap...@google.com> #4Oct 9, 2024 05:04PM

Marked as fixed.

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

na...@google.com <na...@google.com> #5Oct 16, 2024 05:48PM

deleted

Issue 340662451

Description

Issue summary

Comments

lp...@google.com <lp...@google.com> #2Oct 8, 2024 10:36PM

nj...@google.com <nj...@google.com> #3Oct 8, 2024 10:37PM

ap...@google.com <ap...@google.com> #4Oct 9, 2024 05:04PM

na...@google.com <na...@google.com> #5Oct 16, 2024 05:48PM

Add comment

Issue metadata