Status Update
Comments
lp...@google.com <lp...@google.com> #2
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
nj...@google.com <nj...@google.com> #3
Tested on Android 12 Emulator with custom executor, but cannot repro this issue.
ap...@google.com <ap...@google.com> #4
-
Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
-
Dynamic features are not used in the application.
As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.
na...@google.com <na...@google.com> #5
Hmm, I feel the crash might be something related to separate/secondary process.
I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.
Description
See: b/336270922
Currently Modifier.drawWithCache queries the current density and layout direction from
DelegatableNode#requireDensity
andDelegatableNode#requireLayoutDirection
. However, LayoutNode currently does not broadcast changes back to the modifier chain whenever the density or layout direction change. That leads to issues where Modifier.drawWithCache does not update based on the latest density/layout direction that was available.There is already prior art that special cases PointerInput modifiers to receive updates to density/layoutdirection changes and the fix for b/336270922 does the same for Modifier.drawWithCache. This is because at the time b/336270922 was addressed, API changes to add APIs to DelegatableNode are disallowed. So introduce a stopgap solution to fix the bug now and introduce a more holistic solution going forward.
Discussions with the wider team in the Modifier task force group lead to consensus that introducinghttps://chat.google.com/room/AAAAbSAVMlo/m_-HpV0vl1o
DelegateableNode#onLayoutDirectionChanged
andDelegatabelNode#onDensityChanged
would be a preferable longer term solution. See: