Status Update
No update yet.
Comments
da...@google.com
Connie, do you think we can just remove it? And recommend ModalBottomSheet or BottomSheetScaffold instead?
ib...@gmail.com
da...@google.com
I think it's worth noting in M2 that ModalBottomSheet is a layout while bottomdrawer functions more as a truly modal object, even though it does not have perfect dialog-like functionality. For the usecase recommended (bottom app bar menus), BottomDrawer seems like a better fit than ModalBottomSheetLayout. However in M3 it makes sense to explicitly use ModalBottomSheet once implemented.
Wdyt Matvei?
ib...@gmail.com
I think it's worth noting in M2 that ModalBottomSheet is a layout while bottomdrawer functions more as a truly modal object
Could you comment on that? What's the actual difference in the behaviour?
da...@google.com
Bottom Drawer is an atomic component that can be placed on top of content on the screen while ModalBottomSheet is a layout that wraps around all the screen content and places accordingly. BottomDrawer is much more of a splashable component in M2 and asking users to migrate BottomDrawer uses may be cumbersome.
ap...@google.com
Ok, sounds good. I'm happy to keep it if you think it brings value to m2 users.
If we are not removing it, we need to make it stable in this case.
da...@google.com
ap...@google.com
Found some outstanding bugs I will look into before deciding to promote, especially the swipeable migrations which will likely update the API
pr...@google.com
Given the planned work to migrate the swipeable logic of bottomdrawer, this API should remain experimental. Closing for now.
ib...@gmail.com
If these are still experimental, please keep this bug open and just target the next release
da...@google.com
Where can i find the respective hotlist for the next release?
ap...@google.com
Fwiw the major difference between modal sheets and bottom drawer is that the drawer can be opened by swiping on the full container. If we don't intend to introduce a bottom drawer in M3, maybe we can explore how to adapt the ModalBottomSheet API for this feature in the future.
da...@google.com
na...@google.com
Bumping to P1 as it is been a long while since we need to land this.
Description
Version used: 2.5.0-alpha02
Devices/Android versions reproduced on: Pixel 6
I tried to migrate from
2024-05-16 11:41:26.367 30919-30967 libc org.btcmap.debug A Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x8000004300003b in tid 30967 (DefaultDispatch), pid 30919 (rg.btcmap.debug)
2024-05-16 11:41:26.662 31039-31039 DEBUG pid-31039 A Cmdline: org.btcmap.debug
2024-05-16 11:41:26.662 31039-31039 DEBUG pid-31039 A pid: 30919, tid: 30967, name: DefaultDispatch >>> org.btcmap.debug <<<
2024-05-16 11:41:26.662 31039-31039 DEBUG pid-31039 A #00 pc 00000000000cb30c /data/app/~~98VGkyL4jH13WZ5B1K-MmQ==/org.btcmap.debug-MmWOzd6cam3KXcL8NYi-uA==/base.apk!libsqliteJni.so (offset 0x930000)
The app itself is open source and it doesn't need any extra setup, you can easily reproduce it by launching it in the emulator or on a real device. Usually it crashes before moving the map, but it will crash for sure if you start moving the map, since it triggers a few queries.
It's possible that I messed up a few queries during that transition, but I don't think it should cause crashes, and it can surely be more specific on where it's failing and why