Status Update
No update yet.
Comments
da...@google.com
<transition xmlns:android="
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>
where blue/green drawables look like this:
<shape
xmlns:android="
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>
Then added this test:
@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);
Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}
It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.
ib...@gmail.com
da...@google.com
ib...@gmail.com
Ah, I see, thanks for clarification. I was confused by this line:
The default mode is serialized. (
https://www.sqlite.org/threadsafe.html )
So I assumed that it's perfectly safe to share the connection between the IO thread pool, but it seems like it's not the case for androidx.sqlite:sqlite-bundled. Any specific reason for overriding the defaults? Using the safest option by default while also allowing runtime overrides seems like a good idea
da...@google.com
We compile with the multi-thread flag for performance reasons as Room has an internal connection pool.
I have a change that adds an overload to open() such that open flags can be passed, including SQLITE_OPEN_FULLMUTEX which will enable serialized mode for the connection, see
ap...@google.com
Branch: androidx-main
commit 70731ee26381fb7a93cbfd3b822f35f14a75a5b1
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu May 30 11:45:50 2024
Add an open() overload that receives open flags to bundled driver.
Bug: 307917398
Bug: 340949940
Test: BaseBundledConformanceTest
Relnote: Add an open() overload API to BundledSQLiteDriver to pass open flags when opening a database connection. Useful for opening a database in read-only mode or using the serialized thread safe mode instead of the multi-thread mode bundled SQLite is compiled with.
Change-Id: I1ae858f70db811c9e08aeb0c171a20a2f9e2a28c
M sqlite/integration-tests/driver-conformance-test/build.gradle
M sqlite/integration-tests/driver-conformance-test/src/androidInstrumentedTest/kotlin/androidx/sqlite/driver/test/BundledSQLiteDriverTest.kt
M sqlite/integration-tests/driver-conformance-test/src/commonTest/kotlin/androidx/sqlite/driver/test/BaseBundledConformanceTest.kt
M sqlite/integration-tests/driver-conformance-test/src/jvmTest/kotlin/androidx/sqlite/driver/test/BundledSQLiteDriverTest.kt
M sqlite/integration-tests/driver-conformance-test/src/nativeTest/kotlin/androidx/sqlite/driver/test/BundledSQLiteDriverTest.kt
M sqlite/sqlite-bundled/api/api_lint.ignore
M sqlite/sqlite-bundled/api/current.txt
M sqlite/sqlite-bundled/api/restricted_current.txt
M sqlite/sqlite-bundled/src/androidJvmCommonMain/jni/sqlite_bindings.cpp
M sqlite/sqlite-bundled/src/androidJvmCommonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLite.androidJvmCommon.kt
M sqlite/sqlite-bundled/src/androidJvmCommonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteDriver.androidJvmCommon.kt
A sqlite/sqlite-bundled/src/commonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLite.kt
M sqlite/sqlite-bundled/src/commonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteDriver.kt
A sqlite/sqlite-bundled/src/nativeMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLite.nativeCommon.kt
M sqlite/sqlite-framework/src/nativeMain/kotlin/androidx/sqlite/driver/NativeSQLite.kt
M sqlite/sqlite-framework/src/nativeMain/kotlin/androidx/sqlite/driver/NativeSQLiteDriver.kt
da...@google.com
ap...@google.com
Branch: androidx-main
commit 379e8f8049ea93808f284c4b46b83e9692f3d2d7
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu May 30 11:45:50 2024
Add an open() overload that receives open flags to bundled driver.
Bug: 307917398
Bug: 340949940
Test: BaseBundledConformanceTest
Relnote: Add an open() overload API to BundledSQLiteDriver to pass open flags when opening a database connection. Useful for opening a database in read-only mode or using the serialized thread safe mode instead of the multi-thread mode bundled SQLite is compiled with.
Change-Id: I1fe0e1a85ff555a7950165eefe0aa0301ad05a94
M sqlite/integration-tests/driver-conformance-test/build.gradle
M sqlite/integration-tests/driver-conformance-test/src/androidInstrumentedTest/kotlin/androidx/sqlite/driver/test/BundledSQLiteDriverTest.kt
M sqlite/integration-tests/driver-conformance-test/src/commonTest/kotlin/androidx/sqlite/driver/test/BaseBundledConformanceTest.kt
M sqlite/integration-tests/driver-conformance-test/src/jvmTest/kotlin/androidx/sqlite/driver/test/BundledSQLiteDriverTest.kt
M sqlite/integration-tests/driver-conformance-test/src/nativeTest/kotlin/androidx/sqlite/driver/test/BundledSQLiteDriverTest.kt
M sqlite/sqlite-bundled/api/api_lint.ignore
M sqlite/sqlite-bundled/api/current.txt
M sqlite/sqlite-bundled/api/restricted_current.txt
M sqlite/sqlite-bundled/src/androidJvmCommonMain/jni/sqlite_bindings.cpp
M sqlite/sqlite-bundled/src/androidJvmCommonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLite.androidJvmCommon.kt
M sqlite/sqlite-bundled/src/androidJvmCommonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteDriver.androidJvmCommon.kt
A sqlite/sqlite-bundled/src/commonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLite.kt
M sqlite/sqlite-bundled/src/commonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteDriver.kt
A sqlite/sqlite-bundled/src/nativeMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLite.nativeCommon.kt
M sqlite/sqlite-framework/src/nativeMain/kotlin/androidx/sqlite/driver/NativeSQLite.kt
M sqlite/sqlite-framework/src/nativeMain/kotlin/androidx/sqlite/driver/NativeSQLiteDriver.kt
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.sqlite:sqlite-framework-iosarm64:2.5.0-alpha04androidx.sqlite:sqlite-framework-iossimulatorarm64:2.5.0-alpha04androidx.sqlite:sqlite-framework-iosx64:2.5.0-alpha04androidx.sqlite:sqlite-framework-linuxx64:2.5.0-alpha04androidx.sqlite:sqlite-framework-macosarm64:2.5.0-alpha04androidx.sqlite:sqlite-framework-macosx64:2.5.0-alpha04
ib...@gmail.com
I just tested this new flag and it looks like the issue still persists. It's easily reproducible since the repo is open source:
So default open() passes SQLITE_OPEN_READWRITE or SQLITE_OPEN_CREATE flags, and I changed it to SQLITE_OPEN_READWRITE or SQLITE_OPEN_CREATE or SQLITE_OPEN_FULLMUTEX
The database works fine after that change, but when I tried to disable the global connection lock (connLock variable) in the same file, the app started to crash with "android.database.SQLException: Error code: 21, message: no row"
android.database.SQLException: Error code: 21, message: no row
at androidx.sqlite.driver.bundled.BundledSQLiteStatementKt.nativeGetLong(Native Method)
at androidx.sqlite.driver.bundled.BundledSQLiteStatementKt.access$nativeGetLong(BundledSQLiteStatement.jvmAndroid.kt:1)
at androidx.sqlite.driver.bundled.BundledSQLiteStatement.getLong(BundledSQLiteStatement.jvmAndroid.kt:70)
at element.ElementQueries$selectClusters$1.invoke(ElementQueries.kt:271)
da...@google.com
The flags are working as expected, but looks like the issue is in our JNI implementation, specifically we use sqlite3_errcode to get the 'last result code' and that is dangerous since it is a connection level API and if the connection is being used concurrently the 'last result code' of a statement might be from a different statement being executed, in other words we need to localize the 'last result code' per statement. I'll work on a fix. Again, I appreciate the feedback and you trying out the driver.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <
Link:
Use sqlite3_stmt_busy to check if there are rows in a statement.
Expand for full commit details
Use sqlite3_stmt_busy to check if there are rows in a statement.
Instead of using 'sqlite3_errcode(db) == SQLITE_ROW' to check if a statement is in a row and ready to read columns, use sqlite3_stmt_busy as that API is local to the statement and avoids the risk of sqlite3_errcode that works on a database connection returning a result code that is irrelevant to the statement when the connection is being used concurrently.
Bug: 340949940
Test: BaseBundledConformanceTest.openWithFullMutexFlag
Change-Id: If02039b90c6415a7532ae94f1c99e1182b546db8
Files:
- M
sqlite/integration-tests/driver-conformance-test/src/commonTest/kotlin/androidx/sqlite/driver/test/BaseBundledConformanceTest.kt - M
sqlite/sqlite-bundled/src/jvmAndroidMain/jni/sqlite_bindings.cpp - M
sqlite/sqlite-framework/src/nativeMain/kotlin/androidx/sqlite/driver/NativeSQLiteStatement.kt
Hash: 5885a89d74a47b73d2e05abefc979279b85c14fe
Date: Wed Sep 25 12:13:07 2024
da...@google.com
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.sqlite:sqlite-bundled-iossimulatorarm64:2.5.0-alpha10androidx.sqlite:sqlite-bundled-iosx64:2.5.0-alpha10androidx.sqlite:sqlite-bundled-jvm:2.5.0-alpha10androidx.sqlite:sqlite-bundled-linuxarm64:2.5.0-alpha10androidx.sqlite:sqlite-bundled-linuxx64:2.5.0-alpha10androidx.sqlite:sqlite-bundled-macosarm64:2.5.0-alpha10androidx.sqlite:sqlite-bundled-macosx64:2.5.0-alpha10androidx.sqlite:sqlite-framework:2.5.0-alpha10androidx.sqlite:sqlite-framework-android:2.5.0-alpha10androidx.sqlite:sqlite-framework-iosarm64:2.5.0-alpha10androidx.sqlite:sqlite-framework-iossimulatorarm64:2.5.0-alpha10androidx.sqlite:sqlite-framework-iosx64:2.5.0-alpha10androidx.sqlite:sqlite-framework-linuxarm64:2.5.0-alpha10androidx.sqlite:sqlite-framework-linuxx64:2.5.0-alpha10androidx.sqlite:sqlite-framework-macosarm64:2.5.0-alpha10androidx.sqlite:sqlite-framework-macosx64:2.5.0-alpha10
Description
Version used: 2.5.0-alpha02
Devices/Android versions reproduced on: Pixel 6
I tried to migrate from
2024-05-16 11:41:26.367 30919-30967 libc org.btcmap.debug A Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x8000004300003b in tid 30967 (DefaultDispatch), pid 30919 (rg.btcmap.debug)
2024-05-16 11:41:26.662 31039-31039 DEBUG pid-31039 A Cmdline: org.btcmap.debug
2024-05-16 11:41:26.662 31039-31039 DEBUG pid-31039 A pid: 30919, tid: 30967, name: DefaultDispatch >>> org.btcmap.debug <<<
2024-05-16 11:41:26.662 31039-31039 DEBUG pid-31039 A #00 pc 00000000000cb30c /data/app/~~98VGkyL4jH13WZ5B1K-MmQ==/org.btcmap.debug-MmWOzd6cam3KXcL8NYi-uA==/base.apk!libsqliteJni.so (offset 0x930000)
The app itself is open source and it doesn't need any extra setup, you can easily reproduce it by launching it in the emulator or on a real device. Usually it crashes before moving the map, but it will crash for sure if you start moving the map, since it triggers a few queries.
It's possible that I messed up a few queries during that transition, but I don't think it should cause crashes, and it can surely be more specific on where it's failing and why