[Koala 2024.1.2 Canary 2] Error running a baseline profile module on a split APK [341266993]

Fixed

Bug

Status Update

No update yet.

Description

pu...@gmail.com

created issue #1

May 17, 2024 07:30PM

Build: AI-241.15989.150.2412.11851376, 202405161915
AS: Koala Feature Drop | 2024.1.2 Canary 2
AI-241.15989.150.2412.11851376, JRE 17.0.10+0-17.0.10b1087.21-11609105x64 JetBrains s.r.o., OS Linux(amd64) v6.8.9-1-default, screens 9600.0x5400.0
Android Gradle Plugin: 8.6.0-alpha02
Gradle: 8.7
Gradle JDK: 17.0.11
NDK: from local.properties: (not specified), latest from SDK: 22.0.7026061
CMake: from local.properties: (not specified), latest from SDK: 3.10.2, from PATH: 3.29.3

My Android project uses split APKs. That is, its build.gradle contain a section:

 splits {
        abi {
         enable false
         reset()
         include "armeabi-v7a", "arm64-v8a", "x86", "x86_64"
         universalApk true
        }
    }

I have used the new Baseline profile generator template to generate a baseline module. When I try to run it, it fails on APK installation (project names redacted):

Exception thrown during onBeforeAll invocation of plugin AndroidTestApkInstallerPlugin: ErrorName: INSTALL_FAILED_INVALID_APK
NameSpace: DdmlibAndroidDeviceController
ErrorCode: 1
ErrorType: TEST
Message: Failed to install split APK(s): [/home/bobbie/workspace/<redacted>/build/outputs/apk/<redacted>/nonMinifiedRelease/<redacted>-<redacted>-universal-nonMinifiedRelease.apk, /home/bobbie/workspace/<redacted>/build/outputs/apk/<redacted>/nonMinifiedRelease/<redacted>-<redacted>-arm64-v8a-nonMinifiedRelease.apk, /home/bobbie/workspace/<redacted>/build/outputs/apk/<redacted>/nonMinifiedRelease/<redacted>-<redacted>-x86-nonMinifiedRelease.apk, /home/bobbie/workspace/<redacted>/build/outputs/apk/<redacted>/nonMinifiedRelease/<redacted>-<redacted>-x86_64-nonMinifiedRelease.apk, /home/bobbie/workspace/<redacted>/build/outputs/apk/<redacted>/nonMinifiedRelease/<redacted>-<redacted>-armeabi-v7a-nonMinifiedRelease.apk]
Failed to install split APK(s): [/home/bobbie/workspace/<redacted>/build/outputs/apk/<redacted>/nonMinifiedRelease/<redacted>-<redacted>-universal-nonMinifiedRelease.apk, /home/bobbie/workspace/<redacted>/build/outputs/apk/<redacted>/nonMinifiedRelease/<redacted>-<redacted>-arm64-v8a-nonMinifiedRelease.apk, /home/bobbie/workspace/<redacted>/build/outputs/apk/<redacted>/nonMinifiedRelease/<redacted>-<redacted>-x86-nonMinifiedRelease.apk, /home/bobbie/workspace/<redacted>/build/outputs/apk/<redacted>/nonMinifiedRelease/<redacted>-<redacted>-x86_64-nonMinifiedRelease.apk, /home/bobbie/workspace/<redacted>/build/outputs/apk/<redacted>/nonMinifiedRelease/<redacted>-<redacted>-armeabi-v7a-nonMinifiedRelease.apk]
Failed to commit install session 1567062047 with command package install-commit 1567062047. Error: INSTALL_FAILED_INVALID_APK: Split null was defined multiple times
com.android.ddmlib.InstallException: Failed to commit install session 1567062047 with command package install-commit 1567062047. Error: INSTALL_FAILED_INVALID_APK: Split null was defined multiple times
	at com.android.ddmlib.SplitApkInstallerBase.installCommit(SplitApkInstallerBase.java:171)
	at com.android.ddmlib.SplitApkInstaller.install(SplitApkInstaller.java:85)
	at com.android.ddmlib.IDeviceSharedImpl.installPackages(IDeviceSharedImpl.java:395)
	at com.android.ddmlib.internal.DeviceImpl.lambda$installPackages$34(DeviceImpl.java:1491)
	at com.android.ddmlib.internal.DeviceImpl.logRun3(DeviceImpl.java:1833)
	at com.android.ddmlib.internal.DeviceImpl.installPackages(DeviceImpl.java:1488)
	at com.android.ddmlib.internal.DeviceImpl.lambda$installPackages$35(DeviceImpl.java:1503)
	at com.android.ddmlib.internal.DeviceImpl.logRun3(DeviceImpl.java:1833)
	at com.android.ddmlib.internal.DeviceImpl.installPackages(DeviceImpl.java:1499)
	at com.android.tools.utp.plugins.deviceprovider.ddmlib.DdmlibAndroidDevice.installPackages(DdmlibAndroidDevice.kt:74)
	at com.android.tools.utp.plugins.deviceprovider.ddmlib.DdmlibAndroidDeviceController$executeAsync$deferred$1.invokeSuspend(DdmlibAndroidDeviceController.kt:259)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:570)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:749)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:677)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:664)

In short, it tries to install the APK of each architecture at once, instead of the APK for the architecture of the device it is being installed on. To workaround it I have to set splits.abi.enable to false (or comment the whole split block).

There is an older bug report very close to it: https://issuetracker.google.com/issues/172423995

Comments

da...@google.com <da...@google.com> May 17, 2024 07:39PM

Assigned to an...@google.com.

pu...@gmail.com <pu...@gmail.com> #2May 17, 2024 07:42PM

deleted

je...@google.com <je...@google.com> May 21, 2024 06:04PM

Reassigned to mi...@google.com.

pu...@gmail.com <pu...@gmail.com> #3May 21, 2024 06:49PM

(reposting under work account)

We have been hitting this issue constantly. Is it possible to configure those tasks to be non cacheable as a workaround or is that only possible inside of AGP?

Message last modified on Jun 15, 2024 09:45AM

mi...@google.com <mi...@google.com> #4Jun 12, 2024 12:11AM

Marked as fixed.

Currently the only way to disable caching for dexing transforms is to patch AGP manually by providing a patched DexTransform.kt file in buildSrc. Please see https://issuetracker.google.com/169266011#comment27, section on "Workarounds" for an example.

Message last modified on Jun 12, 2024 12:11AM

an...@google.com <an...@google.com> #5Jun 17, 2024 07:32PM

Thanks. Ignoring potential build perf impacts, if we essentially commented out the processIncrementally block in DexingTransform.kt and always ran non-incrementally, would that workaround this issue?

an...@google.com <an...@google.com> #6Jul 11, 2024 09:28PM

Yes, always run the dex transform non-incrementally is another workaround.

ya...@gmail.com <ya...@gmail.com> Jul 28, 2024 12:22AM

20221224_081455.jpg

5.2 MB

View

Download

j0...@gmail.com <j0...@gmail.com> Aug 10, 2024 10:33PM

20221224_081455.jpg

5.2 MB

View

Download

ha...@gmail.com <ha...@gmail.com> #7Aug 12, 2024 09:59PM

Is it possible to do same patch with included build?

ha...@gmail.com <ha...@gmail.com> #8Aug 12, 2024 10:01PM

I guess so, could you give it a try?

ra...@gmail.com <ra...@gmail.com> #9Aug 13, 2024 06:37AM

I've tried(not very neat) but it only work with buildSrc

Anyway, what about issue, I've tried a lot of attempts to fix and helped only turn off jacoco transformation `useJacocoTransformInstrumentation = false`.

What was changed in agp 7.4.x from 7.3.1 that break this?

ma...@google.com <ma...@google.com> #10Oct 1, 2024 04:25PM

Status: Assigned (reopened)

Are you referring to https://issuetracker.google.com/266109833#comment2? That issue is different from this issue.

(Regarding What was changed in agp 7.4.x from 7.3.1 that break this?: I don't know, my theory is that some of your code has changed too when updating AGP, which exposed the Jacoco bug. Please post your comments in that issue if you'd like to continue discussing this.)

mi...@google.com <mi...@google.com> #11Oct 1, 2024 09:06PM

Marked as fixed.

Edit: we were actually not applying the patch correctly, so this was user error.

We've been running with a patched version of DexingTransformer.kt for about a week but are still seeing the issue. First I tried commenting out @CacheableTransform on DexingNoClasspathTransform, but after devs were still experiencing the error, I tried reverting that change and instead applying what I'd suggested in comment #5, but we're still running into the issue.

Is there any other workaround or additional information I can provide to help debug? At first I thought it's perhaps the patched version of DexingTransformer.kt wasn't being picked up, but I confirmed that it was by throwing an exception inside of doTransform.

Message last modified on Oct 1, 2024 09:07PM