Status Update
Comments
jb...@google.com <jb...@google.com>
cl...@google.com <cl...@google.com> #2
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
pr...@google.com <pr...@google.com> #3
ap...@google.com <ap...@google.com> #4
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
jb...@google.com <jb...@google.com> #5
We reviewed the issue as laid out in @Contextual
annotation does not provide quite enough information for the library to determine the type and our current other option would lean into the use of SerialName
which we opted against supporting earlier for a number of reasons. With that conclusion, and since there is a known work around available, we have decided to continue to investigate this and look at possible options in the Navigation 2.9.0 release.
For now, we will improve the error message around this use case to ensure developers are aware of the current status. Follow
pr...@google.com <pr...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.8.0-beta04
dr...@gmail.com <dr...@gmail.com> #7
workaround from
ar...@physitrack.com <ar...@physitrack.com> #9
Is there any official sample on how to use wrapping into value class
to workaround this issue? I also couldn't find a way to make it work.
ap...@google.com <ap...@google.com> #10
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Add nav sample for serializable third party types
Expand for full commit details
Add nav sample for serializable third party types
Sample to show workaround for b/341319151
Test: manual testing
Bug: 341319151
Bug: 348468840
Change-Id: I8c5553029b827440e55c0ecd0ceeb4ffc9957473
Files:
- M
navigation/navigation-compose/samples/src/main/java/androidx/navigation/compose/samples/NavigationSamples.kt
Hash: 16eb5c9060a623a5977f56f10ab782d5b27d6765
Date: Thu Oct 17 18:34:45 2024
pr...@google.com <pr...@google.com> #12
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-compose:2.9.0-alpha02
Description
Component used: Navigation
Version used: androidx.navigation:navigation-compose:2.8.0-beta01
Devices/Android versions reproduced on: emulator, API 34
I have a java.time.LocalDate in the navigation object; I want to implement a custom nav type. Even though, the navigation lib tries to obtain a KotlinX's serializer and crashes.