Supplying an empty list for a startDestination's argument causes app to crash [341723133]

Fixed

Bug

Status Update

No update yet.

Description

do...@google.com

created issue #1

May 20, 2024 05:03PM

Component used: Navigation

Version used: 2.8.0-beta01

Devices/Android versions reproduced on: all

When specifying the startDestination for a NavHost, if the destination class is instantiated with an empty list for one of its properties, the app will crash.

Repro code:

@Composable
fun Content() {
   val navController = rememberNavController()
   NavHost(navController = navController, startDestination = Home(usernames = emptyList())) {
       composable<Home> { backStackEntry ->
           val home: Home = backStackEntry.toRoute()
           for (username in home.usernames) {
               Text(username)
           }
       }
   }
}

@Serializable
data class Home(
   val usernames: List<String>,
)

Expected outcome:

App runs and displays an empty screen

Actual outcome:

App crashes with the following error in logcat:

java.lang.IllegalArgumentException: navigation destination com.example.hellonavigation.Home is not a direct child of this NavGraph

Possibly related to: https://b.corp.google.com/issues/339481310

Comments

jb...@google.com <jb...@google.com> May 21, 2024 02:01PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> #2May 21, 2024 08:29PM

Is there any updates? This is a big problem!

ap...@google.com <ap...@google.com> #3Jun 5, 2024 12:36AM

Hi there - could you provide more context on the issue & a sample project to reproduce? Database locked exceptions are quite difficult to pinpoint without a repro project. Thanks!

ap...@google.com <ap...@google.com> #4Jun 5, 2024 02:11AM

Hi. It is reproduceable on some users by using this code:

suspend fun <R> MyDatabase.workaroundWithTransaction(block: suspend TransactionScope<R>.() -> R) {
    useWriterConnection {
        it.immediateTransaction(block)
    }

    // TODO: Temporally fix https://issuetracker.google.com/issues/340606803#comment2
    // Manually triggers invalidation
    invalidationTracker.refreshAsync()
}

ap...@google.com <ap...@google.com> #5Jun 6, 2024 06:19PM

Maybe it is about this? https://android-review.googlesource.com/c/platform/frameworks/support/+/3114928

I am not sure.

ap...@google.com <ap...@google.com> #6Jun 6, 2024 06:19PM

Hi. Please merge the pull request. This is big problem!

cl...@google.com <cl...@google.com> #7Jun 6, 2024 06:41PM

Marked as fixed.

Hi. Is there any updates on this problem?

pr...@google.com <pr...@google.com> #8Jun 12, 2024 10:45PM

Hi, I updated my version to alpha12 but still have these crashes. Please release a fix asap.